GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — net: wait for shutdown to complete before closing by ronag · Pull Request #32491 · nodejs/node

Conversation

@ronag

@ronag ronag commented Mar 25, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: #32486 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and himself65 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@ronag
net: wait for shutdown to complete before closing
3bf1c08 
When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: nodejs#32486 (comment)
@ronag ronag added wip Issues and PRs that are still a work in progress. net Issues and PRs related to the net subsystem. labels Mar 25, 2020
@ronag

ronag commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

This is WIP I'm expecting it to fail in CI on win10 (#32487)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30067/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 25, 2020
View reviewed changes
ronag added 2 commits March 25, 2020 22:26
@ronag
fixup: test
93c6f75
@ronag
fixup: test
c485b6a
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30069/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ronag added 3 commits March 25, 2020 22:30
@ronag
fixup: tst
871866e
@ronag
fixup: test
fb389dc
@ronag
fixup: apply win10 fix
a9382cb
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2020 •
edited by addaleax
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30072/ (:yellow_heart:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag removed the wip Issues and PRs that are still a work in progress. label Mar 25, 2020
ronag
ronag commented Mar 25, 2020
View reviewed changes
Comment thread test/async-hooks/test-graph.tls-write.js
{ type: 'TCPWRAP', id: 'tcp:2', triggerAsyncId: 'tcpserver:1' },
{ type: 'TLSWRAP', id: 'tls:2', triggerAsyncId: 'tcpserver:1' },
{ type: 'Immediate', id: 'immediate:1', triggerAsyncId: 'tcp:2' },
{ type: 'Immediate', id: 'immediate:2', triggerAsyncId: 'tcp:1' },

@ronag ronag Mar 25, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of Immediate here is platform dependent...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronag
ronag requested a review from jasnell March 25, 2020 22:11
@ronag

ronag commented Mar 25, 2020

Copy link
Copy Markdown
Member Author

@addaleax PTAL, I've applied the required win10 fix. I think this should be able to land as a patch?
addaleax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 25, 2020
View reviewed changes
@ronag
ronag requested a review from sam-github March 25, 2020 22:21
@ronag ronag added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 25, 2020
@addaleax addaleax added the review wanted PRs that need review. label Mar 28, 2020
lpinca
lpinca approved these changes Mar 29, 2020
View reviewed changes
@lpinca

lpinca commented Mar 29, 2020

Copy link
Copy Markdown
Member

I don't understand why the lib/internal/stream_base_commons.js change is needed (#32487). The other changes make sense.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag

ronag commented Apr 1, 2020

Copy link
Copy Markdown
Member Author

Landed in 138eb32
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag closed this Apr 1, 2020
ronag added a commit that referenced this pull request Apr 1, 2020
@ronag
net: wait for shutdown to complete before closing
138eb32 
When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: #32486 (comment)

PR-URL: #32491
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@ronag @BethGriggs
net: wait for shutdown to complete before closing
8f29680 
When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: #32486 (comment)

PR-URL: #32491
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@ronag @targos
net: wait for shutdown to complete before closing
3c8bf90 
When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: #32486 (comment)

PR-URL: #32491
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@ronag @targos
net: wait for shutdown to complete before closing
ed21d32 
When not allowing half open, handle.close would be
invoked before shutdown has been called and
completed causing a potential data race.

Fixes: #32486 (comment)

PR-URL: #32491
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@jasnell jasnell Awaiting requested review from jasnell
@sam-github sam-github Awaiting requested review from sam-github

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. net Issues and PRs related to the net subsystem. review wanted PRs that need review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ShutdownWrap vs handle.close

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ronag @nodejs-github-bot @lpinca @addaleax
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.