GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — test: revise test-http-client-default-headers-exist by Trott · Pull Request #32493 · nodejs/node Conversation
Member
Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
This comment has been minimized.
This comment has been minimized.
jasnell
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not an issue with this particular test, but keep in mind that changing all of these to use Promises is changing the timing of these tests... rather than executing the countdown cleanup logic synchronously it is being deferred to the microtask queue. That could end up causing the test to miss issues that may exist when closing things down synchronously so worth watching... also, keep this issue in mind also when refactoring these :-) .. as I said, not an issue on this particular test but there are some where it may be relevant.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30132/ (:yellow_heart:) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: nodejs#32493 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
Landed in 436c71d |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: #32493 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
* Remove assert.strictEqual where assert.ok suffices * Replace countdown with Promise.all() PR-URL: #32493 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.