GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: handle report options on fatalerror by sam-github · Pull Request #32497 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Mar 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Follow on to #32207, 3 other options
are also not respected under situations that the isolate is not
available.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • testcases added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. labels Mar 26, 2020
@sam-github

sam-github commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

Running C++ linter...
File "src/node_report.cc" does not use "PerIsolateOptions"

Which is kindof the point... I'll look into suppressing that.

And it seems the markdown linter has dozens of complaints about the collaborator and cpp style guides.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 26, 2020
cli, report: move --report-on-fatalerror to stable #32496
Merged
diagnostic report behavior on fatal error nodejs/diagnostics#331
Closed
@gireeshpunathil

gireeshpunathil commented Mar 26, 2020

Copy link
Copy Markdown
Member

@sam-github - do you have a test case / story from users that reproduce the issue you are solving here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Mar 26, 2020

Copy link
Copy Markdown
Member

Running C++ linter...
File "src/node_report.cc" does not use "PerIsolateOptions"

Which is kindof the point... I'll look into suppressing that.

Getting rid of the using statement should suffice:
https://github.com/nodejs/node/blob/cca1bae91ffc0cf9739cb4ea336eaa524f8bfba6/src/node_report.cc#L35

And it seems the markdown linter has dozens of complaints about the collaborator and cpp style guides.

Where are you seeing those?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

@gireeshpunathil Its the same case as previous, the previous fix was to make it posible to check the value of --report-on-fatalerror. Now that is checked, and the value of report-on-fatalerror is respected. But actually triggering the report requires access to 3 other cli report values (filename, dirname, compact). Those aren't reachable under the same conditions that report-on-fatalerror did not used to be reachable.

I'll extend the tests to show this.
gireeshpunathil reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gireeshpunathil
gireeshpunathil approved these changes Mar 26, 2020
View reviewed changes
@sam-github
sam-github force-pushed the fix-report-options branch from cca1bae to e5cd075 Compare March 26, 2020 18:52
@sam-github

sam-github commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

@gireeshpunathil I expanded the test suite, run with a version of node predating this and you can see what used to fail.
gireeshpunathil reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github
sam-github force-pushed the fix-report-options branch from e5cd075 to 7400dd2 Compare March 26, 2020 19:00
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30106/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

@nodejs/diagnostics PTAL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30110/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Mar 26, 2020

Copy link
Copy Markdown
Contributor Author

Recurring failure is unrelated: #32510
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Flarna
Flarna approved these changes Mar 26, 2020
View reviewed changes
richardlau
richardlau approved these changes Mar 26, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30111/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30116/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax requested changes Mar 28, 2020
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @cjihrig pointed out in #32535 (review), this is missing guards to protect against race conditions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sam-github
src: handle report options on fatalerror
921d4e0 
Follow on to nodejs#32207, 3 other options
are also not respected under situations that the isolate is not
available.
@sam-github
sam-github force-pushed the fix-report-options branch from 7400dd2 to 921d4e0 Compare March 30, 2020 19:22
@sam-github
sam-github requested a review from addaleax March 30, 2020 19:24
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30272/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30273/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30279/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Mar 31, 2020

Copy link
Copy Markdown
Contributor Author

@addaleax I have implemented the locking, PTAL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 31, 2020
View reviewed changes
sam-github added a commit that referenced this pull request Mar 31, 2020
@sam-github
src: handle report options on fatalerror
867ff41 
Follow on to #32207, 3 other options
are also not respected under situations that the isolate is not
available.

PR-URL: #32497
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@sam-github

sam-github commented Mar 31, 2020

Copy link
Copy Markdown
Contributor Author

@addaleax thank you.

Landed in 867ff41
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github sam-github closed this Mar 31, 2020
@sam-github
sam-github deleted the fix-report-options branch March 31, 2020 19:00
MylesBorins pushed a commit that referenced this pull request Mar 31, 2020
@sam-github @MylesBorins
src: handle report options on fatalerror
04237ec 
Follow on to #32207, 3 other options
are also not respected under situations that the isolate is not
available.

PR-URL: #32497
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@targos targos added the backport-blocked-v12.x label Apr 22, 2020
@sam-github sam-github mentioned this pull request Apr 22, 2020
src,cli: support compact (one-line) JSON reports #32254
Closed
4 tasks done
@targos targos removed the backport-blocked-v12.x label Apr 25, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@sam-github @targos
src: handle report options on fatalerror
c6da2f4 
Follow on to nodejs#32207, 3 other options
are also not respected under situations that the isolate is not
available.

PR-URL: nodejs#32497
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@sam-github @targos
src: handle report options on fatalerror
8e3dd47 
Follow on to #32207, 3 other options
are also not respected under situations that the isolate is not
available.

PR-URL: #32497
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@Flarna Flarna Flarna approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@sam-github @gireeshpunathil @richardlau @nodejs-github-bot @addaleax @Flarna @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.