GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: fix compiler warnings in node_report_module by danbev · Pull Request #32498 · nodejs/node

Conversation

danbev commented Mar 26, 2020

Copy link

Copy Markdown

Contributor

Currently, the following compiler warnings are generated:

../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning: unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning: unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

All reactions

👍 1 reaction


          src: fix compiler warnings in node_report_module

43c2527

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

report Issues and PRs related to Node.js diagnostic reports. labels

Mar 26, 2020

nodejs-github-bot commented Mar 26, 2020

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30082/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cjihrig approved these changes

Mar 26, 2020

View reviewed changes

devnexen approved these changes

Mar 26, 2020

View reviewed changes

gengjiawen approved these changes

Mar 26, 2020

View reviewed changes

gireeshpunathil approved these changes

Mar 26, 2020

View reviewed changes

richardlau approved these changes

Mar 26, 2020

View reviewed changes

danbev commented Mar 27, 2020

Copy link

Copy Markdown

Contributor Author

Re-run of failing node-test-commit-windows-fanned ✔️

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danbev added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Mar 27, 2020

jasnell approved these changes

Mar 27, 2020

View reviewed changes

addaleax commented Mar 28, 2020

Copy link

Copy Markdown

Member

Landed in cd1db2d

danbev reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

addaleax closed this

Mar 28, 2020

addaleax pushed a commit that referenced this pull request

Mar 28, 2020


          src: fix compiler warnings in node_report_module

cd1db2d

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

PR-URL: #32498
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>

danbev deleted the node_report_module_warnings branch

March 30, 2020 04:31

addaleax pushed a commit that referenced this pull request

Mar 30, 2020


          src: fix compiler warnings in node_report_module

fbf0493

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

PR-URL: #32498
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request

Apr 13, 2020

v13.13.0 release proposal #32813

Merged

targos added backport-blocked-v12.x and removed author ready

PRs with CI started, the required approvals, and no outstanding review comments.

backport-blocked-v12.x labels

Apr 22, 2020

targos pushed a commit to targos/node that referenced this pull request

Apr 25, 2020


          src: fix compiler warnings in node_report_module

f9c0c3e

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

PR-URL: nodejs#32498
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos pushed a commit that referenced this pull request

Apr 28, 2020


          src: fix compiler warnings in node_report_module

16d85d9

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

PR-URL: #32498
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos mentioned this pull request

May 2, 2020

v12.17.0 release proposal #33197

Merged

Reviewers

jasnell

jasnell approved these changes

cjihrig

cjihrig approved these changes

gengjiawen

gengjiawen approved these changes

richardlau

richardlau approved these changes

gireeshpunathil

gireeshpunathil approved these changes

+1 more reviewer

devnexen

devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

report

Issues and PRs related to Node.js diagnostic reports.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.