GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: changed functional logic in cluster schedulers by yashLadha · Pull Request #32505 · nodejs/node

Conversation

@yashLadha

@yashLadha yashLadha commented Mar 26, 2020

Copy link
Copy Markdown
Contributor

Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65 and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Mar 26, 2020
@yashLadha yashLadha changed the title lib: changed functional login in cluster schedulers lib: changed functional logic in cluster schedulers Mar 26, 2020
@yashLadha
yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from ea584c4 to e3e536f Compare March 26, 2020 14:20
addaleax
addaleax approved these changes Mar 26, 2020
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Mar 26, 2020
View reviewed changes
mscdex
mscdex reviewed Mar 26, 2020
View reviewed changes
Comment thread lib/internal/cluster/round_robin_handle.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha
yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from e3e536f to 7e551a7 Compare March 26, 2020 16:18
@nodejs-github-bot

nodejs-github-bot commented Mar 26, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30112/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos reviewed Mar 27, 2020
View reviewed changes
Comment thread lib/internal/cluster/round_robin_handle.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/cluster/round_robin_handle.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha
yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from 7e551a7 to 00f3d5e Compare March 27, 2020 09:43
targos
targos reviewed Mar 27, 2020
View reviewed changes
Comment thread lib/internal/cluster/round_robin_handle.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha
yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from 00f3d5e to 3791aba Compare March 27, 2020 10:16
targos
targos approved these changes Mar 27, 2020
View reviewed changes
jasnell
jasnell approved these changes Mar 27, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 2, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30403/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha
lib: changed functional logic in cluster schedulers
e8f1115 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.
@yashLadha
yashLadha force-pushed the refactor/functional_changes_scheduling_handlers branch from 3791aba to e8f1115 Compare April 4, 2020 15:30
trivikr
trivikr approved these changes Apr 4, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30457/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30521/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30528/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@yashLadha

yashLadha commented Apr 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Latest CI passed but still there are failure jobs marked? 😕
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Apr 7, 2020

Copy link
Copy Markdown
Member

Latest CI passed but still there are failure jobs marked? confused

Yeah, that’s a oddity with the way that the github bot reports results back to github from Jenkins. The Jenkins status is what counts here, so this is all good 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Apr 7, 2020

Copy link
Copy Markdown
Member

Landed in 6faa162
yashLadha reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Apr 7, 2020
@yashLadha @addaleax
lib: changed functional logic in cluster schedulers
6faa162 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax addaleax closed this Apr 7, 2020
targos pushed a commit that referenced this pull request Apr 12, 2020
@yashLadha @targos
lib: changed functional logic in cluster schedulers
94251c4 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@yashLadha @BethGriggs
lib: changed functional logic in cluster schedulers
ce79923 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@yashLadha @targos
lib: changed functional logic in cluster schedulers
7dd001c 
Free pool in round_robin scheduler is implemented as an array. There
were constant lookups being for distributing load on other workers in
free pool. Reimplementing in Map will create will be more performant as
compared to Array implementation. This was done for all in past but free
wasn't implemented at that time.

PR-URL: #32505
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@trivikr trivikr trivikr approved these changes
+2 more reviewers
@mscdex mscdex mscdex left review comments
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. cluster Issues and PRs related to the cluster subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@yashLadha @nodejs-github-bot @addaleax @mscdex @jasnell @targos @gireeshpunathil @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.