GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove non required console.log by juanarbol · Pull Request #32541 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Mar 29, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Mar 29, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30164/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZYSzys
ZYSzys approved these changes Mar 29, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Mar 29, 2020
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Alternatively, you could change the console.log() to util.debuglog().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
jasnell
jasnell approved these changes Mar 29, 2020
View reviewed changes
@jasnell

jasnell commented Mar 29, 2020

Copy link
Copy Markdown
Member

LGTM. Alternatively, you could change the console.log() to util.debuglog().

If you wanted to do this, include const debug = require('util').debuglog('test') at the top of the file then call debug('...')
juanarbol reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol juanarbol mentioned this pull request Mar 29, 2020
test: replace console.log for debug in test #32550
Closed
3 tasks done
@juanarbol

juanarbol commented Mar 29, 2020

Copy link
Copy Markdown
Member Author

If you wanted to do this, include const debug = require('util').debuglog('test') at the top of the file then call debug('...')

Something like this?

I think this test does not require logging very much.
jasnell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Mar 30, 2020
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Commit message suggestion:

test: remove unnecessary console.log() calls

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
juanarbol reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@juanarbol
test: remove unnecessary console.log() calls
c21e9b9
@juanarbol
juanarbol force-pushed the juanarbol/remove-console-log branch from 9550ead to c21e9b9 Compare March 30, 2020 20:18
@juanarbol

juanarbol commented Mar 30, 2020

Copy link
Copy Markdown
Member Author

LGTM.

Commit message suggestion:

test: remove unnecessary console.log() calls

Commit reword is done! Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30304/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZYSzys ZYSzys added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 1, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 2, 2020 •
edited by addaleax
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30374/ ✔️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@juanarbol @addaleax
test: replace console.log() with debuglog()
579e6b9 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@addaleax

addaleax commented Apr 2, 2020

Copy link
Copy Markdown
Member

Landed in 9a914ff
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@juanarbol @addaleax
test: remove unnecessary console.log() calls
9a914ff 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax addaleax closed this Apr 2, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@juanarbol @BethGriggs
test: replace console.log() with debuglog()
b2339c8 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@juanarbol @BethGriggs
test: remove unnecessary console.log() calls
9d6adf3 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@juanarbol @targos
test: replace console.log() with debuglog()
8f0c106 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@juanarbol @targos
test: remove unnecessary console.log() calls
30505d7 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
test: replace console.log() with debuglog()
30d21fb 
PR-URL: #32550
Refs: #32541
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
test: remove unnecessary console.log() calls
4165312 
PR-URL: #32541
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
@juanarbol
juanarbol deleted the juanarbol/remove-console-log branch January 19, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@juanarbol @nodejs-github-bot @jasnell @addaleax @Trott @cjihrig @ZYSzys
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.