GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — worker: do not emit 'exit' events during process.exit() by addaleax · Pull Request #32546 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Mar 29, 2020

Copy link
Copy Markdown
Member

Do not emit 'exit' events caused by recursively stopping all
running Workers from inside the process.exit() call.

(Split out from #32531 as this is semver-patch and should definitely be backported to LTS.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and linroid reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@addaleax
worker: do not emit 'exit' events during process.exit()
8feec47 
Do not emit `'exit'` events caused by recursively stopping all
running Workers from inside the `process.exit()` call.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 29, 2020
@addaleax addaleax added lts-watch-v10.x worker Issues and PRs related to the worker_threads module and Worker API. labels Mar 29, 2020
@addaleax
fixup! worker: do not emit 'exit' events during process.exit()
6cc7965
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30165/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax mentioned this pull request Mar 29, 2020
embedding: provide hook for custom process.exit() behaviour #32531
Closed
4 tasks done
gireeshpunathil
gireeshpunathil approved these changes Mar 29, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2020 •
edited by addaleax
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30167/ (:heavy_check_mark:)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Mar 29, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Mar 29, 2020
cjihrig
cjihrig approved these changes Mar 29, 2020
View reviewed changes
addaleax added a commit that referenced this pull request Apr 2, 2020
@addaleax
worker: do not emit 'exit' events during process.exit()
8b9e877 
Do not emit `'exit'` events caused by recursively stopping all
running Workers from inside the `process.exit()` call.

PR-URL: #32546
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@addaleax

addaleax commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

Landed in 8b9e877
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Apr 2, 2020
@addaleax
addaleax deleted the worker-no-exit-event branch April 2, 2020 00:46
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@addaleax @BethGriggs
worker: do not emit 'exit' events during process.exit()
0c2100b 
Do not emit `'exit'` events caused by recursively stopping all
running Workers from inside the `process.exit()` call.

PR-URL: #32546
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@addaleax @targos
worker: do not emit 'exit' events during process.exit()
4acd7f4 
Do not emit `'exit'` events caused by recursively stopping all
running Workers from inside the `process.exit()` call.

PR-URL: #32546
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@addaleax @targos
worker: do not emit 'exit' events during process.exit()
aeea7d9 
Do not emit `'exit'` events caused by recursively stopping all
running Workers from inside the `process.exit()` call.

PR-URL: #32546
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
@addaleax addaleax removed the lts-watch-v12.x label Apr 28, 2020
@richardlau

richardlau commented Jul 2, 2020

Copy link
Copy Markdown
Member

This cherry picks cleanly onto v10.x-staging but the test fails, probably because workers in 10.x are experimental and require a flag.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the backport-requested-v10.x label Jul 2, 2020
@yurynix yurynix mentioned this pull request Jun 13, 2023
Spawn a new worker when an old one is stopped allegro/node-worker-nodes#62
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@addaleax @nodejs-github-bot @richardlau @jasnell @cjihrig @gireeshpunathil
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.