GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix more broken links by mildsunrise · Pull Request #32586 · nodejs/node

Conversation

@mildsunrise

@mildsunrise mildsunrise commented Mar 31, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This proposes some improvements to the Markdown link checker from #32359:

  • Check link definitions too
  • Report all broken links in a file, not just the first one
  • Avoid use of workers & other simplifications (launching ~90 workers has substantial overhead; in my 4-core machine this makes it 25% faster)
  • Exclude doc/changelogs because they're huge files which take very long to parse, and (IIRC) are auto-generated anyway (this cuts out 90% of the time)

Then fix the broken links, and exclude test/fixtures as there's some invalid links there.

Pinging @aduh95 as he wrote the tool :) Feel free to review, and if there's some detail I've missed from your code, tell me and I'll fix it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 and himself65 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
mildsunrise added 2 commits March 31, 2020 18:59
@mildsunrise
doc: improve markdown link checker
18f14bb 
- Test link definitions too
- Report all broken links in a file, not just the first one
- Avoid use of workers (launching ~90 workers has substantial
  overhead, and in my 4-core machine it is slower than not using
  them at all) & other simplifications

Refs: nodejs#32359
@mildsunrise
doc: fix more links
8bc34c7 
Fix broken links found by the checker, and exclude
test/fixtures as it contains invalid links.

Also exclude doc/changelogs because they're huge files
which take very long to parse, and (IIRC) are auto-generated
anyway.

(Oh and also a nit at the README next to my link)
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 31, 2020
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30287/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mildsunrise

mildsunrise commented Mar 31, 2020

Copy link
Copy Markdown
Contributor Author

(Btw I attempted to check HTTP links too, and it takes about 10 seconds. Problem is, we have ~400 of them and Github just starts returning 429 after some point 😔)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Mar 31, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30288/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Mar 31, 2020
View reviewed changes
jasnell
jasnell approved these changes Mar 31, 2020
View reviewed changes
aduh95
aduh95 approved these changes Apr 1, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30345/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30349/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mildsunrise mildsunrise added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 1, 2020
@mildsunrise mildsunrise self-assigned this Apr 2, 2020
@mildsunrise

mildsunrise commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

Landed in 9800732...882b61a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mildsunrise mildsunrise closed this Apr 2, 2020
mildsunrise added a commit that referenced this pull request Apr 2, 2020
@mildsunrise
doc: improve markdown link checker
77f9e0c 
- Test link definitions too
- Report all broken links in a file, not just the first one
- Avoid use of workers (launching ~90 workers has substantial
  overhead, and in my 4-core machine it is slower than not using
  them at all) & other simplifications

Refs: #32359

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
mildsunrise added a commit that referenced this pull request Apr 2, 2020
@mildsunrise
doc: fix more links
882b61a 
Fix broken links found by the checker, and exclude
test/fixtures as it contains invalid links.

Also exclude doc/changelogs because they're huge files
which take very long to parse, and (IIRC) are auto-generated
anyway.

(Oh and also a nit at the README next to my link)

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mildsunrise
mildsunrise deleted the fix-doc-links branch April 2, 2020 21:39
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@mildsunrise @BethGriggs
doc: improve markdown link checker
18ca874 
- Test link definitions too
- Report all broken links in a file, not just the first one
- Avoid use of workers (launching ~90 workers has substantial
  overhead, and in my 4-core machine it is slower than not using
  them at all) & other simplifications

Refs: #32359

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@mildsunrise @BethGriggs
doc: fix more links
2e52ca0 
Fix broken links found by the checker, and exclude
test/fixtures as it contains invalid links.

Also exclude doc/changelogs because they're huge files
which take very long to parse, and (IIRC) are auto-generated
anyway.

(Oh and also a nit at the README next to my link)

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@mildsunrise @targos
doc: improve markdown link checker
d513b55 
- Test link definitions too
- Report all broken links in a file, not just the first one
- Avoid use of workers (launching ~90 workers has substantial
  overhead, and in my 4-core machine it is slower than not using
  them at all) & other simplifications

Refs: #32359

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@mildsunrise @targos
doc: fix more links
1dee8c1 
Fix broken links found by the checker, and exclude
test/fixtures as it contains invalid links.

Also exclude doc/changelogs because they're huge files
which take very long to parse, and (IIRC) are auto-generated
anyway.

(Oh and also a nit at the README next to my link)

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@mildsunrise @targos
doc: improve markdown link checker
d764414 
- Test link definitions too
- Report all broken links in a file, not just the first one
- Avoid use of workers (launching ~90 workers has substantial
  overhead, and in my 4-core machine it is slower than not using
  them at all) & other simplifications

Refs: #32359

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@mildsunrise @targos
doc: fix more links
f93b770 
Fix broken links found by the checker, and exclude
test/fixtures as it contains invalid links.

Also exclude doc/changelogs because they're huge files
which take very long to parse, and (IIRC) are auto-generated
anyway.

(Oh and also a nit at the README next to my link)

PR-URL: #32586
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@mildsunrise mildsunrise

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@mildsunrise @nodejs-github-bot @jasnell @addaleax @cjihrig @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.