GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: adjust paths in openssl maintenance guide by hassaanp · Pull Request #32593 · nodejs/node

Conversation

@hassaanp

@hassaanp hassaanp commented Apr 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The path for the crypto files in the deps/openssl/openssl/
after running cd deps/openssl/config && make has been changed.
The original path deps/openssl/openssl/crypto/includes/internal/
now maps to deps/openssl/openssl/includes/cryptofor the files that
need to be added for the commit.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 1, 2020
sam-github
sam-github approved these changes Apr 1, 2020
View reviewed changes

@sam-github sam-github left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

[ ] commit message follows commit guidelines

^--- please amend (git commit --amend ) your commit message, it is longer than 50 chars, and is not descriptive. I suggest:

doc: adjust paths in openssl maintenance guide

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
addaleax
addaleax approved these changes Apr 1, 2020
View reviewed changes

@addaleax addaleax left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just to be clear, the commit message can also be updated by whoever merges this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sam-github

sam-github commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

the commit message can also be updated by whoever merges this.

@hassaanp, we can do that for you if you'd like, but you look like you are on track to becoming a consistent contributor, so its worth getting up to speed on how to use git to maintain your branches, and becoming familiar with the contribution guidelines.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hassaanp

hassaanp commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

@sam-github - you are right. I will fix the commit and push it shortly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hassaanp
doc: adjust paths in openssl maintenance guide
8ec3211 
The path for the crypto files in the `deps/openssl/openssl/`
after running `cd deps/openssl/config && make` has been changed.
The original path `deps/openssl/openssl/crypto/includes/internal/`
now maps to `deps/openssl/openssl/includes/crypto`for the files that
need to be added for the commit.
@hassaanp
hassaanp force-pushed the doc/update-maintainence-guide-for-openssl branch from 5cf2a23 to 8ec3211 Compare April 1, 2020 16:20
@hassaanp

hassaanp commented Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

@sam-github applied your suggestion.
Thanks :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github sam-github changed the title doc: updated maintainence guide for openssl maintainence doc: adjust paths in openssl maintenance guide Apr 1, 2020
jasnell
jasnell approved these changes Apr 1, 2020
View reviewed changes
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 2, 2020
trivikr
trivikr approved these changes Apr 4, 2020
View reviewed changes
@addaleax

addaleax commented Apr 5, 2020

Copy link
Copy Markdown
Member

Landed in a1b6ae6, thanks for the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Apr 5, 2020
addaleax pushed a commit that referenced this pull request Apr 5, 2020
@hassaanp @addaleax
doc: adjust paths in openssl maintenance guide
a1b6ae6 
The path for the crypto files in the `deps/openssl/openssl/`
after running `cd deps/openssl/config && make` has been changed.
The original path `deps/openssl/openssl/crypto/includes/internal/`
now maps to `deps/openssl/openssl/includes/crypto`for the files that
need to be added for the commit.

PR-URL: #32593
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@hassaanp @BethGriggs
doc: adjust paths in openssl maintenance guide
73ed0fd 
The path for the crypto files in the `deps/openssl/openssl/`
after running `cd deps/openssl/config && make` has been changed.
The original path `deps/openssl/openssl/crypto/includes/internal/`
now maps to `deps/openssl/openssl/includes/crypto`for the files that
need to be added for the commit.

PR-URL: #32593
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@hassaanp @targos
doc: adjust paths in openssl maintenance guide
1e72605 
The path for the crypto files in the `deps/openssl/openssl/`
after running `cd deps/openssl/config && make` has been changed.
The original path `deps/openssl/openssl/crypto/includes/internal/`
now maps to `deps/openssl/openssl/includes/crypto`for the files that
need to be added for the commit.

PR-URL: #32593
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@hassaanp @targos
doc: adjust paths in openssl maintenance guide
5e2791e 
The path for the crypto files in the `deps/openssl/openssl/`
after running `cd deps/openssl/config && make` has been changed.
The original path `deps/openssl/openssl/crypto/includes/internal/`
now maps to `deps/openssl/openssl/includes/crypto`for the files that
need to be added for the commit.

PR-URL: #32593
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@sam-github sam-github sam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hassaanp @sam-github @addaleax @jasnell @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.