GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix python-version selection with actions by MylesBorins · Pull Request #32609 · nodejs/node

Conversation

@MylesBorins

@MylesBorins MylesBorins commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

s/PYTHON_VERSION/python-version

according to official docs we have not been selecting python correctly in our actions

Refs: https://github.com/actions/setup-python

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MylesBorins
test: fix python-version selection with actions
27a5590
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python
@MylesBorins MylesBorins added dont-land-on-v10.x labels Apr 2, 2020
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 2, 2020
@MylesBorins
MylesBorins requested a review from mmarchini April 2, 2020 03:08
mmarchini
mmarchini approved these changes Apr 2, 2020
View reviewed changes
targos
targos approved these changes Apr 2, 2020
View reviewed changes
richardlau
richardlau approved these changes Apr 2, 2020
View reviewed changes
ZYSzys
ZYSzys approved these changes Apr 2, 2020
View reviewed changes
jasnell
jasnell approved these changes Apr 2, 2020
View reviewed changes
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@MylesBorins @addaleax
test: fix python-version selection with actions
f36e248
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python

PR-URL: #32609
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax

addaleax commented Apr 2, 2020

Copy link
Copy Markdown
Member

Landed in f36e248

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@addaleax addaleax closed this Apr 2, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@MylesBorins @BethGriggs
test: fix python-version selection with actions
1073f81
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python

PR-URL: #32609
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@MylesBorins @targos
test: fix python-version selection with actions
a7b6a10
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python

PR-URL: #32609
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
@richardlau richardlau mentioned this pull request May 27, 2020
build: fix python-version selection with actions #33589
Merged
1 task done
richardlau added a commit to richardlau/node-1 that referenced this pull request May 29, 2020
@richardlau
build: fix python-version selection with actions
69612b7
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python
Refs: nodejs#32609

PR-URL: nodejs#33589
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@richardlau @codebytere
build: fix python-version selection with actions
e393e87
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python
Refs: #32609

PR-URL: #33589
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@richardlau @codebytere
build: fix python-version selection with actions
860c8aa
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python
Refs: #32609

PR-URL: #33589
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
@richardlau @codebytere
build: fix python-version selection with actions
11dad02
s/PYTHON\_VERSION/python-version

Refs: https://github.com/actions/setup-python
Refs: #32609

PR-URL: #33589
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes
+2 more reviewers
@targos targos targos approved these changes
@mmarchini mmarchini mmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@MylesBorins @addaleax @jasnell @targos @mmarchini @richardlau @ZYSzys @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.