GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: copy addons .gitignore to test/abort/ by addaleax · Pull Request #32624 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Apr 2, 2020

Copy link
Copy Markdown
Member

cp test/addons/.gitignore test/abort/.gitignore, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use git add . earlier or later.

Refs: #31740

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@addaleax
test: copy addons .gitignore to test/abort/
6e065a3 
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: nodejs#31740
@addaleax addaleax added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 2, 2020
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 2, 2020
@addaleax

addaleax commented Apr 2, 2020

Copy link
Copy Markdown
Member Author

Please 👍 this comment to approve fast-tracking
richardlau and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Apr 2, 2020
View reviewed changes
@richardlau

richardlau commented Apr 2, 2020

Copy link
Copy Markdown
Member

Fwiw I don’t think that new test will be run on the CI because the test configuration won’t find it. But that’s one for a follow up PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Apr 2, 2020

Copy link
Copy Markdown
Member

Fwiw I don’t think that new test will be run on the CI because the test configuration won’t find it. But that’s one for a follow up PR.

Yeah the new test wasn't being run and AFAICT it's broken: #31740 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax removed the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 2, 2020
@richardlau richardlau added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Apr 3, 2020
@richardlau

richardlau commented Apr 3, 2020

Copy link
Copy Markdown
Member

Fwiw I don’t think that new test will be run on the CI because the test configuration won’t find it. But that’s one for a follow up PR.

Yeah the new test wasn't being run and AFAICT it's broken: #31740 (comment)

Believe I've fixed up the test: #32626
I almost accidentally added the build directory to that PR, so 💯 👍 to fast tracking this one.
addaleax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Apr 3, 2020
View reviewed changes
@addaleax addaleax added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Apr 5, 2020
@addaleax

addaleax commented Apr 5, 2020

Copy link
Copy Markdown
Member Author

Landed in cf659c8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax added a commit that referenced this pull request Apr 5, 2020
@addaleax
test: copy addons .gitignore to test/abort/
cf659c8 
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax closed this Apr 5, 2020
@addaleax
addaleax deleted the abort-gitignore branch April 5, 2020 19:13
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@addaleax @BethGriggs
test: copy addons .gitignore to test/abort/
e968775 
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@addaleax @targos
test: copy addons .gitignore to test/abort/
17a3dce 
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@addaleax @targos
test: copy addons .gitignore to test/abort/
90a5b9d 
`cp test/addons/.gitignore test/abort/.gitignore`, because the new
addon test in there leaves a build/ folder lying around and somebody
is bound to use `git add .` earlier or later.

Refs: #31740

PR-URL: #32624
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
@richardlau richardlau mentioned this pull request May 1, 2020
Revert test-abort-aliased-buffer-overflow #33196
Merged
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@addaleax @richardlau @jasnell @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.