GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove unused variables on async hook test by julianduque · Pull Request #32630 · nodejs/node

Conversation

@julianduque

@julianduque julianduque commented Apr 3, 2020

Copy link
Copy Markdown
Contributor

This commit removes the id and type arguments from the mustCall
function on init.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
yerminson, pablocyc, amenpunk, edsadr, julianduque, and bricss reacted with heart emoji
All reactions
  • ❤️ 6 reactions
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Apr 3, 2020
addaleax
addaleax approved these changes Apr 3, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Apr 3, 2020
View reviewed changes
jvelezpo
jvelezpo approved these changes Apr 3, 2020
View reviewed changes
targos
targos approved these changes Apr 3, 2020
View reviewed changes
tniessen
tniessen approved these changes Apr 3, 2020
View reviewed changes
jasnell
jasnell approved these changes Apr 3, 2020
View reviewed changes
lpinca
lpinca approved these changes Apr 3, 2020
View reviewed changes
@julianduque
test: remove unused variables on async hook test
652a521 
This commit remove the `id` and `type` arguments from the mustCall
function on init.
@julianduque
julianduque force-pushed the julianduque/remove-unused-variables-ah-test branch from ad1b8b2 to 652a521 Compare April 3, 2020 23:18
@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 5, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30470/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30482/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30490/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Apr 6, 2020

Copy link
Copy Markdown
Member

Landed in 056e687
julianduque reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Apr 6, 2020
addaleax pushed a commit that referenced this pull request Apr 6, 2020
@julianduque @addaleax
test: remove unused variables on async hook test
056e687 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@julianduque
julianduque deleted the julianduque/remove-unused-variables-ah-test branch April 6, 2020 19:11
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@julianduque @BethGriggs
test: remove unused variables on async hook test
aea24b7 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 12, 2020
@julianduque @targos
test: remove unused variables on async hook test
6d12242 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@julianduque @targos
test: remove unused variables on async hook test
6feed98 
This commit remove the `id` and `type` arguments from the mustCall
function on init.

PR-URL: #32630
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
+2 more reviewers
@jvelezpo jvelezpo jvelezpo approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@julianduque @nodejs-github-bot @addaleax @jasnell @jvelezpo @lpinca @targos @cjihrig @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.