GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: improve line-wrapping in net.md by Trott · Pull Request #32671 · nodejs/node

Conversation

@Trott

@Trott Trott commented Apr 5, 2020

Copy link
Copy Markdown
Member

Fix up a few instances that don't need to exceed 80 characters.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem. labels Apr 5, 2020
@Trott

Trott commented Apr 6, 2020

Copy link
Copy Markdown
Member Author

I guess the commit message isn't quite right. This doesn't exactly improve line-wrapping. It gets a bunch of lines under 80 chars without affecting rendering. Right now, the maximum line length lint rule is disabled for net.md, and this gets us close to being able to enable it.

@nodejs/documentation @nodejs/linting
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Apr 6, 2020
View reviewed changes
nschonni
nschonni approved these changes Apr 6, 2020
View reviewed changes

@nschonni nschonni left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe doc: remove optional parameter from markdown anchor link

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
tniessen
tniessen approved these changes Apr 6, 2020
View reviewed changes
trivikr
trivikr approved these changes Apr 6, 2020
View reviewed changes
@Trott
doc: remove optional parameter from markdown anchor link
c849f2d 
Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: nodejs#32671
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Trott force-pushed the wrap-net branch from 43c3c02 to c849f2d Compare April 7, 2020 22:19
@Trott

Trott commented Apr 7, 2020

Copy link
Copy Markdown
Member Author

Landed in c849f2d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit c849f2d into nodejs:master Apr 7, 2020
@Trott
Trott deleted the wrap-net branch April 7, 2020 22:19
targos pushed a commit that referenced this pull request Apr 12, 2020
@Trott @targos
doc: remove optional parameter from markdown anchor link
f41660a 
Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: #32671
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@Trott @BethGriggs
doc: remove optional parameter from markdown anchor link
7abba3f 
Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: #32671
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
doc: remove optional parameter from markdown anchor link
a5fd29b 
Fix up a few instances so that lines don't xceed 80 characters.

PR-URL: #32671
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@nschonni nschonni nschonni approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @nschonni @lpinca @tniessen @trivikr @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.