GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — report: fix stderr matching for fatal error by gengjiawen · Pull Request #32699 · nodejs/node

Conversation

@gengjiawen

@gengjiawen gengjiawen commented Apr 7, 2020

Copy link
Copy Markdown
Member

Fix nodejs/node-v8#153

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added report Issues and PRs related to Node.js diagnostic reports. test Issues and PRs related to Node.js core tests and test infrastructure. labels Apr 7, 2020
@gengjiawen
gengjiawen requested a review from mmarchini April 7, 2020 04:29
sam-github
sam-github approved these changes Apr 7, 2020
View reviewed changes

@sam-github sam-github left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than lint errors, LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gengjiawen
report: fix stderr matching for fatal error
d9ddd2f
@gengjiawen
gengjiawen force-pushed the bugfix/report_match branch from 834ab9f to d9ddd2f Compare April 7, 2020 06:04
devnexen
devnexen approved these changes Apr 7, 2020
View reviewed changes
richardlau
richardlau approved these changes Apr 7, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30533/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Apr 7, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30535/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mmarchini
mmarchini approved these changes Apr 7, 2020
View reviewed changes

@mmarchini mmarchini left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I'm a bit surprised the older output didn't have <--- Last few GCs ---> lines though, I'm certain I've seen it in the past...)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sam-github

sam-github commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

@mmarchini perhaps a difference in the order of the output lines.
mmarchini reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gengjiawen added a commit that referenced this pull request Apr 9, 2020
@gengjiawen
report: fix stderr matching for fatal error
b82d72c 
PR-URL: #32699
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@gengjiawen

gengjiawen commented Apr 9, 2020

Copy link
Copy Markdown
Member Author

Landed in b82d72c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen gengjiawen closed this Apr 9, 2020
@gengjiawen
gengjiawen deleted the bugfix/report_match branch April 9, 2020 06:46
targos pushed a commit that referenced this pull request Apr 12, 2020
@gengjiawen @targos
report: fix stderr matching for fatal error
9b84103 
PR-URL: #32699
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@gengjiawen @BethGriggs
report: fix stderr matching for fatal error
e7352f5 
PR-URL: #32699
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@targos targos added backport-blocked-v12.x and removed backport-blocked-v12.x labels Apr 22, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@gengjiawen @targos
report: fix stderr matching for fatal error
579af42 
PR-URL: nodejs#32699
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
targos pushed a commit that referenced this pull request Apr 28, 2020
@gengjiawen @targos
report: fix stderr matching for fatal error
f945a5e 
PR-URL: #32699
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
@targos targos mentioned this pull request May 2, 2020
v12.17.0 release proposal #33197
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
+3 more reviewers
@sam-github sam-github sam-github approved these changes
@mmarchini mmarchini mmarchini approved these changes
@devnexen devnexen devnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

report Issues and PRs related to Node.js diagnostic reports. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test broken on report/test-report-fatal-error

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@gengjiawen @nodejs-github-bot @sam-github @cjihrig @mmarchini @devnexen @richardlau @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.