GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: output dots instead of tap in GitHub actions by targos · Pull Request #32714 · nodejs/node

Conversation

@targos

@targos targos commented Apr 8, 2020

Copy link
Copy Markdown
Member

This makes the output much smaller and lets us focus on errors if there
are any.

Otherwise, the UI becomes too slow and prevents navigating in the test output. The output is still too long IMO but this reduces it significantly
I'm open to alternative ways to pass that option to the test runner.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@targos
build: output dots instead of tap in GitHub actions
ae743c8 
This makes the output much smaller and lets us focus on errors if there
are any.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. labels Apr 8, 2020
Trott
Trott approved these changes Apr 8, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30558/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau reviewed Apr 8, 2020
View reviewed changes
Comment thread .github/workflows/test-linux.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@targos
no makefile change
4d35de2
richardlau
richardlau approved these changes Apr 8, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Apr 8, 2020
View reviewed changes
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 8, 2020
trivikr
trivikr approved these changes Apr 11, 2020
View reviewed changes
targos added a commit that referenced this pull request Apr 12, 2020
@targos
build: output dots instead of tap in GitHub actions
57aba5e 
This makes the output much smaller and lets us focus on errors if there
are any.

PR-URL: #32714
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos

targos commented Apr 12, 2020

Copy link
Copy Markdown
Member Author

Landed in 57aba5e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Apr 12, 2020
@targos
targos deleted the actions-test-dots branch April 12, 2020 12:00
targos added a commit that referenced this pull request Apr 13, 2020
@targos
build: output dots instead of tap in GitHub actions
34f05ce 
This makes the output much smaller and lets us focus on errors if there
are any.

PR-URL: #32714
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@targos @BethGriggs
build: output dots instead of tap in GitHub actions
4fc3383 
This makes the output much smaller and lets us focus on errors if there
are any.

PR-URL: #32714
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
targos added a commit that referenced this pull request Apr 22, 2020
@targos
build: output dots instead of tap in GitHub actions
20f3e9d 
This makes the output much smaller and lets us focus on errors if there
are any.

PR-URL: #32714
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@targos @nodejs-github-bot @Trott @cjihrig @richardlau @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.