GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: remove duplicated code by himself65 · Pull Request #32719 · nodejs/node

Conversation

@himself65

@himself65 himself65 commented Apr 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

node/src/spawn_sync.cc

Lines 1036 to 1045 in d09e1da

Local<String> string;
if (!value->ToString(env()->isolate()->GetCurrentContext())
.ToLocal(&string))
return Nothing<int>();
js_array
->Set(context,
i,
value->ToString(env()->isolate()->GetCurrentContext())
.ToLocalChecked())
.Check();

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. labels Apr 8, 2020
addaleax
addaleax approved these changes Apr 8, 2020
View reviewed changes
@himself65

himself65 commented Apr 8, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

BTW, Do we have rules for something like no-unused-vars(ESLint) in C++ linter?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Apr 8, 2020
View reviewed changes
@addaleax

addaleax commented Apr 8, 2020

Copy link
Copy Markdown
Member

@himself65 I don’t think so, but I think for C++ that might be quite a bit harder to implement than it is for JS, because the constructor/destructor of a variable might be relevant (e.g. HandleScopes might appear like unused variables that way).

However, the compiler will generally emit warnings for unused variables where it can tell that they are useless.
himself65 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Apr 8, 2020

Copy link
Copy Markdown
Member

Ah, btw, the commit message should start with src: here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@himself65

himself65 commented Apr 8, 2020

Copy link
Copy Markdown
Member Author

Ah, btw, the commit message should start with src: here.

oh, I didn't notice that
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@himself65
src: remove duplicated code
5b0ad2a
@himself65
himself65 force-pushed the 20200408-fix branch from e18e817 to 5b0ad2a Compare April 8, 2020 15:37
Flarna
Flarna approved these changes Apr 9, 2020
View reviewed changes
@himself65 himself65 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30584/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Apr 10, 2020
View reviewed changes
gengjiawen
gengjiawen approved these changes Apr 11, 2020
View reviewed changes
@himself65 himself65 self-assigned this Apr 11, 2020
himself65 added a commit to himself65/node that referenced this pull request Apr 11, 2020
@himself65
src: remove duplicated code
1c4b205 
PR-URL: nodejs#32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@himself65

himself65 commented Apr 11, 2020

Copy link
Copy Markdown
Member Author

Landed in 1c4b205
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@himself65 himself65 closed this Apr 11, 2020
@himself65
himself65 deleted the 20200408-fix branch April 11, 2020 06:27
targos pushed a commit that referenced this pull request Apr 12, 2020
@himself65 @targos
src: remove duplicated code
ea17855 
PR-URL: #32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@himself65 @BethGriggs
src: remove duplicated code
fb0c4fa 
PR-URL: #32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@himself65 @targos
src: remove duplicated code
d0d7ebc 
PR-URL: #32719
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@addaleax addaleax addaleax approved these changes
@cjihrig cjihrig cjihrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@Flarna Flarna Flarna approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@himself65 himself65

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@himself65 @addaleax @nodejs-github-bot @jasnell @cjihrig @gengjiawen @Flarna
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.