GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: remove unused v8::TryCatch namespace by juanarbol · Pull Request #32729 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Apr 8, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 8, 2020
@juanarbol
src: remove unused v8::TryCatch namespace
fc069a0
@juanarbol
juanarbol force-pushed the juanarbol/remove-unusedv8-namespace branch from 2f3c01e to fc069a0 Compare April 8, 2020 23:20
addaleax
addaleax approved these changes Apr 9, 2020
View reviewed changes
Flarna
Flarna approved these changes Apr 9, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30579/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65
himself65 approved these changes Apr 9, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Apr 9, 2020
View reviewed changes
@himself65 himself65 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 9, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30587/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Apr 9, 2020
View reviewed changes
@targos

targos commented Apr 9, 2020

Copy link
Copy Markdown
Member

Would it be possible to have a lint rule for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Apr 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Would it be possible to have a lint rule for this?

I thought we had a tool for looking for unused using.

Edit: https://github.com/nodejs/node/blob/master/tools/check-imports.py. If it isn't catching this I assume it's #29226.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Apr 9, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30601/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30634/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30637/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30639/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65 pushed a commit that referenced this pull request Apr 11, 2020
@juanarbol @himself65
src: remove unused v8::TryCatch namespace
468d05a 
PR-URL: #32729
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@himself65

himself65 commented Apr 11, 2020

Copy link
Copy Markdown
Member

Landed in 468d05a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@himself65 himself65 closed this Apr 11, 2020
targos pushed a commit that referenced this pull request Apr 13, 2020
@juanarbol @targos
src: remove unused v8::TryCatch namespace
c8a007f 
PR-URL: #32729
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@juanarbol @BethGriggs
src: remove unused v8::TryCatch namespace
27a82cc 
PR-URL: #32729
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
src: remove unused v8::TryCatch namespace
f9d9414 
PR-URL: #32729
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
@juanarbol
juanarbol deleted the juanarbol/remove-unusedv8-namespace branch January 19, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@himself65 himself65 himself65 approved these changes
@Flarna Flarna Flarna approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@juanarbol @nodejs-github-bot @targos @richardlau @himself65 @addaleax @lpinca @cjihrig @Flarna
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.