GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: replace node-test-pull-request-lite-pipeline from onboarding by juanarbol · Pull Request #32736 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Apr 9, 2020

Copy link
Copy Markdown
Member

Replace the obsolete node-test-pull-request-lite-pipeline CI
task in favour of node-test-pull-request-pipeline.

I've updated the docs based on this comment

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65 and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 9, 2020
@himself65
himself65 requested a review from Trott April 9, 2020 05:50
richardlau
richardlau reviewed Apr 9, 2020
View reviewed changes
Comment thread onboarding.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol
doc: replace node-test-pull-request-lite-pipeline from onboarding
12b7f00 
Replace the obsolete node-test-pull-request-lite-pipeline CI
task in favour of node-test-pull-request.
@juanarbol
juanarbol force-pushed the juanarbol/onboarding-changes branch from 8c7825e to 12b7f00 Compare April 9, 2020 13:39
richardlau
richardlau approved these changes Apr 9, 2020
View reviewed changes
Trott
Trott reviewed Apr 9, 2020
View reviewed changes
Comment thread onboarding.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Apr 9, 2020
View reviewed changes
jasnell
jasnell approved these changes Apr 10, 2020
View reviewed changes
himself65
himself65 approved these changes Apr 11, 2020
View reviewed changes
@himself65 himself65 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 11, 2020
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30635/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30638/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Apr 11, 2020

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/30638/

Because this is a documentation-only change, it does not need to pass Jenkins. Passing the GitHub Actions tests is sufficient per https://github.com/nodejs/node/blob/master/doc/guides/collaborator-guide.md#testing-and-ci.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Apr 11, 2020

Copy link
Copy Markdown
Member

Landed in 5c53538
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Apr 11, 2020
Trott pushed a commit that referenced this pull request Apr 11, 2020
@juanarbol @Trott
doc: replace node-test-pull-request-lite-pipeline from onboarding
5c53538 
Replace the obsolete node-test-pull-request-lite-pipeline CI
task in favour of node-test-pull-request.

PR-URL: #32736
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
targos pushed a commit that referenced this pull request Apr 13, 2020
@juanarbol @targos
doc: replace node-test-pull-request-lite-pipeline from onboarding
18b5e04 
Replace the obsolete node-test-pull-request-lite-pipeline CI
task in favour of node-test-pull-request.

PR-URL: #32736
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@juanarbol @BethGriggs
doc: replace node-test-pull-request-lite-pipeline from onboarding
f423826 
Replace the obsolete node-test-pull-request-lite-pipeline CI
task in favour of node-test-pull-request.

PR-URL: #32736
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@juanarbol @targos
doc: replace node-test-pull-request-lite-pipeline from onboarding
b1790fb 
Replace the obsolete node-test-pull-request-lite-pipeline CI
task in favour of node-test-pull-request.

PR-URL: #32736
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
@juanarbol
juanarbol deleted the juanarbol/onboarding-changes branch January 19, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax left review comments
@richardlau richardlau richardlau approved these changes
@jasnell jasnell jasnell approved these changes
@himself65 himself65 himself65 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@juanarbol @nodejs-github-bot @Trott @jasnell @addaleax @richardlau @himself65
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.