GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: removes unused v8::Integer and v8::Array namespace by JesuHrz · Pull Request #32779 · nodejs/node

Conversation

@JesuHrz

@JesuHrz JesuHrz commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

This PR removes unused v8::Integer and v8::Array namespace

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss, fabolivar, and yesiddg reacted with thumbs up emoji
All reactions
  • 👍 3 reactions
@JesuHrz
src: removes unused v8::Integer and v8::Array namespace
3ce3d05
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 11, 2020
gireeshpunathil
gireeshpunathil approved these changes Apr 11, 2020
View reviewed changes
himself65
himself65 approved these changes Apr 11, 2020
View reviewed changes
cjihrig
cjihrig approved these changes Apr 11, 2020
View reviewed changes
Flarna
Flarna approved these changes Apr 11, 2020
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30643/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Flarna Flarna added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 12, 2020
himself65 pushed a commit that referenced this pull request Apr 13, 2020
@JesuHrz @himself65
src: removes unused v8::Integer and v8::Array namespace
a8c2431 
PR-URL: #32779
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@himself65

himself65 commented Apr 13, 2020

Copy link
Copy Markdown
Member

Landed in a8c2431
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@himself65 himself65 closed this Apr 13, 2020
targos pushed a commit that referenced this pull request Apr 13, 2020
@JesuHrz @targos
src: removes unused v8::Integer and v8::Array namespace
611dbf8 
PR-URL: #32779
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@targos targos mentioned this pull request Apr 13, 2020
v13.13.0 release proposal #32813
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@JesuHrz @BethGriggs
src: removes unused v8::Integer and v8::Array namespace
90c4113 
PR-URL: #32779
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
targos pushed a commit that referenced this pull request Apr 22, 2020
@JesuHrz @targos
src: removes unused v8::Integer and v8::Array namespace
522101d 
PR-URL: #32779
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@targos targos mentioned this pull request Apr 22, 2020
v12.16.3 release proposal #33009
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@himself65 himself65 himself65 approved these changes
@Flarna Flarna Flarna approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JesuHrz @nodejs-github-bot @himself65 @cjihrig @gireeshpunathil @Flarna
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.