GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v10.x] openssl 1.1.1g by sam-github · Pull Request #32982 · nodejs/node

Conversation

@sam-github

@sam-github sam-github commented Apr 21, 2020

Copy link
Copy Markdown
Contributor

Backport-of: #32971

I had to cherry-pick 1.1.1f before 1.1.1g, and regenerate the config, no other edits were required.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added openssl Issues and PRs related to the OpenSSL dependency. v10.x labels Apr 21, 2020
@sam-github sam-github mentioned this pull request Apr 21, 2020
deps: update openssl to openssl1.1.1g #32971
Closed
2 of 4 tasks
@sam-github

sam-github commented Apr 21, 2020

Copy link
Copy Markdown
Contributor Author

Pushed a fixup --- some files that are present on 12.x were here, and didn't get regenerated because 10.x doesn't use them. I rm -rfed deps/openssl/config/arch, and then regenerated the config again, and it looks they are gone.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Apr 21, 2020

Copy link
Copy Markdown
Contributor Author

There was a comment here about conflict markers, but it got deleted or something? Not sure why it was in my email but not visible here. Anyhow, whoever that was, thanks for noticing.
JesuHrz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30904/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JesuHrz

JesuHrz commented Apr 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey @sam-github , it was me who I deleted it because I was afraid I was wrong.
Anyhow, you're welcome 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sam-github

sam-github commented Apr 22, 2020

Copy link
Copy Markdown
Contributor Author

You were correct, though the files aren't used so it wouldn't have caused issues, but it wasn't intended or tidy. And hey, we've all been wrong on github before, its no big deal even if you were, if something doesn't make sense to you, this is the place to ask.
JesuHrz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31009/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BethGriggs
BethGriggs force-pushed the v10.x-staging branch from a85721a to 145dcc2 Compare June 2, 2020 18:16
@sam-github sam-github mentioned this pull request Jun 3, 2020
[v10.x] Openssl 1.1.1f #32601
Closed
4 tasks
hassaanp added 3 commits July 1, 2020 09:14
@hassaanp @richardlau
deps: upgrade openssl sources to 1.1.1f
663bbf3 
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz
    $ mv openssl-1.1.0h openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: nodejs#32583
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@hassaanp @richardlau
deps: upgrade openssl sources to 1.1.1g
9c5a36a 
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz
    $ mv openssl-1.1.1g openssl
    $ git add --all openssl
    $ git commit openssl
@hassaanp @richardlau
deps: update archs files for OpenSSL-1.1.1g
51b43b2 
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
   $ cd deps/openssl/config
   $ make
   $ git add deps/openssl/config/archs
   $ git add deps/openssl/openssl/include/crypto/bn_conf.h
   $ git add deps/openssl/openssl/include/crypto/dso_conf.h
   $ git add deps/openssl/openssl/include/openssl/opensslconf.h
   $ git commit
@richardlau
richardlau force-pushed the openssl1.1.1g-v10.x branch from 79e338d to 51b43b2 Compare July 1, 2020 13:16
@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2020 •
edited by richardlau
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32184/ (💛)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Jul 1, 2020
View reviewed changes
richardlau pushed a commit that referenced this pull request Jul 1, 2020
@hassaanp @richardlau
deps: upgrade openssl sources to 1.1.1f
ef9413b 
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz
    $ mv openssl-1.1.0h openssl
    $ git add --all openssl
    $ git commit openssl

Backport-PR-URL: #32982
PR-URL: #32583
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 1, 2020
@hassaanp @richardlau
deps: upgrade openssl sources to 1.1.1g
94702c1 
This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz
    $ mv openssl-1.1.1g openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: #32982
Reviewed-By: Richard Lau <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 1, 2020
@hassaanp @richardlau
deps: update archs files for OpenSSL-1.1.1g
745b329 
After an OpenSSL source update, all the config files need to be
regenerated and committed by:
   $ cd deps/openssl/config
   $ make
   $ git add deps/openssl/config/archs
   $ git add deps/openssl/openssl/include/crypto/bn_conf.h
   $ git add deps/openssl/openssl/include/crypto/dso_conf.h
   $ git add deps/openssl/openssl/include/openssl/opensslconf.h
   $ git commit

PR-URL: #32982
Reviewed-By: Richard Lau <[email protected]>
@richardlau

richardlau commented Jul 1, 2020

Copy link
Copy Markdown
Member

Landed in aaf2f82...745b329.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau closed this Jul 1, 2020
@richardlau richardlau mentioned this pull request Jul 2, 2020
v10.22.0 proposal #34170
Merged
2 of 4 tasks
richardlau added a commit that referenced this pull request Jul 2, 2020
@richardlau
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
5cf3b31 
Notable changes:

- deps:
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    [#32982](#32982)
- n-api:
  * add `napi_detach_arraybuffer` (legendecas)
    [#29768](#29768)
richardlau added a commit that referenced this pull request Jul 6, 2020
@richardlau
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
6a26d1e 
Notable changes:

- deps:
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  * add `napi_detach_arraybuffer` (legendecas)
    #29768
richardlau added a commit that referenced this pull request Jul 7, 2020
@richardlau
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
b4ac3b1 
Notable changes:

- deps:
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
richardlau added a commit that referenced this pull request Jul 13, 2020
@richardlau
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
eaa9e4d 
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
richardlau added a commit that referenced this pull request Jul 15, 2020
@richardlau
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
c5215d0 
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
BethGriggs pushed a commit that referenced this pull request Jul 21, 2020
@richardlau @BethGriggs
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
95770df 
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@richardlau @cjihrig
2020-07-21, Version 10.22.0 'Dubnium' (LTS)
8ad4920 
Notable changes:

- deps:
  - upgrade npm to 6.14.6 (claudiahdz)
    #34246
  - upgrade openssl sources to 1.1.1g (Hassaan Pasha)
    #32982
- n-api:
  - add `napi_detach_arraybuffer` (legendecas)
    #29768

PR-URL: #34170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sam-github @nodejs-github-bot @JesuHrz @richardlau @hassaanp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.