GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v12.x] Disable headers timeout by ShogunPanda · Pull Request #33307 · nodejs/node

Conversation

@ShogunPanda

@ShogunPanda ShogunPanda commented May 8, 2020

Copy link
Copy Markdown
Contributor

Setting headersTimeout to 0 does not disable the checks as expected but rather makes any request fail immediately.

This PR fixes the problem. This should also be backported to 10.x.
Node 13 and 14/master are fine since headersTimeout live now in HTTPParser which correctly checks for the value being greater than 0.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
ShogunPanda added 2 commits April 29, 2020 09:25
@ShogunPanda
http: disable headersTimeout check when set to zero
87e26dc
@ShogunPanda
doc: updated headersTimeout documentation
563692b
@nodejs-github-bot nodejs-github-bot added http Issues and PRs related to the http subsystem. v12.x labels May 8, 2020
@ShogunPanda
lint: fix failures
2eb7c2e
@benjamingr

benjamingr commented May 8, 2020

Copy link
Copy Markdown
Member

Hey thank you for your contribution, would you mind adding a test for this?
BridgeAR reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShogunPanda

ShogunPanda commented May 8, 2020

Copy link
Copy Markdown
Contributor Author

Good point, I forgot. Will add it now!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ShogunPanda
test: add test for disabled headersTimeout
31cfa4d
@ShogunPanda

ShogunPanda commented May 11, 2020

Copy link
Copy Markdown
Contributor Author

For some reason "now" became "3 days". :)
Anyway the test is there now!
benjamingr and GaryGSC reacted with laugh emoji
All reactions
  • 😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes May 11, 2020
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented May 11, 2020

Copy link
Copy Markdown
Member

I'm not 100% sure about this, but I think this needs to be opened against v12.x-staging rather than v12.x. (Someone else, please confirm!) @nodejs/releasers
richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 11, 2020

Copy link
Copy Markdown
Member

I'm not 100% sure about this, but I think this needs to be opened against v12.x-staging rather than v12.x. (Someone else, please confirm!) @nodejs/releasers

That's correct
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos changed the title Disable headers timeout [v12.x] Disable headers timeout May 11, 2020
@targos targos added the lts-watch-v10.x label May 11, 2020
@ShogunPanda
ShogunPanda changed the base branch from v12.x to v12.x-staging May 12, 2020 18:05
@ShogunPanda

ShogunPanda commented May 12, 2020

Copy link
Copy Markdown
Contributor Author

@Trott @targos Sorry for the wrong branch. I've updated the PR to be open against v12.x-staging.
targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented May 13, 2020

Copy link
Copy Markdown
Member

/cc @nodejs/http
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos
targos force-pushed the v12.x-staging branch from 2c847d8 to daf1d84 Compare May 13, 2020 15:54
BridgeAR
BridgeAR approved these changes May 23, 2020
View reviewed changes
@BridgeAR

BridgeAR commented May 23, 2020

Copy link
Copy Markdown
Member

@targos should this still be included in the next v12 release?

@nodejs/http @nodejs/http2 @nodejs/streams PTAL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31512/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina

mcollina commented May 23, 2020

Copy link
Copy Markdown
Member

I hope it would be included.
BridgeAR reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@BridgeAR BridgeAR mentioned this pull request May 23, 2020
v12.17.0 release proposal #33197
Merged
targos pushed a commit that referenced this pull request May 25, 2020
@ShogunPanda @targos
http: disable headersTimeout check when set to zero
ebd9090 
PR-URL: #33307
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos

targos commented May 25, 2020

Copy link
Copy Markdown
Member

Landed in ebd9090. Thanks @ShogunPanda
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this May 25, 2020
@ShogunPanda
ShogunPanda deleted the disable-headers-timeout branch May 25, 2020 13:48
@blushingpenguin blushingpenguin mentioned this pull request Jun 24, 2020
disable keep alive timeout, headers timeout and log any server timeouts JeringTech/Javascript.NodeJS#85
Merged
richardlau pushed a commit that referenced this pull request Jul 2, 2020
@ShogunPanda @richardlau
http: disable headersTimeout check when set to zero
069b6e1 
PR-URL: #33307
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@richardlau richardlau removed the lts-watch-v10.x label Jul 2, 2020
@richardlau richardlau added the backported-to-v10.x label Jul 2, 2020
@richardlau richardlau mentioned this pull request Jul 2, 2020
v10.22.0 proposal #34170
Merged
2 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

http Issues and PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@ShogunPanda @benjamingr @Trott @targos @BridgeAR @nodejs-github-bot @mcollina @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.