GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — quic,timers: use AbortController with correct name/message by addaleax · Pull Request #34763 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Aug 13, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
quic: use AbortController with correct name/message

On the web, AbortError is the error name, not the error
message. Change the code to match that.

timers: use AbortController with correct name/message

On the web, AbortError is the error name, not the error
message. Change the code to match that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@addaleax
addaleax requested review from a team and jasnell August 13, 2020 19:07
@nodejs-github-bot

nodejs-github-bot commented Aug 13, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v12.x quic Issues and PRs related to the QUIC transport implementation. labels Aug 13, 2020
jasnell
jasnell approved these changes Aug 13, 2020
View reviewed changes
@aduh95

aduh95 commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

Typo in the commit message: AbortController is the error name, but in the code the error name is AbortError.
addaleax reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax added 2 commits August 14, 2020 12:30
@addaleax
quic: use AbortController with correct name/message
6a78fc7 
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.
@addaleax
timers: use AbortController with correct name/message
a515a31 
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 14, 2020
@addaleax
addaleax force-pushed the abort-error branch from 29bd9f1 to a515a31 Compare August 14, 2020 10:30
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 14, 2020
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32787/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Aug 15, 2020
View reviewed changes
@Trott

Trott commented Aug 15, 2020

Copy link
Copy Markdown
Member

Landed in 9594b54...5d179cb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Aug 15, 2020
Trott pushed a commit that referenced this pull request Aug 15, 2020
@addaleax @Trott
quic: use AbortController with correct name/message
ba5c64b 
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: #34763
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Trott pushed a commit that referenced this pull request Aug 15, 2020
@addaleax @Trott
timers: use AbortController with correct name/message
5d179cb 
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: #34763
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott

Trott commented Aug 15, 2020

Copy link
Copy Markdown
Member

Any semver concerns with the timers change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax
addaleax deleted the abort-error branch August 16, 2020 20:47
@addaleax

addaleax commented Aug 16, 2020

Copy link
Copy Markdown
Member Author

@Trott Given that AbortController has not been released yet, I don’t think so.
Trott reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added backport-open-v14.x and removed dont-land-on-v14.x labels Apr 24, 2021
@targos targos mentioned this pull request Apr 24, 2021
[v14.x] Backport AbortController and friends #38386
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@addaleax @targos
timers: use AbortController with correct name/message
26b7626 
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: nodejs#34763
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@addaleax @targos
timers: use AbortController with correct name/message
4b04bb8 
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: #34763
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos removed the backport-open-v14.x label Apr 30, 2021
@targos targos added the backported-to-v14.x label Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@addaleax @nodejs-github-bot @aduh95 @Trott @jasnell @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.