GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v14.x] Backport AbortController and friends by targos · Pull Request #38386 · nodejs/node

Conversation

@targos

@targos targos commented Apr 24, 2021

Copy link
Copy Markdown
Member

This is a first batch of backports for AbortController.

  • lib: initial experimental AbortController implementation (lib: initial experimental AbortController implementation #33527)
    This only backports the first semver-minor commit.
  • timers: allow promisified timeouts/immediates to be canceled (timers: allow promisified timeouts/immediates to be canceled #33833)
  • timers: fix multipleResolves in promisified timeouts/immediates (timers: fix multipleResolves in promisified timeouts/immediates #33949)
  • timers: move promisified timers implementations (timers: introduce timers/promises #33950)
    This introduces an internal module (internal/timers/promises) to avoid the semver-major change.
  • timers: use AbortController with correct name/message (quic,timers: use AbortController with correct name/message #34763)
    Only the timers commit.
  • events: allow use of AbortController with once (events: allow use of AbortController with once #34911)
  • events: allow use of AbortController with on (events: allow use of AbortController with on #34912)
  • doc: revise AbortSignal text and example using events.once (doc: revise AbortSignal text and example using events.once() #35005)
  • doc: make AbortSignal text consistent in events.md (doc: revise AbortSignal text and example using events.once() #35005)
  • events: make abort_controller event trusted (events: make abort_controller event trusted #35811)
  • lib: let abort_controller target be EventTarget (lib, test: integrate wpt abort_controller tests and fix onabort event #35869)
  • test: integrate abort_controller tests from wpt (lib, test: integrate wpt abort_controller tests and fix onabort event #35869)
  • fs: add support for AbortSignal in readFile (fs: add support for AbortSignal in readFile #35911)
  • fs: support abortsignal in writeFile (fs: support abortsignal in writeFile #35993)
  • events: add a few tests (events: add a few tests #35806)
  • events: support emit on nodeeventtarget (events: support emit on nodeeventtarget #35851)
  • events: define event handler as enumerable (events: support defining event handlers on prototypes #35931)
  • events: support event handlers on prototypes (events: support defining event handlers on prototypes #35931)
  • events: define abort on prototype (events: support defining event handlers on prototypes #35931)
  • events: fire handlers in correct oder (events: support defining event handlers on prototypes #35931)
  • events: disabled manual construction AbortSignal (events: disabled manual construction AbortSignal #36094)
  • events: getEventListeners static (events: getEventListeners static #35991)
  • http: add support for abortsignal to http.request (http: add support for abortsignal to http.request #36048)
  • http2: add support for AbortSignal to http2Session.request (http2: add support for AbortSignal to http2Session.request #36070)
  • child_process: add AbortSignal support (child_process: add AbortSignal support #36308)
  • test: increase execFile abort coverage (test: increase readfile abort coverage #36429)
  • child_process: clean event listener correctly (child_process: clean event listener correctly #36424)
  • child_process: add signal support to spawn (child_process: add signal support to spawn #36432)
  • child_process: support AbortSignal in fork (child_process: support AbortSignal in fork #36603)
  • timers: refactor to use validateAbortSignal (lib: refactor to use validateAbortSignal #36604)
  • dgram: support AbortSignal in createSocket (dgram: support AbortSignal in createSocket #37026)
  • fs: add AbortSignal support to watch (fs: add AbortSignal support to watch #37190)
  • fs: fix pre-aborted writeFile AbortSignal file leak (fs: fix pre-aborted writeFile AbortSignal file leak #37393)
  • doc: recommend checking abortSignal.aborted first (doc: recommend checking abortSignal.aborted first #37714)
  • events: add max listener warning for EventTarget (events: add max listener warning for EventTarget #36001)
  • lib: set abort-controller toStringTag (lib: set abort-controller toStringTag #36115)
  • lib: implement AbortSignal.abort() (lib: implement AbortSignal.abort() #37693)
  • test: update dom/abort tests (lib: implement AbortSignal.abort() #37693)
  • lib: add brand checks to AbortController and AbortSignal (lib: add brand checks to AbortController and AbortSignal #37720)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v14.x labels Apr 24, 2021
@targos

targos commented Apr 24, 2021

Copy link
Copy Markdown
Member Author

/cc @jasnell @benjamingr

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Apr 24, 2021

Copy link
Copy Markdown
Member Author

I did not include commits adding abort support to streams because there were big conflicts for them and this is already a big patch set.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37670/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 24, 2021
benjamingr
benjamingr approved these changes Apr 25, 2021
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds two globals in a non-semver-major fashion.

I am LGTMing the actual backport - but please be very careful with the implications for users.

For example:

  • A user is using an abortcontroller polyfill that implements the interface in a non whatwg spec compliant way.
  • We backport AbortController as a global
  • The polyfill now sees the global so it doesn't polyfill
  • The user relying on the non-spec-compliant behaviour (like AbortSignal being an EventEmitter) has code breakage because of a minor version Node.js update

I am not sure how common or realistic the above is.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@targos

targos commented Apr 25, 2021

Copy link
Copy Markdown
Member Author

@benjamingr This doesn't backport the global by default (it stays behind the --experimental-abortcontroller flag), so anyone using a polyfill should see no difference in behaviour, and I think they should be able to use our abort-compatible APIs with it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@benjamingr

benjamingr commented Apr 25, 2021

Copy link
Copy Markdown
Member

Ok, I thought that was "coming", if this stays behind a flag and is only global in our eslint config etc then LGTM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danielleadams
danielleadams approved these changes Apr 26, 2021
View reviewed changes
@danielleadams

danielleadams commented Apr 26, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@targos do you want more reviewers given the number of commits, or should I go ahead and backport this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37727/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Apr 26, 2021

Copy link
Copy Markdown
Member Author

I'd love to have some more eyes on this as it's not a trivial backport. Let's keep it open 24 more hours.

danielleadams reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos
targos force-pushed the backport-abort-controller-v14.x branch from d0c99b1 to a4045c8 Compare April 26, 2021 07:33
@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37729/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37734/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@benjamingr

benjamingr commented Apr 26, 2021

Copy link
Copy Markdown
Member

Fwiw I actually went through the changes here and they look fine - not a rubberstamp lgtm :)

targos and danielleadams reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37753/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Apr 27, 2021

Copy link
Copy Markdown
Member Author

I'm starting to think that this somehow breaks test-fs-write-file on Raspberry Pi... That same test failed on every CI run for this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Linkgoron

Linkgoron commented Apr 29, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@targos that test is broken, the last test in test-fs-write-file is writing to text4.txt, and also the one that's failing is also writing to the same file (see lines 59 and 91).

It was fixed in master here: #36102

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell and others added 8 commits April 30, 2021 08:59
@jasnell @targos
lib: initial experimental AbortController implementation
1cff8fd
AbortController impl based very closely on:
 https://github.com/mysticatea/abort-controller

Marked experimental.
Not currently used by any of the existing promise apis.

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#33527
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell @targos
timers: allow promisified timeouts/immediates to be canceled
c86e131
Using the new experimental AbortController...

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#33833
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@lundibundi @targos
timers: fix multipleResolves in promisified timeouts/immediates
290ce9f
After successful timer finish the abort event callback would still
reject (already resolved promise) upon calling abortController.abort().

Signed-off-by: Denys Otrishko <[email protected]>

PR-URL: nodejs#33949
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell @targos
timers: move promisified timers implementations
d097171
Move the promisified timers implementations into a new internal.
submodule.

Also adds `ref` option to the promisified versions.

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#33950
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@addaleax @targos
timers: use AbortController with correct name/message
26b7626
On the web, `AbortError` is the error name, not the error
message. Change the code to match that.

PR-URL: nodejs#34763
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@jasnell @targos
events: allow use of AbortController with once
268686a
Allows an AbortSignal to be passed in to events.once() to cancel
waiting on an event.

Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#34911
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@jasnell @targos
events: allow use of AbortController with on
51031f3
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#34912
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@Trott @targos
doc: revise AbortSignal text and example using events.once()
affb52d
Add a line to the example code to clarify what happens if an event is
emitted after listening is canceled. Make minor revisions to surrounding
text.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@watilde @targos
lib: let abort_controller target be EventTarget
b2f8e8d
The AbortController abort event should have EventTarget as a target
property of the argument event.

PR-URL: #35869
Backport-PR-URL: #38386
Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@watilde @targos
test: integrate abort_controller tests from wpt
88f4261
Refs: web-platform-tests/wpt#9361

PR-URL: #35869
Backport-PR-URL: #38386
Refs: https://github.com/web-platform-tests/wpt/blob/master/dom/abort/event.any.js
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
fs: add support for AbortSignal in readFile
5f88b64
PR-URL: #35911
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
fs: support abortsignal in writeFile
219cd00
PR-URL: #35993
Backport-PR-URL: #38386
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: add a few tests
6558ffa
PR-URL: #35806
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: support emit on nodeeventtarget
e51d7c5
PR-URL: #35851
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: define event handler as enumerable
6e21e82
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: support event handlers on prototypes
bdad1bc
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: define abort on prototype
7c95cfc
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: fire handlers in correct oder
daad521
PR-URL: #35931
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
64cd54b
Fixes: #36064

PR-URL: #36094
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
events: getEventListeners static
6e734a8
PR-URL: #35991
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
http: add support for abortsignal to http.request
524b713
PR-URL: #36048
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@MadaraUchiha @targos
http2: add support for AbortSignal to http2Session.request
336fb18
- Add support
- Add test
- Docs once PR is up

PR-URL: #36070
Backport-PR-URL: #38386
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
child_process: add AbortSignal support
a5c0f39
PR-URL: #36308
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@shootermv @targos
test: increase execFile abort coverage
dc63ca6
Verify that if something different than Abortcontroller.signal is passed
to child_process.execFile(), ERR_INVALID_ARG_TYPE is thrown.

PR-URL: #36429
Backport-PR-URL: #38386
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
child_process: clean event listener correctly
6c08c9d
I was working on AbortSignal for spawn and noticed there is a leak in
the current code for AbortSignal support in child_process since it
removes the wrong listener. I used the new signal as argument feature
to make removing the listener easier and added a test.

PR-URL: #36424
Backport-PR-URL: #38386
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
child_process: add signal support to spawn
0b691ce
PR-URL: #36432
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
child_process: support AbortSignal in fork
385e8e8
PR-URL: #36603
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@Lxxyx @targos
timers: refactor to use validateAbortSignal
1b74a08
PR-URL: #36604
Backport-PR-URL: #38386
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
Nitzan Uziely @targos
dgram: support AbortSignal in createSocket
81cd06b
PR-URL: #37026
Backport-PR-URL: #38386
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
fs: add AbortSignal support to watch
7aa2e5d
PR-URL: #37190
Backport-PR-URL: #38386
Refs: #37179
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
Nitzan Uziely @targos
fs: fix pre-aborted writeFile AbortSignal file leak
0269413
Fix an issue in writeFile where a file is opened, and not closed
if the abort signal is aborted after the file was opened
but before writing began.

PR-URL: #37393
Backport-PR-URL: #38386
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@jasnell @targos
doc: recommend checking abortSignal.aborted first
cf4fa79
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37714
Backport-PR-URL: #38386
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@jasnell @targos
events: add max listener warning for EventTarget
3006302
Signed-off-by: James M Snell <[email protected]>

PR-URL: #36001
Backport-PR-URL: #38386
Fixes: #35990
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@benjamingr @targos
lib: set abort-controller toStringTag
4cd9f39
PR-URL: #36115
Backport-PR-URL: #38386
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@jasnell @targos
lib: implement AbortSignal.abort()
448a6a2
Refs: whatwg/dom#960

PR-URL: #37693
Backport-PR-URL: #38386
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@jasnell @targos
test: update dom/abort tests
397d937
Signed-off-by: James M Snell <[email protected]>

PR-URL: #37693
Backport-PR-URL: #38386
Refs: whatwg/dom#960
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@MattiasBuelens @targos
lib: add brand checks to AbortController and AbortSignal
b1507c4
PR-URL: #37720
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@Trott @targos
test: fix unreliable test-fs-write-file.js
de654bf
The test uses a file name twice, causing unreliability in CI. In
particular, it's failing a lot on the Raspberry Pi devices.

Fixes: #36090

PR-URL: #36102
Backport-PR-URL: #38386
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
+1 more reviewer
@danielleadams danielleadams danielleadams approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

16 participants

@targos @nodejs-github-bot @benjamingr @danielleadams @Linkgoron @richardlau @jasnell @lundibundi @addaleax @Trott @watilde @RaisinTen @MadaraUchiha @shootermv @Lxxyx @MattiasBuelens
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.