GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: revise AbortSignal text and example using events.once() by Trott · Pull Request #35005 · nodejs/node

Conversation

@Trott

@Trott Trott commented Sep 1, 2020

Copy link
Copy Markdown
Member

Add a line to the example code to clarify what happens if an event is
emitted after listening is canceled. Make minor revisions to surrounding
text.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module. labels Sep 1, 2020
targos
targos approved these changes Sep 1, 2020
View reviewed changes
benjamingr
benjamingr approved these changes Sep 1, 2020
View reviewed changes
@richardlau richardlau added dont-land-on-v12.x labels Sep 1, 2020
@richardlau

richardlau commented Sep 1, 2020

Copy link
Copy Markdown
Member

This depends on #34911 which depends on #33527 which is semver-major so adding dont-land labels.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
addaleax
addaleax approved these changes Sep 2, 2020
View reviewed changes
@Trott
Trott force-pushed the ac branch from e7878cc to fa4aeee Compare September 3, 2020 03:55
Trott added 2 commits September 3, 2020 05:29
@Trott
doc: revise AbortSignal text and example using events.once()
f9c362f 
Add a line to the example code to clarify what happens if an event is
emitted after listening is canceled. Make minor revisions to surrounding
text.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
doc: make AbortSignal text consistent in events.md
cc754f2 
Further minor modifications to AbortSignal text in events.md for
consistency.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@Trott
Trott force-pushed the ac branch from fa4aeee to cc754f2 Compare September 3, 2020 12:29
@Trott
Trott merged commit cc754f2 into nodejs:master Sep 3, 2020
@Trott

Trott commented Sep 3, 2020

Copy link
Copy Markdown
Member Author

Landed in 69b8a39...cc754f2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott deleted the ac branch September 3, 2020 12:29
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: revise AbortSignal text and example using events.once()
f97d015 
Add a line to the example code to clarify what happens if an event is
emitted after listening is canceled. Make minor revisions to surrounding
text.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
doc: make AbortSignal text consistent in events.md
c8341f7 
Further minor modifications to AbortSignal text in events.md for
consistency.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos added backport-open-v14.x and removed dont-land-on-v14.x labels Apr 24, 2021
@targos targos mentioned this pull request Apr 24, 2021
[v14.x] Backport AbortController and friends #38386
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@Trott @targos
doc: revise AbortSignal text and example using events.once()
affb52d 
Add a line to the example code to clarify what happens if an event is
emitted after listening is canceled. Make minor revisions to surrounding
text.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@Trott @targos
doc: make AbortSignal text consistent in events.md
561d832 
Further minor modifications to AbortSignal text in events.md for
consistency.

PR-URL: nodejs#35005
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@Trott @targos
doc: revise AbortSignal text and example using events.once()
1a362d8 
Add a line to the example code to clarify what happens if an event is
emitted after listening is canceled. Make minor revisions to surrounding
text.

PR-URL: #35005
Backport-PR-URL: #38386
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@Trott @targos
doc: make AbortSignal text consistent in events.md
e93615c 
Further minor modifications to AbortSignal text in events.md for
consistency.

PR-URL: #35005
Backport-PR-URL: #38386
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@targos targos added backported-to-v14.x and removed backport-open-v14.x labels Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@benjamingr benjamingr benjamingr approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. events Issues and PRs related to EventEmitter and the events module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Trott @richardlau @addaleax @benjamingr @targos @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.