GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update my email address by mhdawson · Pull Request #35121 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Sep 9, 2020

Copy link
Copy Markdown
Member

Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mhdawson
doc: update my email address
5577c23 
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Sep 9, 2020
targos
targos approved these changes Sep 9, 2020
View reviewed changes
gireeshpunathil
gireeshpunathil approved these changes Sep 9, 2020
View reviewed changes
Trott
Trott approved these changes Sep 9, 2020
View reviewed changes
richardlau
richardlau approved these changes Sep 9, 2020
View reviewed changes

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson If you're also planning to configure git to use your updated email address consider updating the .mailmap as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson

mhdawson commented Sep 9, 2020

Copy link
Copy Markdown
Member Author

@richardlau for commits I'm just going to use [email protected] so if anything I'll remove the ibm email once I no longer have access to it.
richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Sep 9, 2020

Copy link
Copy Markdown
Member

@richardlau for commits I'm just going to use [email protected] so if anything I'll remove the ibm email once I no longer have access to it.

I'd leave the entry in the mailmap so it continues to map your authorship of previous commits.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Sep 9, 2020

Copy link
Copy Markdown
Member Author

@richardlau, k will leave as is
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 10, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33130/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Sep 10, 2020
View reviewed changes
mhdawson added a commit that referenced this pull request Sep 11, 2020
@mhdawson
doc: update my email address
91272bc 
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@mhdawson

mhdawson commented Sep 11, 2020

Copy link
Copy Markdown
Member Author

Landed in 91272bc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Sep 11, 2020
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
@mhdawson @ruyadorno
doc: update my email address
f4e714a 
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
V14.12.0 proposal #35285
Merged
4 tasks done
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mhdawson @addaleax
doc: update my email address
f3f72fd 
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
v12.19.0 proposal #35401
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@mhdawson @joesepi
doc: update my email address
6d819bb 
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs#35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@mhdawson @richardlau @nodejs-github-bot @Trott @targos @gireeshpunathil @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.