GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — V14.12.0 proposal by ruyadorno · Pull Request #35285 · nodejs/node

Conversation

@ruyadorno

@ruyadorno ruyadorno commented Sep 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

2020-09-22, Version 14.12.0 (Current), @ruyadorno

Notable changes

  • deps:
    • update to uvwasi 0.0.11 (Colin Ihrig) #35104
  • n-api:
    • create N-API version 7 (Gabriel Schulhof) #35199
    • add more property defaults (Gerhard Stoebich) #35214

Commits

  • [5229ffadcf] - buffer: adjust validation to account for buffer.kMaxLength (Anna Henningsen) #35134
  • [3d78686987] - build: increase API requests for stale action (Phillip Johnsen) #35235
  • [f2cc1c22c1] - build: filter issues & PRs to auto close by matching on stalled label (Phillip Johnsen) #35159
  • [f3c45a1cef] - Revert "build: require "allow edits" to be checked" (Rich Trott) #35094
  • [1bb0ed3c6a] - crypto: improve invalid arg type message for randomInt() (Rich Trott) #35089
  • [3573545315] - crypto: improve randomInt out-of-range error message (Rich Trott) #35088
  • [d4389b59b4] - deps: update to uvwasi 0.0.11 (Colin Ihrig) #35104
  • [836680a4ea] - doc: use present tense in error messages (Rich Trott) #35164
  • [b860a7f61c] - doc: standardize on _backward_ (Rich Trott) #35243
  • [d82dd0c773] - doc: revise stability section of values doc (Rich Trott) #35242
  • [2bc335dcf6] - doc: clarify napi_property_attributes text (Rich Trott) #35253
  • [b62d9b47be] - doc: remove excessive formatting in dgram.md (Rich Trott) #35234
  • [b9161f408f] - doc: sort repl references in ASCII order (Rich Trott) #35230
  • [d195d20dbc] - doc: relax prohibition on personal pronouns (Rich Trott) #34353
  • [6119e9511c] - doc: clarify use of NAPI_EXPERIMENTAL (Michael Dawson) #35195
  • [6d4ab36175] - doc: update attributes used by n-api samples (doc: update attributes used by n-api samples #35220) (Gerhard Stoebich)
  • [7610fe500e] - doc: add issue labels sections to release guide (Michaël Zasso) #35224
  • [2308be06b3] - doc: fix header level for error code (Rich Trott) #35219
  • [64ac5c68aa] - doc: fix small grammatical issues in timers.md (Turner Jabbour) #35203
  • [92a14d3c72] - doc: add technical values document (Michael Dawson) #35145
  • [dbfd3b261d] - doc: remove "end user" (Rich Trott) #35200
  • [c1c93a6cde] - doc: use command-line/command line consistently (Rich Trott) #35198
  • [70ec369b76] - doc: replace "you should do X" with "do X" (Rich Trott) #35194
  • [e5fffe2f8f] - doc: fix missing word in dgram.md (Tom Atkinson) #35231
  • [c1e16d15dd] - doc: fix deprecation documentation inconsistencies (Antoine du HAMEL) #35082
  • [910deff2de] - doc: fix broken link in crypto.md (Rich Trott) #35181
  • [066148d229] - doc: remove problematic auto-linking of curl man pages (Rich Trott) #35174
  • [aea3f77c8d] - doc: update eventLoopUtilization documentation (Anna Henningsen) #35155
  • [32d1731ae1] - doc: update process.release (schamberg97) #35167
  • [176e9e4054] - doc: fix broken links in modules.md (Rich Trott) #35182
  • [dc4c5696da] - doc: add missing copyFile change history (Shelley Vohr) #35056
  • [e8d479ed67] - doc: perform cleanup on security-release-process.md (Rich Trott) #35154
  • [99785e48ea] - doc: fix minor punctuation issue in path.md (Amila Welihinda) #35127
  • [ae85228e54] - doc: perform minor cleanup on cli.md (Rich Trott) #35152
  • [e4105140e7] - doc: improve table accessibility (Rich Trott) #35146
  • [7dbcd24541] - doc: fix left nav color contrast (Rich Trott) #35141
  • [331142ca25] - doc: update contact info for Ash Cripps (Ash Cripps) #35139
  • [df70861863] - doc: simplify circular dependencies text in modules.md (Rich Trott) #35126
  • [f4e714aaf5] - doc: update my email address (Michael Dawson) #35121
  • [46b9f4b376] - doc: add missing changes entry for breakEvalOnSigint REPL option (Anna Henningsen) #35143
  • [122edad98b] - doc: update security process (Michael Dawson) #35107
  • [aa93c1c22d] - doc: fix broken link in perf_hooks.md (Rich Trott) #35113
  • [5c8d2083c5] - doc: fix broken link in http2.md (Rich Trott) #35112
  • [f4e958fc0c] - doc: fix broken link in fs.md (Rich Trott) #35111
  • [79c6d92e49] - doc: fix broken links in deprecations.md (Rich Trott) #35109
  • [93e4d545d8] - doc: add note about path.basename on Windows (Tobias Nießen) #35065
  • [0a2610a7aa] - doc: avoid double-while sentence in perf_hooks.md (Rich Trott) #35078
  • [1cf9934e4e] - doc: make minor improvements to module.md (Rich Trott) #35083
  • [fb89be63be] - doc: use correct Error type for EventEmitter.defaultMaxListener (Rich Trott) #35069
  • [b75822dd93] - doc,test: specify and test CLI option precedence rules (Anna Henningsen) #35106
  • [4bde865145] - errors: simplify ERR_REQUIRE_ESM message generation (Rich Trott) #35123
  • [6e622d6337] - esm: better package.json parser errors (Guy Bedford) #35117
  • [beb75bd031] - fs: loosen validation to allow objects with an own toString function (Jordan Harband) #34993
  • [8ea28536d0] - http: only set keep-alive when not exists ([email protected]) #35138
  • [977b0ed865] - http: allow Content-Length header for 304 responses (Arnaud Lefebvre) #34835
  • [d8b57140b4] - https: set requestTimeout default to 0 (Robert Nagy) #35264
  • [12f2934224] - meta: add links to OpenJSF Slack (Mary Marchini) #35128
  • [f21a5c6200] - meta: update my collab entry (devsnek) #35160
  • [76e24f9aa9] - module: use isURLInstance instead of instanceof (Antoine du HAMEL) #34951
  • [314483cd09] - module: fix specifier resolution option value (himself65) #35098
  • [ca1181615e] - (SEMVER-MINOR) n-api: create N-API version 7 (Gabriel Schulhof) #35199
  • [7f3b2b2a1f] - (SEMVER-MINOR) n-api: add more property defaults (Gerhard Stoebich) #35214
  • [4f4faa8e3c] - readline: fix key name for function keys with modifiers (DrunkenPoney) #35268
  • [e29e2daf4c] - test: improve assertions in pummel/test-timers (Rich Trott) #35216
  • [8357b56984] - test: add wasi readdir() test (Colin Ihrig) #35202
  • [49da459ce6] - test: improve pummel/test-timers.js (Rich Trott) #35175
  • [379c5cefd7] - test: revise test-policy-integrity (Rich Trott) #35101
  • [6627c1f8e4] - test: remove setMaxListeners in test-crypto-random (Tobias Nießen) #35079
  • [bc38485fb1] - test: fix comment about DNS lookup test (Tobias Nießen) #35080
  • [9faaa659b2] - test: separate the test fixtures between ICU and URL (Leko) #35077
  • [25f93f3ec3] - test: add more valid results to test-trace-atomics-wait (Anna Henningsen) #35066
  • [0a97f44b50] - tools: update ESLint to 7.9.0 (Colin Ihrig) #35170

cc @nodejs/releasers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji ljharb and bricss reacted with hooray emoji bricss reacted with heart emoji bricss and danielleadams reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🎉 2 reactions
  • ❤️ 1 reaction
  • 🚀 2 reactions
Trott and others added 30 commits September 17, 2020 10:36
@Trott @ruyadorno
doc: use correct Error type for EventEmitter.defaultMaxListener
fb89be6
If a bad value is assigned to EventEmitter.defaultMaxListener, a
RangeError is thrown and not a TypeError. Update documentation to
reflect this.

PR-URL: #35069
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@addaleax @ruyadorno
test: add more valid results to test-trace-atomics-wait
25f93f3
The two starting `Atomics.wait()` operations are not ordered,
but the test assumed a specific ordering because of the latency
that comes with spinning up a Worker thread.

Add variants of the existing potential valid results that account
for the reverse ordering.

Fixes: #35059

PR-URL: #35066
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott @ruyadorno
Revert "build: require "allow edits" to be checked"
f3c45a1
This reverts commit 07423b5.

Refs: #35002 (comment)

PR-URL: #35094
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Leko @ruyadorno
test: separate the test fixtures between ICU and URL
9faaa65
We need to emit dependency of ICU's toASCII in order to update the WPT
fixtures. Since ICU and URL isn't the same implementation and they also
follow different specifications. ICU's toASCII shouldn't have a
dependency on WPT fixtures.

Refs: #33770 (comment)
PR-URL: #35077
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@Trott @ruyadorno
doc: make minor improvements to module.md
1cf9934
* sort references in ASCII order
* replace abbreviation
* split comma splice into two sentences and add appropriate punctuation
* replace future tense with present tense

PR-URL: #35083
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
@tniessen @ruyadorno
test: fix comment about DNS lookup test
bc38485
PR-URL: #35080
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott @ruyadorno
crypto: improve randomInt out-of-range error message
3573545
Previously, the crypto.randomInt() message when "max" was less than or
equal to "min" made it sound like the lower bound for "max" was
hard-coded. Make it clear that it is instead dynamic based on the value
of "min".

For crypto.randomInt(10,0):

Before:
RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It
must be > 10. Received 0

After:

RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It
must be greater than the value of "min" (10). Received 0

PR-URL: #35088
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott @ruyadorno
crypto: improve invalid arg type message for randomInt()
1bb0ed3
Use "must be a safe integer" rather than "must be safe integer". I
believe the former is more easily understood/clear.

PR-URL: #35089
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@tniessen @ruyadorno
test: remove setMaxListeners in test-crypto-random
6627c1f
This appears to be a remnant from
413d38c.

PR-URL: #35079
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott @ruyadorno
doc: avoid double-while sentence in perf_hooks.md
0a2610a
This improves readability, as well as awkward reptition of the word
_while_ with two different meanings in a single sentence.

Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/w/while

PR-URL: #35078
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
@tniessen @ruyadorno
doc: add note about path.basename on Windows
93e4d54
PR-URL: #35065
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott @ruyadorno
test: revise test-policy-integrity
379c5ce
* eliminate unneeded Set deletion/cleanup
* use number of CPUs as limit for processes spawned rather than
  hard-coding the limit

PR-URL: #35101
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
@himself65 @ruyadorno
module: fix specifier resolution option value
314483c
Fixes: #35095

PR-URL: #35098
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott @ruyadorno
doc: fix broken links in deprecations.md
79c6d92
PR-URL: #35109
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott @ruyadorno
doc: fix broken link in fs.md
f4e958f
PR-URL: #35111
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott @ruyadorno
doc: fix broken link in http2.md
5c8d208
PR-URL: #35112
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott @ruyadorno
doc: fix broken link in perf_hooks.md
aa93c1c
PR-URL: #35113
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@addaleax @ruyadorno
doc,test: specify and test CLI option precedence rules
b75822d
Refs: #35098 (comment)

PR-URL: #35106
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@guybedford @ruyadorno
esm: better package.json parser errors
6e622d6
PR-URL: #35117
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@mhdawson @ruyadorno
doc: update security process
122edad
- update security process to reflect current way
  to request tweet/retweet of security release

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35107
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Ash Cripps <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@cjihrig @ruyadorno
deps: update to uvwasi 0.0.11
d4389b5
Notable changes:

- Several issues have been addressed in uvwasi_fd_readdir().
  A bug in the copying of the directory entry's name has been fixed.
  The function now returns UVWASI_ENOSYS on Windows and Android.
  Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.

PR-URL: #35104
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax @ruyadorno
doc: add missing changes entry for breakEvalOnSigint REPL option
46b9f4b
PR-URL: #35143
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@mhdawson @ruyadorno
doc: update my email address
f4e714a
Update email address to reflect move to
Red Hat

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #35121
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott @ruyadorno
errors: simplify ERR_REQUIRE_ESM message generation
4bde865
Because of the condition that starts the `if` block, we know that
`parentPath` must be truthy. So there is no need to check for that in
the template string that generates the error message.

PR-URL: #35123
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
@Trott @ruyadorno
doc: simplify circular dependencies text in modules.md
df70861
PR-URL: #35126
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BlackYoup @ruyadorno
http: allow Content-Length header for 304 responses
977b0ed
Fixes: #31037

PR-URL: #34835
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@devsnek @ruyadorno
meta: update my collab entry
f21a5c6
PR-URL: #35160
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@addaleax @ruyadorno
buffer: adjust validation to account for buffer.kMaxLength
5229ffa
PR-URL: #35134
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@atian25 @ruyadorno
http: only set keep-alive when not exists
8ea2853
PR-URL: #35138
Fixes: #34561
Reviewed-By: Ricky Zhou <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Ash Cripps @ruyadorno
doc: update contact info for Ash Cripps
331142c
PR-URL: #35139
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
addaleax
addaleax approved these changes Sep 21, 2020
View reviewed changes
Trott and others added 2 commits September 21, 2020 21:23
@Trott @ruyadorno
doc: use present tense in error messages
836680a
Error messages are a mix of present and past tense. They should be
mostly or entirely present tense. This eliminates the past tense
constructions "was found" and "were found".

Backport-PR-URL: #35247
PR-URL: #35164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno
2020-09-22, Version 14.12.0 (Current)
efd5c83
Notable changes:

- deps:
  - update to uvwasi 0.0.11 (Colin Ihrig)
  [#35104](#35104)
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
  [#35199](#35199)
  - add more property defaults (Gerhard Stoebich)
  [#35214](#35214)

PR-URL: #35285
@ruyadorno
ruyadorno force-pushed the v14.12.0-proposal branch from 5a94f69 to efd5c83 Compare September 22, 2020 01:28
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@lpinca

lpinca commented Sep 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Can #34015 or just 4b3654e be backported? See websockets/ws#1795.

cc: @benjamingr @jasnell

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Sep 22, 2020

Copy link
Copy Markdown
Member

@lpinca it's supposed to be in v14.5.0: #34093

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca

lpinca commented Sep 22, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@targos yes but the issue is on Node.js 12. Node.js 14 is ok. I wonder if the event target fixes will ever be backported to Node.js 12.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos

targos commented Sep 22, 2020

Copy link
Copy Markdown
Member

Ok, I understand what you're asking for, but this release proposal is for Node.js 14.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lpinca

lpinca commented Sep 22, 2020

Copy link
Copy Markdown
Member

Oh wow, sorry. I have not fully woken up yet.

targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95

aduh95 commented Sep 22, 2020

Copy link
Copy Markdown
Contributor

It would be great to have #35191 as it fixes a few broken links in the docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau
richardlau approved these changes Sep 22, 2020
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2020 •
edited by ruyadorno
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33191/
CIGTM: https://ci.nodejs.org/job/citgm-smoker/2476/
Release-ci: https://ci-release.nodejs.org/job/iojs+release/6338/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ruyadorno

ruyadorno commented Sep 22, 2020

Copy link
Copy Markdown
Member Author

hi @aduh95 sorry but I think it's a bit too late for that one to land in time for this release 😊

aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs
BethGriggs approved these changes Sep 22, 2020
View reviewed changes
MylesBorins
MylesBorins approved these changes Sep 22, 2020
View reviewed changes

@MylesBorins MylesBorins left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed CITGM and the new failures are unrelated to this release

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ruyadorno
ruyadorno merged commit efd5c83 into v14.x Sep 22, 2020
ruyadorno added a commit that referenced this pull request Sep 22, 2020
@ruyadorno
Working on v14.12.1
47063b5
PR-URL: #35285
ruyadorno added a commit that referenced this pull request Sep 22, 2020
@ruyadorno
2020-09-22, Version 14.12.0 (Current)
25d8456
Notable changes:

- deps:
  - update to uvwasi 0.0.11 (Colin Ihrig)
  [#35104](#35104)
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
  [#35199](#35199)
  - add more property defaults (Gerhard Stoebich)
  [#35214](#35214)

PR-URL: #35285
ruyadorno added a commit to ruyadorno/nodejs.org that referenced this pull request Sep 22, 2020
@ruyadorno
Blog: v14.12.0 release post
bfc056b
Refs: nodejs/node#35285
@ruyadorno ruyadorno mentioned this pull request Sep 22, 2020
Blog: v14.12.0 release post nodejs/nodejs.org#3393
Merged
@ruyadorno
ruyadorno deleted the v14.12.0-proposal branch September 22, 2020 18:27
MylesBorins pushed a commit to nodejs/nodejs.org that referenced this pull request Sep 22, 2020
@ruyadorno
Blog: v14.12.0 release post (#3393)
d609f97
Refs: nodejs/node#35285
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@ruyadorno @joesepi
2020-09-22, Version 14.12.0 (Current)
212b3bd
Notable changes:

- deps:
  - update to uvwasi 0.0.11 (Colin Ihrig)
  [nodejs#35104](nodejs#35104)
- n-api:
  - create N-API version 7 (Gabriel Schulhof)
  [nodejs#35199](nodejs#35199)
  - add more property defaults (Gerhard Stoebich)
  [nodejs#35214](nodejs#35214)

PR-URL: nodejs#35285
@targos targos added release Issues and PRs related to Node.js releases. and removed doc Issues and PRs related to Node.js documentation. meta Issues and PRs related to the general management of the project. wasi Issues and PRs related to the WebAssembly System Interface. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@richardlau richardlau richardlau approved these changes
@BethGriggs BethGriggs BethGriggs approved these changes
+1 more reviewer
@MylesBorins MylesBorins MylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@ruyadorno @nodejs-github-bot @lpinca @targos @aduh95 @MylesBorins @addaleax @richardlau @BethGriggs @Trott @Leko @tniessen @himself65 @guybedford @mhdawson @cjihrig @BlackYoup @devsnek @atian25 @mmarchini
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.