GeezerVison is showing github.com — V14.12.0 proposal by ruyadorno · Pull Request #35285 · nodejs/node
Conversation
ruyadorno
commented
Sep 21, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
2020-09-22, Version 14.12.0 (Current), @ruyadorno
Notable changes
- deps:
- update to uvwasi 0.0.11 (Colin Ihrig) #35104
- n-api:
- create N-API version 7 (Gabriel Schulhof) #35199
- add more property defaults (Gerhard Stoebich) #35214
Commits
cc @nodejs/releasers
Checklist
-
make -j4 test (UNIX), or vcbuild test (Windows) passes
- tests and/or benchmarks are included
- documentation is changed or added
- commit message follows commit guidelines
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
ljharb and bricss reacted with hooray emoji
bricss reacted with heart emoji
bricss and danielleadams reacted with rocket emoji
All reactions
-
👍
1 reaction
-
🎉
2 reactions
-
❤️
1 reaction
-
🚀
2 reactions
The two starting `Atomics.wait()` operations are not ordered,
but the test assumed a specific ordering because of the latency
that comes with spinning up a Worker thread.
Add variants of the existing potential valid results that account
for the reverse ordering.
Fixes: #35059
PR-URL: #35066
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
We need to emit dependency of ICU's toASCII in order to update the WPT
fixtures. Since ICU and URL isn't the same implementation and they also
follow different specifications. ICU's toASCII shouldn't have a
dependency on WPT fixtures.
Refs: #33770 (comment)
PR-URL: #35077
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
* sort references in ASCII order
* replace abbreviation
* split comma splice into two sentences and add appropriate punctuation
* replace future tense with present tense
PR-URL: #35083
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Previously, the crypto.randomInt() message when "max" was less than or
equal to "min" made it sound like the lower bound for "max" was
hard-coded. Make it clear that it is instead dynamic based on the value
of "min".
For crypto.randomInt(10,0):
Before:
RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It
must be > 10. Received 0
After:
RangeError [ERR_OUT_OF_RANGE]: The value of "max" is out of range. It
must be greater than the value of "min" (10). Received 0
PR-URL: #35088
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
* eliminate unneeded Set deletion/cleanup
* use number of CPUs as limit for processes spawned rather than
hard-coding the limit
PR-URL: #35101
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Notable changes:
- Several issues have been addressed in uvwasi_fd_readdir().
A bug in the copying of the directory entry's name has been fixed.
The function now returns UVWASI_ENOSYS on Windows and Android.
Serdes support has been added for uvwasi_dirent_t's.
- The libuv dependency has been updated to v1.39.0.
PR-URL: #35104
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Because of the condition that starts the `if` block, we know that
`parentPath` must be truthy. So there is no need to check for that in
the template string that generates the error message.
PR-URL: #35123
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
This comment has been minimized.
Error messages are a mix of present and past tense. They should be
mostly or entirely present tense. This eliminates the past tense
constructions "was found" and "were found".
Backport-PR-URL: #35247
PR-URL: #35164
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Notable changes:
- deps:
- update to uvwasi 0.0.11 (Colin Ihrig)
[#35104](#35104)
- n-api:
- create N-API version 7 (Gabriel Schulhof)
[#35199](#35199)
- add more property defaults (Gerhard Stoebich)
[#35214](#35214)
PR-URL: #35285
This comment has been minimized.
lpinca
commented
Sep 22, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
lpinca
commented
Sep 22, 2020
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@targos yes but the issue is on Node.js 12. Node.js 14 is ok. I wonder if the event target fixes will ever be backported to Node.js 12.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Ok, I understand what you're asking for, but this release proposal is for Node.js 14.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Oh wow, sorry. I have not fully woken up yet.
|
targos reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
It would be great to have #35191 as it fixes a few broken links in the docs.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
hi @aduh95 sorry but I think it's a bit too late for that one to land in time for this release 😊
|
aduh95 reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed CITGM and the new failures are unrelated to this release
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
targos
added
release
Issues and PRs related to Node.js releases.
and removed
doc
Issues and PRs related to Node.js documentation.
meta
Issues and PRs related to the general management of the project.
wasi
Issues and PRs related to the WebAssembly System Interface.
labels
Jun 6, 2021
Reviewers
addaleax
addaleax approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
release
Issues and PRs related to Node.js releases.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|