GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update process.release by schamberg97 · Pull Request #35167 · nodejs/node

Conversation

@schamberg97

@schamberg97 schamberg97 commented Sep 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Process.release doc is severely outdated. This PR includes info about LTS releases 10 and 12.

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. process Issues and PRs related to the process subsystem. labels Sep 12, 2020
richardlau
richardlau approved these changes Sep 12, 2020
View reviewed changes
mscdex
mscdex reviewed Sep 12, 2020
View reviewed changes
Comment thread doc/api/process.md Outdated

@mscdex mscdex Sep 12, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not going to maintain a list of all possible values, then I think we should change the preceding wording here from "Currently the valid values are:" to something like "Valid values may include:" to indicate that the following list is a subset. While "Argon" and others may no longer be supported they are still technically LTS release lines that someone could encounter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
schamberg97 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@schamberg97 schamberg97 Sep 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Valid values include the LTS Release Codenames (including those that are no longer supported). A non-exhaustive example of these codenames includes:" ?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@schamberg97 schamberg97 Sep 12, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the links to Release schedule and Changelogs on Github should also be included?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@addaleax addaleax Sep 12, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schamberg97 That sounds good, feel free to add those 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@schamberg97 schamberg97 Sep 12, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it, but I am away from computer until midgnight

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@addaleax addaleax Sep 12, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have a waiting period of 48 hours before we merge any non-trivial PR anyway, so take your time :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@schamberg97 schamberg97 Sep 14, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, had problems with my personal OSS project that was a bigger priority for me. This should probably be reviewed again, just in case

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gireeshpunathil
gireeshpunathil approved these changes Sep 12, 2020
View reviewed changes
addaleax
addaleax approved these changes Sep 12, 2020
View reviewed changes
@schamberg97
schamberg97 requested review from addaleax and mscdex September 14, 2020 14:44
Trott
Trott reviewed Sep 14, 2020
View reviewed changes
Comment thread doc/api/process.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Sep 14, 2020
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with or without the one suggestion I made.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott
Trott merged commit 571dff8 into nodejs:master Sep 14, 2020
@Trott

Trott commented Sep 14, 2020

Copy link
Copy Markdown
Member

Landed in 571dff8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Sep 14, 2020

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@schamberg97 @Trott
doc: update process.release
571dff8 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: #35167
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
@schamberg97 @ruyadorno
doc: update process.release
32d1731 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: #35167
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
V14.12.0 proposal #35285
Merged
4 tasks done
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@schamberg97 @addaleax
doc: update process.release
d94dac4 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: #35167
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Sep 28, 2020
v12.19.0 proposal #35401
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@schamberg97 @joesepi
doc: update process.release
d9edc24 
`process.release` documentation is out of date. This commit makes it up
to date.

PR-URL: nodejs#35167
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@panva panva mentioned this pull request Oct 25, 2022
doc: update process.release #45170
Closed
@wedataintelligence wedataintelligence mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities wedataintelligence/node#90
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 30, 2023
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#108
Open
@baby636 baby636 mentioned this pull request Dec 1, 2023
[Snyk] Fix for 1 vulnerabilities baby636/node#114
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2024
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#127
Open
@molllyn1 molllyn1 mentioned this pull request May 13, 2024
[Snyk] Fix for 2 vulnerabilities molllyn1/node#111
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2024
[Snyk] Fix for 2 vulnerabilities ron-a20/node#126
Open
@137717unity 137717unity mentioned this pull request May 14, 2024
[Snyk] Fix for 2 vulnerabilities 137717unity/node#128
Open
@baby636 baby636 mentioned this pull request May 14, 2024
[Snyk] Fix for 2 vulnerabilities baby636/node#149
Open
@wedataintelligence wedataintelligence mentioned this pull request May 14, 2024
[Snyk] Fix for 2 vulnerabilities wedataintelligence/node#111
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 15, 2024
[Snyk] Fix for 1 vulnerabilities aliceUnhinged613/node#129
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@richardlau richardlau richardlau approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes
@mscdex mscdex Awaiting requested review from mscdex
@addaleax addaleax Awaiting requested review from addaleax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@schamberg97 @Trott @mscdex @addaleax @richardlau @gireeshpunathil @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.