GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add wasi readdir() test by cjihrig · Pull Request #35202 · nodejs/node

Conversation

@cjihrig

@cjihrig cjihrig commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

This commit provides coverage for __wasi_fd_readdir().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@cjihrig
test: add wasi readdir() test
3f040fc 
This commit provides coverage for __wasi_fd_readdir().
@nodejs-github-bot

nodejs-github-bot commented Sep 15, 2020

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/wasi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Sep 15, 2020
devsnek
devsnek approved these changes Sep 15, 2020
View reviewed changes
addaleax
addaleax approved these changes Sep 15, 2020
View reviewed changes
@gengjiawen gengjiawen added the wasi Issues and PRs related to the WebAssembly System Interface. label Sep 16, 2020
gengjiawen
gengjiawen approved these changes Sep 16, 2020
View reviewed changes
@gengjiawen gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 16, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 16, 2020
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2020 •
edited by cjihrig
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33146/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig cjihrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 16, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 17, 2020
@github-actions

github-actions Bot commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

Landed in c314c04
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nodejs-github-bot pushed a commit that referenced this pull request Sep 17, 2020
@cjihrig @nodejs-github-bot
test: add wasi readdir() test
c314c04 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@github-actions github-actions Bot closed this Sep 17, 2020
@cjihrig
cjihrig deleted the readdir branch September 17, 2020 19:02
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
@cjihrig @ruyadorno
test: add wasi readdir() test
8357b56 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
V14.12.0 proposal #35285
Merged
4 tasks done
MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@cjihrig @MylesBorins
test: add wasi readdir() test
eb33501 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Nov 3, 2020
v12.20.0 proposal #35950
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@cjihrig @MylesBorins
test: add wasi readdir() test
c3e1bf7 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: #35202
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@cjihrig @joesepi
test: add wasi readdir() test
6fa7864 
This commit provides coverage for __wasi_fd_readdir().

PR-URL: nodejs#35202
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
+1 more reviewer
@devsnek devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure. wasi Issues and PRs related to the WebAssembly System Interface.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@cjihrig @nodejs-github-bot @addaleax @gengjiawen @devsnek
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.