GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — util: fix to inspect getters that access this by RaisinTen · Pull Request #36052 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Nov 9, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #36045

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji szmarczak reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Nov 9, 2020
aduh95
aduh95 reviewed Nov 9, 2020
View reviewed changes
Comment thread lib/internal/util/inspect.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen marked this pull request as ready for review November 9, 2020 18:03
@RaisinTen
RaisinTen force-pushed the fix-util-inspect-getter branch from b82514f to 45a5f4f Compare November 10, 2020 11:09
addaleax
addaleax approved these changes Nov 10, 2020
View reviewed changes
aduh95
aduh95 approved these changes Nov 10, 2020
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Nov 10, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 10, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
Trott
Trott approved these changes Nov 10, 2020
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34323/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen @Trott
util: fix to inspect getters that access this
929c51f 
Fixes: nodejs#36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: nodejs#36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@Trott
Trott force-pushed the fix-util-inspect-getter branch from 45a5f4f to 929c51f Compare November 12, 2020 13:40
@Trott

Trott commented Nov 12, 2020

Copy link
Copy Markdown
Member

Landed in 929c51f
szmarczak reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 929c51f into nodejs:master Nov 12, 2020
@RaisinTen
RaisinTen deleted the fix-util-inspect-getter branch November 12, 2020 13:44
@szmarczak

szmarczak commented Nov 12, 2020

Copy link
Copy Markdown
Contributor

Big thanks @RaisinTen 🎉
RaisinTen reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen

RaisinTen commented Nov 12, 2020

Copy link
Copy Markdown
Member Author

@szmarczak you're welcome. 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@RaisinTen @codebytere
util: fix to inspect getters that access this
4140f49 
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
v15.3.0 proposal #36232
Merged
BethGriggs pushed a commit that referenced this pull request Dec 9, 2020
@RaisinTen @BethGriggs
util: fix to inspect getters that access this
aa69d59 
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
@RaisinTen @BethGriggs
util: fix to inspect getters that access this
3517ced 
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
v14.15.2 proposal #36476
Merged
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
@RaisinTen @BethGriggs
util: fix to inspect getters that access this
dfb353b 
Fixes: #36045

Co-authored-by: Antoine du Hamel <[email protected]>

PR-URL: #36052
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jan 25, 2021
specific scenario causes infinite recursion in util.inspect (max stack size exceeded) #37054
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@addaleax addaleax addaleax approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

util.inspect fails to log getters which access this

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@RaisinTen @nodejs-github-bot @Trott @szmarczak @addaleax @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.