GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — events: disabled manual construction AbortSignal by RaisinTen · Pull Request #36094 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Nov 12, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #36064

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@RaisinTen
RaisinTen force-pushed the stop-manual-construction-AbortController branch 2 times, most recently from 61e66b6 to d6a9e3e Compare November 12, 2020 14:35
jasnell
jasnell approved these changes Nov 12, 2020
View reviewed changes
@RaisinTen
RaisinTen force-pushed the stop-manual-construction-AbortController branch 3 times, most recently from d353925 to 99dd10b Compare November 13, 2020 17:12
@RaisinTen
RaisinTen marked this pull request as ready for review November 13, 2020 18:19
benjamingr
benjamingr approved these changes Nov 13, 2020
View reviewed changes
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 13, 2020
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34384/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Nov 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34385/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 13, 2020
aduh95
aduh95 reviewed Nov 13, 2020
View reviewed changes
Comment thread lib/internal/abort_controller.js Outdated

@aduh95 aduh95 Nov 13, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this comment needed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Nov 14, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why is this comment needed?

It's because of this:

node/lib/.eslintrc.yaml

Lines 22 to 23 in c7d2a45

- selector: "NewExpression[callee.name=/Error$/]:not([callee.name=/^(AssertionError|NghttpError)$/])"
message: "Use an error exported by the internal/errors module."
.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen and himself65 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
Trott
Trott reviewed Nov 14, 2020
View reviewed changes
Comment thread lib/internal/abort_controller.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
events: disabled manual construction AbortSignal
ef80268 
Fixes: nodejs#36064
@RaisinTen
RaisinTen force-pushed the stop-manual-construction-AbortController branch from 99dd10b to ef80268 Compare November 14, 2020 05:22
lpinca
lpinca approved these changes Nov 14, 2020
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 14, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 14, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Nov 14, 2020 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34390/✅
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
himself65
himself65 approved these changes Nov 14, 2020
View reviewed changes
puzpuzpuz
puzpuzpuz approved these changes Nov 14, 2020
View reviewed changes
Trott
Trott approved these changes Nov 14, 2020
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 14, 2020
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 14, 2020
@github-actions

github-actions Bot commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

Landed in 1d02a35...22293ea
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Nov 14, 2020
nodejs-github-bot pushed a commit that referenced this pull request Nov 14, 2020
@RaisinTen @nodejs-github-bot
events: disabled manual construction AbortSignal
22293ea 
Fixes: #36064

PR-URL: #36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@RaisinTen
RaisinTen deleted the stop-manual-construction-AbortController branch November 14, 2020 14:53
codebytere pushed a commit that referenced this pull request Nov 22, 2020
@RaisinTen @codebytere
events: disabled manual construction AbortSignal
1550073 
Fixes: #36064

PR-URL: #36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@codebytere codebytere mentioned this pull request Nov 22, 2020
v15.3.0 proposal #36232
Merged
@targos targos added the backport-open-v14.x label Apr 24, 2021
@targos targos mentioned this pull request Apr 24, 2021
[v14.x] Backport AbortController and friends #38386
Closed
targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
0131586 
Fixes: nodejs#36064

PR-URL: nodejs#36094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2021
@RaisinTen @targos
events: disabled manual construction AbortSignal
64cd54b 
Fixes: #36064

PR-URL: #36094
Backport-PR-URL: #38386
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Zeyu Yang <[email protected]>
Reviewed-By: Andrey Pechkurov <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos added backported-to-v14.x events Issues and PRs related to EventEmitter and the events module. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-open-v14.x labels Apr 30, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@himself65 himself65 himself65 approved these changes
+1 more reviewer
@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

events Issues and PRs related to EventEmitter and the events module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

It should be impossible to construct an AbortSignal manually

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@RaisinTen @nodejs-github-bot @jasnell @Trott @benjamingr @lpinca @himself65 @aduh95 @puzpuzpuz @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.