GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8 backport for f19142e6 by guybedford · Pull Request #37864 · nodejs/node

Conversation

@guybedford

@guybedford guybedford commented Mar 22, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Original commit from https://chromium-review.googlesource.com/c/v8/v8/+/2757901:

[top-level-await] Implement the new post-order requirement for async subgraphs

This CL implements
https://github.com/tc39/proposal-top-level-await/pull/159, which reached
consensus at the March 2021 TC39.

The high-level intent is for parent modules that depend on async modules
to remember the DFS post-order such that when their async dependency
finishes, they execute in that original post-order. This aligns the
ordering between completely sync module graphs and async module graphs.

Bug: v8:11557
Change-Id: I5bd8f38f040115c255ca1ce8253b9686fdb4af03
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757901
Commit-Queue: Shu-yu Guo <[email protected]>
Reviewed-by: Camillo Bruni <[email protected]>
Reviewed-by: Adam Klein <[email protected]>
Cr-Commit-Position: refs/heads/master@{#73551}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@guybedford
deps: backport 9689b17687
4e7b156
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 22, 2021
@guybedford guybedford changed the title deps: V8 backport for 9689b17687 deps: V8 backport for f19142e6 Mar 22, 2021
@guybedford
guybedford requested a review from targos March 22, 2021 16:50
@targos

targos commented Mar 22, 2021

Copy link
Copy Markdown
Member

Please add Refs: https://github.com/v8/v8/commit/f19142e6139979da3a177cb0b9f382e459f5ccec to the commit message
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Mar 22, 2021

Copy link
Copy Markdown
Member

Note to whoever lands this: the embedder string should be incremented.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Mar 22, 2021
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2021 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36910/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3863/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Mar 23, 2021
View reviewed changes
@MylesBorins MylesBorins added the lts-watch-v14.x label Mar 23, 2021
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36945/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36978/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford

guybedford commented Mar 29, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 0c5f9bb.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@guybedford guybedford closed this Mar 29, 2021
guybedford added a commit that referenced this pull request Mar 29, 2021
@guybedford
deps: backport v8 f19142e6
8e46568 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@guybedford guybedford mentioned this pull request Mar 29, 2021
[v14.x] deps: V8 parent ordering fix backport #37973
Closed
@ruyadorno

ruyadorno commented Mar 30, 2021

Copy link
Copy Markdown
Member

Looks like this got modified after landing, updated commit in master is 8e46568
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno

ruyadorno commented Mar 30, 2021

Copy link
Copy Markdown
Member

This doesn't land cleanly in v15.x-staging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno added the backport-requested-v15.x label Mar 30, 2021
@guybedford

guybedford commented Mar 30, 2021

Copy link
Copy Markdown
Contributor Author

Backports are #37985 for 15 and #37973 for 14. Both required a little manual work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
guybedford added a commit to guybedford/node that referenced this pull request Mar 30, 2021
@guybedford
deps: backport v8 f19142e6
d68be4a 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 31, 2021
@guybedford @ruyadorno
deps: backport v8 f19142e6
f09c033 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Backport-PR-URL: #37985
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno ruyadorno added backported-to-v15.x and removed backport-requested-v15.x labels Mar 31, 2021
guybedford added a commit to guybedford/node that referenced this pull request Apr 8, 2021
@guybedford
deps: backport v8 f19142e6
04da72f 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
guybedford added a commit that referenced this pull request Apr 14, 2021
@guybedford
deps: backport v8 f19142e6
0c1e878 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Backport-PR-URL: #37973
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos added backported-to-v14.x and removed lts-watch-v14.x labels Apr 25, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
@legendecas legendecas mentioned this pull request Apr 7, 2022
[v14.x] deps: backport v8 367b0c1e #42637
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@guybedford @targos @nodejs-github-bot @ruyadorno @cjihrig @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.