GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v15.x] deps: V8 cycle fix & parent ordering backports by guybedford · Pull Request #37985 · nodejs/node

Conversation

@guybedford

@guybedford guybedford commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

This backports both #37865 and 8e46568 for v15.x.

//cc @ruyadorno

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@guybedford
deps: v8 backport 9689b17687b
abe04be 
[top-level-await] Implement spec fix for cycle root detection

Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0
PR-URL: nodejs#37865
Reviewed-By: Michaël Zasso <[email protected]>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v15.x v8 engine Issues and PRs related to the V8 dependency. labels Mar 30, 2021
@guybedford guybedford mentioned this pull request Mar 30, 2021
deps: V8 backport for f19142e6 #37864
Closed
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@guybedford
guybedford force-pushed the v8-cycle-fix-backport-15 branch from b2fb40e to e3e5b8b Compare March 30, 2021 12:20
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@guybedford
guybedford force-pushed the v8-cycle-fix-backport-15 branch from e3e5b8b to 1d53fe7 Compare March 30, 2021 15:35
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@guybedford
deps: backport v8 f19142e6
d68be4a 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: nodejs#37864
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@guybedford
guybedford force-pushed the v8-cycle-fix-backport-15 branch from 1d53fe7 to d68be4a Compare March 30, 2021 18:28
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37067/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno
ruyadorno approved these changes Mar 31, 2021
View reviewed changes
ruyadorno pushed a commit that referenced this pull request Mar 31, 2021
@guybedford @ruyadorno
deps: v8 backport 9689b17687b
2fd97ce 
[top-level-await] Implement spec fix for cycle root detection

Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0
PR-URL: #37865
Backport-PR-URL: #37985
Reviewed-By: Michaël Zasso <[email protected]>
ruyadorno pushed a commit that referenced this pull request Mar 31, 2021
@guybedford @ruyadorno
deps: backport v8 f19142e6
f09c033 
[top-level-await] Implement the new post-order requirement for
async subgraphs

Refs: v8/v8@f19142e
PR-URL: #37864
Backport-PR-URL: #37985
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno

ruyadorno commented Mar 31, 2021

Copy link
Copy Markdown
Member

Landed in 2fd97ce f09c033
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ruyadorno ruyadorno closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@guybedford @nodejs-github-bot @ruyadorno
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.