GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update `buffer.constants.MAX_LENGTH` by Ayase-252 · Pull Request #38109 · nodejs/node

Conversation

@Ayase-252

@Ayase-252 Ayase-252 commented Apr 6, 2021

Copy link
Copy Markdown
Member

This PR

  1. updates buffer.constants.MAX_LENGTH for different Node.js versions in 64-bit platform;
  2. adds a link to v8::TypedArray::kMaxLength as an informative note.

Fixes: #38093

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Ayase-252
doc: update buffer.constants.MAX_LENGTH
a7f61af 
Fixes: nodejs#38093
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. labels Apr 6, 2021
RaisinTen
RaisinTen reviewed Apr 6, 2021
View reviewed changes
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Ayase-252
fixup: doc: update buffer.constants.MAX_LENGTH
1471e99
aduh95
aduh95 reviewed Apr 6, 2021
View reviewed changes
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Ayase-252
fixup: doc: update buffer.constants.MAX_LENGTH
06fb565
RaisinTen
RaisinTen approved these changes Apr 7, 2021
View reviewed changes
@Ayase-252

Ayase-252 commented Apr 7, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@aduh95 I have documented changes in YAML headers. But I did not find a good way to incorprate the "initial" value 2 ** 31 - 1 into changes field, since it is not a change technically. Should I mention it in the main paragraph as the newest commit? Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added backport-requested-v14.x labels Apr 7, 2021
aduh95
aduh95 approved these changes Apr 7, 2021
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without my suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Ayase-252
fixup: doc: update buffer.constants.MAX_LENGTH
a2f9c9e
aduh95
aduh95 approved these changes Apr 8, 2021
View reviewed changes
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 8, 2021
@targos

targos commented Apr 11, 2021

Copy link
Copy Markdown
Member

@aduh95 added backport-requested-v14.x

Do you already know it won't land cleanly, or does it need to be adapted for the state of v14.x?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Apr 11, 2021

Copy link
Copy Markdown
Contributor

Do you already know it won't land cleanly, or does it need to be adapted for the state of v14.x?

@targos the value is different in v15.x and v14.x, I believe a manual backport is necessary to adjust the value on the v14.x branch. Maybe a dont-land label is more appropriate? In any case, this should not be backported as is.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Apr 12, 2021
View reviewed changes
jasnell pushed a commit that referenced this pull request Apr 12, 2021
@Ayase-252 @jasnell
doc: update buffer.constants.MAX_LENGTH
756d2e4 
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Apr 12, 2021

Copy link
Copy Markdown
Member

Landed in 756d2e4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 12, 2021
@Ayase-252
Ayase-252 deleted the fix/38093 branch April 13, 2021 14:26
@juanarbol juanarbol mentioned this pull request Apr 13, 2021
[v14.x backport] doc: update buffer.constants.MAX_LENGTH #38232
Closed
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@Ayase-252 @BethGriggs
doc: update buffer.constants.MAX_LENGTH
fa2b2b7 
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
2021-04-20, Version 16.0.0 (Current) #37678
Merged
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 20, 2021
@Ayase-252 @juanarbol
doc: update buffer.constants.MAX_LENGTH
c25d394 
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Backport-PR-URL: nodejs#38232
targos pushed a commit that referenced this pull request Apr 24, 2021
@Ayase-252 @targos
doc: update buffer.constants.MAX_LENGTH
9930b6b 
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Backport-PR-URL: #38232
@targos targos added backported-to-v14.x and removed backport-requested-v14.x author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Apr 25, 2021
@danielleadams danielleadams mentioned this pull request May 3, 2021
v14.17.0 proposal #38507
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

buffer: buffer.constants.MAX_LENGTH is larger than expected

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Ayase-252 @targos @aduh95 @jasnell @RaisinTen @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.