GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [v14.x backport] doc: update `buffer.constants.MAX_LENGTH` by juanarbol · Pull Request #38232 · nodejs/node

Conversation

@juanarbol

@juanarbol juanarbol commented Apr 13, 2021

Copy link
Copy Markdown
Member

Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen [email protected]
Reviewed-By: Antoine du Hamel [email protected]
Reviewed-By: James M Snell [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation. v14.x labels Apr 13, 2021
@juanarbol
juanarbol force-pushed the backport-38109-to-v14.x branch from 1cc8010 to 76f6c50 Compare April 13, 2021 19:38
aduh95
aduh95 reviewed Apr 13, 2021
View reviewed changes
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@juanarbol
juanarbol force-pushed the backport-38109-to-v14.x branch from 76f6c50 to 48db6a4 Compare April 13, 2021 23:43
aduh95
aduh95 previously approved these changes Apr 13, 2021
View reviewed changes
targos
targos reviewed Apr 14, 2021
View reviewed changes
Comment thread doc/api/buffer.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 dismissed their stale review April 20, 2021 13:31

Correct value is 2**32-1 on v14.x

@Ayase-252 @juanarbol
doc: update buffer.constants.MAX_LENGTH
c25d394 
Fixes: nodejs#38093

PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Backport-PR-URL: nodejs#38232
@juanarbol
juanarbol force-pushed the backport-38109-to-v14.x branch from 48db6a4 to c25d394 Compare April 20, 2021 16:39
aduh95
aduh95 approved these changes Apr 20, 2021
View reviewed changes
targos
targos approved these changes Apr 20, 2021
View reviewed changes
targos pushed a commit that referenced this pull request Apr 24, 2021
@Ayase-252 @targos
doc: update buffer.constants.MAX_LENGTH
9930b6b 
Fixes: #38093

PR-URL: #38109
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Backport-PR-URL: #38232
@targos

targos commented Apr 24, 2021

Copy link
Copy Markdown
Member

Landed in 9930b6b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos closed this Apr 24, 2021
@juanarbol
juanarbol deleted the backport-38109-to-v14.x branch August 26, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@juanarbol @targos @aduh95 @nodejs-github-bot @Ayase-252
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.