GeezerVison

Notes: I couldn't reproduce the original anymore, so I don't know how we can confirm this will actually work?

Good point. I'll see if I can spin up a vm and try to reproduce

Ok, updated with absolute path and set -e

test build of this created @ https://nodejs.org/download/test/v6.0.0-test201512088ac2af7628/ if anyone else wants to review the changes

I touched a bunch of TEST files under /usr/local/lib before running the installer and they still exist:

$ node -v
v6.0.0-test201512088ac2af7628
$ find /usr/local -name TEST
/usr/local/lib/node_modules/npm/node_modules/TEST
/usr/local/lib/node_modules/npm/TEST
/usr/local/lib/node_modules/TEST
/usr/local/lib/TEST

So something's not right with this as far as I can tell.

Perhaps it needs to be "preupgrade" as well as "preinstall". Reading here http://s.sudre.free.fr/Stuff/PackageMaker_Howto.html but I don't know how authoritative this is.

@rvagg Ok yes it looks like neither the preinstall, nor the postinstall scripts were running. What is weird to me is that the local.pkg installs npm, so there really is no need to have an npm.pkg. Even if one deselects the npm choice, npm will still be installed. I can make it a single package and then the scripts work properly. I guess my question becomes, is it worth it? With how outdated PackageMaker.app is, I really think that we should try to get #2571 landed. Is there anything blocking that?

@evanlucas I think the other issue mostly needs review.

Closing. Hopefully we can get the new OS X pkg stuff in soon. It should replace this anyways