GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: test `crypto.setEngine()` using an actual engine by RaisinTen · Pull Request #40481 · nodejs/node

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Oct 16, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Darshan Sen [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. needs-ci PRs that need a full CI run. labels Oct 16, 2021
@RaisinTen
RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch 8 times, most recently from b5b6031 to 06d723d Compare October 16, 2021 16:10
@RaisinTen

RaisinTen commented Oct 16, 2021

Copy link
Copy Markdown
Member Author

cc @nodejs/crypto @nodejs/build
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen commented Oct 16, 2021
View reviewed changes
Comment thread node.gyp Resolved

Uh oh!

There was an error while loading. Please reload this page.
tniessen
tniessen reviewed Oct 17, 2021
View reviewed changes
Comment thread test/fixtures/test_crypto_engine.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RaisinTen
RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch 3 times, most recently from 7f3bc48 to 6fb45e4 Compare October 17, 2021 14:13
@RaisinTen RaisinTen added the wip Issues and PRs that are still a work in progress. label Oct 17, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Oct 18, 2021
CI Reliability 2021-10-18 nodejs/reliability#90
Open
CI Reliability 2021-10-19 nodejs/reliability#91
Open
CI Reliability 2021-10-20 nodejs/reliability#92
Open
CI Reliability 2021-10-21 nodejs/reliability#93
Open
CI Reliability 2021-10-22 nodejs/reliability#94
Open
CI Reliability 2021-10-23 nodejs/reliability#95
Open
@RaisinTen
RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch from 6fb45e4 to b70b8a4 Compare October 23, 2021 14:29
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen
RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch 3 times, most recently from 5c70bd4 to fb5cead Compare October 23, 2021 14:41
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen removed wip Issues and PRs that are still a work in progress. needs-ci PRs that need a full CI run. labels Oct 24, 2021
@RaisinTen
test: test crypto.setEngine() using an actual engine
157eeca 
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen
RaisinTen force-pushed the test/test-crypto.setEngine()-using-an-actual-engine branch from 46699f9 to 157eeca Compare October 24, 2021 05:24
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40434/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 24, 2021
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Oct 25, 2021
CI Reliability 2021-10-25 nodejs/reliability#97
Open
24 tasks
@Mesteery Mesteery added the test Issues and PRs related to Node.js core tests and test infrastructure. label Oct 25, 2021
@RaisinTen RaisinTen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 25, 2021
@RaisinTen
RaisinTen requested a review from addaleax October 25, 2021 15:36
This was referenced Oct 26, 2021
CI Reliability 2021-10-26 nodejs/reliability#98
Open
CI Reliability 2021-10-27 nodejs/reliability#99
Open
CI Reliability 2021-10-28 nodejs/reliability#100
Open
@RaisinTen RaisinTen added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 30, 2021
@github-actions github-actions Bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 30, 2021
@github-actions

github-actions Bot commented Oct 30, 2021

Copy link
Copy Markdown
Contributor

Landed in babd73c...ff536fa
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot closed this Oct 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 30, 2021
@RaisinTen @nodejs-github-bot
test: test crypto.setEngine() using an actual engine
ff536fa 
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40481
Reviewed-By: James M Snell <[email protected]>
@RaisinTen
RaisinTen deleted the test/test-crypto.setEngine()-using-an-actual-engine branch October 30, 2021 08:59
targos pushed a commit that referenced this pull request Nov 6, 2021
@RaisinTen @targos
test: test crypto.setEngine() using an actual engine
179a5c5 
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40481
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
v17.1.0 release proposal #40758
Merged
@minrk minrk mentioned this pull request Nov 24, 2021
mac: deps/openssl compiled, even with --shared-openssl #40958
Closed
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@RaisinTen @BethGriggs
test: test crypto.setEngine() using an actual engine
f778fa2 
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #40481
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
v16.13.1 proposal #40974
Merged
1 task done
@asamuzaK asamuzaK mentioned this pull request Dec 3, 2021
Unify node.gyp code styling #41072
Closed
@richardlau richardlau mentioned this pull request Dec 15, 2021
deps: update to openssl-3.0.1+quic #41177
Closed
@mhdawson mhdawson mentioned this pull request Jan 21, 2022
Compile failure on 16.13.2 & 17.4.0 on RHEL8 #41633
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@tniessen tniessen Awaiting requested review from tniessen
@addaleax addaleax Awaiting requested review from addaleax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@RaisinTen @nodejs-github-bot @jasnell @tniessen @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.