GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v16.13.1 proposal by BethGriggs · Pull Request #40974 · nodejs/node

Conversation

BethGriggs commented Nov 26, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Finalize notable changes

2021-11-30, Version 16.13.1 'Gallium' (LTS), @BethGriggs

Notable Changes

[c14eb2325d] - deps: upgrade npm to 8.1.2 (npm team) #40643
[a901b6c53c] - deps: update c-ares to 1.18.1 (Richard Lau) #40660
- This release contains a c-ares update to fix a regression introduced in Node.js v16.6.2 resolving CNAME records containing underscores (#39780).
[755c08573f] - doc: add VoltrexMaster to collaborators (voltrexmaster) #40566
[881dd7ba2a] - lib: fix regular expression to detect `/` and `\` (Francesco Trotta) #40325

Commits

[996bc6e840] - benchmark: increase crypto DSA keygen params (Brian White) #40416
[27009092c8] - build: skip long-running Actions for README-only modifications (Rich Trott) #40571
[4581997ed0] - build: disable v8 pointer compression on 32bit archs (Cheng Zhao) #40418
[17433060d4] - build: fix actions pull request's branch (Mestery) #40494
[bfdd32fa62] - build: avoid run find inactive authors on forked repo (Jiawen Geng) #40465
[134e8afc59] - build: update codeowners-validator to 0.6 (FrankQiu) #40307
[de125a556c] - crypto: avoid double free (Michael Dawson) #40380
[c14eb2325d] - deps: upgrade npm to 8.1.2 (npm team) #40643
[a901b6c53c] - deps: update c-ares to 1.18.1 (Richard Lau) #40660
[76e2c3769e] - deps: upgrade npm to 8.1.1 (npm team) #40554
[91c3cf5d0a] - deps: V8: cherry-pick 422dc378a1da (Ray Wang) #40450
[769336ab8c] - deps: add riscv64 config into openssl gypi (Lu Yahan) #40473
[76d1b5d868] - deps: patch V8 to 9.4.146.24 (Michaël Zasso) #40616
[23d11a1dd9] - dgram: fix send with out of bounds offset + length (Nitzan Uziely) #40568
[45bdc77dc0] - doc: update cjs-module-lexer repo link (Guy Bedford) #40707
[de5c5c8509] - doc: remove --experimental-modules documentation (FrankQiu) #38974
[befac5ddd9] - doc: update tracking issues of startup performance (Joyee Cheung) #40629
[3cb74d72f8] - doc: fix markdown syntax and HTML tag misses (ryan) #40608
[eea061f8f1] - doc: use 'GitHub Actions workflow' instead (Mestery) #40586
[7a6e833677] - doc: add node: url scheme (Daniel Nalborczyk) #40573
[d72fb7df4a] - doc: call cwd function (Daniel Nalborczyk) #40573
[d732ff4614] - doc: remove unused imports (Daniel Nalborczyk) #40573
[e2114e21f4] - doc: add info on project's usage of coverity (Michael Dawson) #40506
[d38077babe] - doc: fix typo in changelogs (Luigi Pinca) #40585
[7c7f8791c6] - doc: update onboarding task (Rich Trott) #40570
[0a7c4ff248] - doc: simplify ccache instructions (Rich Trott) #40550
[5593dd1b25] - doc: fix macOS environment variables for ccache (Rich Trott) #40550
[2d4a042675] - doc: improve async_context introduction (Michaël Zasso) #40560
[9fcfef09ac] - doc: use GFM footnotes in webcrypto.md (Rich Trott) #40477
[579f01c0a3] - doc: describe buffer limit of v8.serialize (Ray Wang) #40243
[3b6cf090a0] - doc: use GFM footnotes in maintaining-V8.md (doc: use GFM footnotes in maintaining-V8.md #40476) (Rich Trott) #40476
[dea701004e] - doc: fix fs.symlink code example (Juan José Arboleda) #40414
[595117ff0b] - doc: explain backport labels (Stephen Belanger) #40520
[042f01e3ed] - doc: fix entry for Slack channel in onboarding.md (Rich Trott) #40563
[755c08573f] - doc: add VoltrexMaster to collaborators (voltrexmaster) #40566
[c029d0b61f] - doc: document considerations for inclusion in core (Rich Trott) #40338
[836fc274e4] - Revert "doc: fix typo in stream docs" (Luigi Pinca) #40819
[b3a12767a4] - doc: update link in onboarding doc (Rich Trott) #40539
[aa47c9f38f] - doc: clarify behavior of napi_extended_error_info (Michael Dawson) #40458
[bf88328bdc] - doc: add updating expected assets to release guide (Richard Lau) #40470
[621266afc7] - doc: format doc/api/*.md with markdown formatter (Rich Trott) #40403
[7b746381ce] - doc: specify that maxFreeSockets is per host (Luigi Pinca) #40483
[934dcc85c3] - doc: update Collaborator guide to reflect GitHub web UI update (Antoine du Hamel) #40456
[4724e07476] - doc: indicate n-api out params that may be NULL (Isaac Brodsky) #40371
[3b1499c971] - doc: update CHANGELOG.md for Node.js 16.13.0 (Richard Lau) #40617
[881dd7ba2a] - lib: fix regular expression to detect `/` and `\` (Francesco Trotta) #40325
[0a8c33123e] - lib,url: correct URL's argument to pass idlharness (Khaidi Chu) #39848
[480f0e1d20] - meta: use form schema for flaky test template (Michaël Zasso) #40737
[55ff97342d] - meta: update AUTHORS (Node.js GitHub Bot) #40668
[ef46cb428d] - meta: consolidate AUTHORS entries for brettkiefer (Rich Trott) #40599
[7230b6d33d] - meta: consolidate AUTHORS entries for alexzherdev (Rich Trott) #40620
[9e12ed4f68] - meta: consolidate AUTHORS entries for Azard (Rich Trott) #40619
[97aa8e42b8] - meta: move Fishrock123 to emeritus (Jeremiah Senkpiel) #40596
[7b1c89f357] - meta: consolidate AUTHORS entries for clakech (Rich Trott) #40589
[0003cb6b3b] - meta: consolidate AUTHORS entries for darai0512 (Rich Trott) #40569
[7590bacec1] - meta: update AUTHORS (Node.js GitHub Bot) #40580
[a5475df083] - meta: consolidate AUTHORS entries for dfabulich (Rich Trott) #40527
[c021a7f169] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #40464
[d64cf1706c] - meta: add Richard Lau to TSC list in README.md (Rich Trott) #40523
[d09b8239bf] - meta: consolidate AUTHORS entries for dguo (Rich Trott) #40517
[66192060e7] - meta: consolidate AUTHORS entries for cxreg (Rich Trott) #40490
[b4f51276cb] - meta: update AUTHORS (Node.js GitHub Bot) #40485
[2a2b549a28] - meta: consolidate AUTHORS entries for emanuelbuholzer (Rich Trott) #40469
[618bbbf2f4] - meta: consolidate AUTHORS entries for ebickle (Rich Trott) #40447
[06706e8dd2] - meta: add typings to label-pr-config (Mestery) #40401
[e2c9e1ccdd] - meta: consolidate AUTHORS entries for evantorrie (Rich Trott) #40430
[dab574e937] - policy: fix message for invalid manifest specifier (Rich Trott) #40574
[58de6cebb6] - process: refactor execution (Voltrex) #40664
[bc0eb0a3ea] - src: make LoadEnvironment with string work with builtin modules path (Michaël Zasso) #40607
[2c8a6ec28e] - src: remove usage of AllocatedBuffer from node_http2 (Darshan Sen) #40584
[59c26a2b2c] - src: fix #endif description in crypto_keygen.h (Tobias Nießen) #40639
[789fef1309] - src: throw error instead of assertion (Ray Wang) #40243
[7a8a6deee7] - src: register external references in os bindings (Joyee Cheung) #40239
[7bb3d43432] - src: register external references in crypto bindings (Joyee Cheung) #40239
[143c881ccb] - src: add missing inialization in agent.h (Michael Dawson) #40379
[c15afda79f] - src: get embedder options on-demand (Joyee Cheung) #40357
[ff3b7d228e] - src: ensure V8 initialized before marking milestone (Shelley Vohr) #40405
[774bc46327] - src,crypto: remove AllocatedBuffer from crypto_cipher.cc (Darshan Sen) #40400
[4030eff3d6] - src,fs: remove ToLocalChecked() call from fs::AfterMkdirp() (Darshan Sen) #40386
[3ac99a2417] - src,stream: remove *Check*() calls from non-Initialize() functions (Darshan Sen) #40425
[36d3b123a0] - stream: support array of streams in promises pipeline (Mestery) #40193
[01ffe0316c] - test: deflake child-process-pipe-dataflow (Luigi Pinca) #40838
[63b44fc429] - test: skip macos sandbox test with builtin modules path (Michaël Zasso) #40607
[3d50997ccb] - test: add semicolon after chunk size (Luigi Pinca) #40487
[f114e35115] - test: deflake http2-cancel-while-client-reading (Luigi Pinca) #40659
[f778fa230b] - test: test crypto.setEngine() using an actual engine (Darshan Sen) #40481
[b9533c592a] - test: use conventional argument order in assertion (Tobias Nießen) #40591
[e72c95c580] - test: fix test description (Luigi Pinca) #40486
[af4e682758] - test: pass URL's toascii.window.js WPT (Khaidi Chu) #39910
[6de88bc5ed] - test: adjust CLI flags test to ignore blank lines in doc (Rich Trott) #40403
[8226690097] - test: mark test-policy-integrity flaky on Windows (Rich Trott) #40684
[50c6666b37] - test: fix test-datetime-change-notify after daylight change (Piotr Rybak) #40684
[9227f2af79] - test: split test-crypto-dh.js (Joyee Cheung) #40451
[c593cff0af] - test,doc: correct documentation for runBenchmark() (Rich Trott) #40683
[aef809f5c8] - test,tools: increase pummel/benchmark test timeout from 4x to 6x (Rich Trott) #40684
[908f6447cd] - test,tools: increase timeout for benchmark tests (Rich Trott) #40684
[64c6575f44] - tools: simplify and fix commit queue (Michaël Zasso) #40742
[cba8eaf264] - tools: ensure the PR was not pushed before merging (Antoine du Hamel) #40747
[1c8590e1fe] - tools: update ESLint to 8.2.0 (Luigi Pinca) #40734
[18800dee0a] - tools: use GitHub Squash and Merge feature when using CQ (Antoine du Hamel) #40666
[48a785edb7] - tools: fix bug in prefer-primordials ESLint rule (Antoine du Hamel) #40628
[adde2a7a8c] - tools: add script to update c-ares (Richard Lau) #40660
[c12ce898e8] - tools: abort CQ session when landing several commits (Antoine du Hamel) #40577
[dd08e532a2] - tools: fix commit-lint workflow (Antoine du Hamel) #40673
[b4a80dba79] - tools: avoid fetch extra commits when validating commit messages (Antoine du Hamel) #39128
[2a53995442] - tools: update ESLint to 8.1.0 (Luigi Pinca) #40582
[8648e50183] - tools: fix formatting of warning message in update-authors.js (Rich Trott) #40600
[59de0f703f] - tools: udpate doc tools to accommodate GFM footnotes (Rich Trott) #40477
[abf3b84d77] - tools: add support for import assertions in linter (Antoine du Hamel) #39924
[04c2cbecb9] - tools: update tools/lint-md dependencies to support GFM footnotes (Rich Trott) #40445
[a9990876f7] - tools: update lint-md dependencies (Rich Trott) #40404
[f45814bad1] - tools,meta: remove exclusions from AUTHORS (Rich Trott) #40648
[7d550ad966] - tty: support more CI services in getColorDepth (Richie Bendall) #40385
[cdea5b671b] - typings: add more bindings typings (Mestery) #40415
[67c7d11f1a] - typings: add JSDoc typings for inspector (Voltrex) #38390
[fbe0323ebf] - typings: improve internal bindings typings (Mestery) #40411
[63ab0031c3] - typings: separate internalBinding typings (Mestery) #40409

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji

bricss reacted with hooray emoji

bricss reacted with heart emoji

bricss reacted with rocket emoji

All reactions

👍 1 reaction
🎉 1 reaction
❤️ 1 reaction
🚀 1 reaction

richardlau and others added 30 commits

October 26, 2021 15:31


          doc: update CHANGELOG.md for Node.js 16.13.0

3b1499c

Update missed changes for the main CHANGELOG.md for Node.js 16.13.0.

PR-URL: #40617
Refs: #40536
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          build: update codeowners-validator to 0.6

134e8af

PR-URL: #40307
Reviewed-By: Mary Marchini <[email protected]>


          tools: update lint-md dependencies

a999087

Update lint-md dependencies and re-create lint-md.mjs.

PR-URL: #40404
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          meta: consolidate AUTHORS entries for evantorrie

e2c9e1c

Add a .mailmap entry for evantorrie to consolidate their two AUTHORS
entries into one.

PR-URL: #40430
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>


          doc: indicate n-api out params that may be NULL

4724e07

This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879

PR-URL: #40371
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          meta: add typings to label-pr-config

06706e8

PR-URL: #40401
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>


          doc: update Collaborator guide to reflect GitHub web UI update

934dcc8

PR-URL: #40456
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          meta: consolidate AUTHORS entries for ebickle

618bbbf

PR-URL: #40447
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          src: ensure V8 initialized before marking milestone

ff3b7d2

PR-URL: #40405
Refs: electron/electron#31349
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>


          build: avoid run find inactive authors on forked repo

bfdd32f

PR-URL: #40465
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          src: get embedder options on-demand

c15afda

Only query embedder options when they are needed so that the bootstrap
remains as stateless as possible so that the bootstrap snapshot is
controlled solely by configure options, and subsequent runtime changes
should be done in pre-execution.

PR-URL: #40357
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>


          tools: update tools/lint-md dependencies to support GFM footnotes

04c2cbe

PR-URL: #40445
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          benchmark: increase crypto DSA keygen params

996bc6e

OpenSSL 3.0 increased the minimum values for these parameters.

PR-URL: #40416
Fixes: #40410
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>


          meta: consolidate AUTHORS entries for emanuelbuholzer

2a2b549

PR-URL: #40469
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          meta: update AUTHORS

b4f5127

PR-URL: #40485
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          build: fix actions pull request's branch

PR-URL: #40494
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          stream: support array of streams in promises pipeline

36d3b12

Fixes: #40191

PR-URL: #40193
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          src: add missing inialization in agent.h

143c881

This missing initialization was reported by the coverity scans
we are in the process of re-enabling.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #40379
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>


          test: split test-crypto-dh.js

9227f2a

Split test-crypto-dh.js so that it is less likely to timeout on
less powerful bots.

PR-URL: #40451
Refs: nodejs/reliability#86
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>


          doc: specify that maxFreeSockets is per host

7b74638

The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

PR-URL: #40483
Fixes: #40446
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          crypto: avoid double free

de125a5

Coverity scan reported a free after use and I think its
right. Tweak to avoid double free.

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #40380
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>


          test: fix test-datetime-change-notify after daylight change

50c6666

Add standard timezone name for Dublin without daylight saving

PR-URL: #40684
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>


          test,tools: increase timeout for benchmark tests

908f644

test-benchmark-buffer is consistently timing out on a single Windows
host in CI. Rather than try to figure out if we need to scale the
timeout up for a certain memory limit or chip speed or something else,
let's increase the timeout for benchmark tests in general.

PR-URL: #40684
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>


          test,tools: increase pummel/benchmark test timeout from 4x to 6x

aef809f

The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on
certain tests in pummel and (previously) benchmark. Increase timeout
from 4x to 6x.

PR-URL: #40684
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>


          test: mark test-policy-integrity flaky on Windows

Ref: #40694

PR-URL: #40684
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Voltrex <[email protected]>


          test: adjust CLI flags test to ignore blank lines in doc

6de88bc

PR-URL: #40403
Backport-PR-URL: #40530
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          doc: format doc/api/*.md with markdown formatter

621266a

PR-URL: #40403
Backport-PR-URL: #40530
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          tools: add support for import assertions in linter

abf3b84

PR-URL: #39924
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Bradley Farias <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>

Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>


          lib,url: correct URL's argument to pass idlharness

0a8c331

`url.idl` defines URL's constructor as:

```
constructor(USVString url, optional USVString base);
```

`idlharness.any.js` checks its length as `1`. So we should remove
constructor's second argument and use `arguments[1]` in constructor's
logic.

Refs: https://url.spec.whatwg.org/#idl-index

PR-URL: #39848
Backport-PR-URL: #40383
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          test: pass URL's toascii.window.js WPT

af4e682

PR-URL: #39910
Backport-PR-URL: #40383
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>

targos commented Nov 29, 2021

Copy link

Copy Markdown

Member

Are you still working on the notable changes?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Nov 29, 2021

Copy link

Copy Markdown

Member Author

Only starting to look at those now as CITGM triage is taking a while.

Initially plan to include #40643, #40660, and #40325 in notable changes. Other suggestions welcome though

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          test: deflake child-process-pipe-dataflow

01ffe03

Fixes: #25988

PR-URL: #40838
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Rich Trott <[email protected]>

BethGriggs added a commit that referenced this pull request

Nov 29, 2021


          2021-11-30, Version 16.13.1 'Gallium' (LTS)

5bd3d16

Notable changes:

doc:
  * add VoltrexMaster to collaborators (voltrexmaster) #40566

PR-URL: #40974

BethGriggs force-pushed the v16.13.1-proposal branch from f369577 to 5bd3d16 Compare

November 29, 2021 20:12

This comment has been minimized.

nodejs-github-bot commented Nov 30, 2021 •

edited by BethGriggs

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41235/ ✅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau commented Nov 30, 2021

Copy link

Copy Markdown

Member

Initially plan to include #40643, #40660, and #40325 in notable changes. Other suggestions welcome though

For #40660 feel free to borrow the notable changes from the v14.18.2 changelog (but adjusting 14.17.5 to 16.6.2 as the release where the regression was introduced).

BethGriggs reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs added a commit that referenced this pull request

Nov 30, 2021


          2021-11-30, Version 16.13.1 'Gallium' (LTS)

88cfa36

Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974

BethGriggs force-pushed the v16.13.1-proposal branch from 5bd3d16 to 88cfa36 Compare

November 30, 2021 19:15

richardlau approved these changes

Nov 30, 2021

View reviewed changes

BethGriggs commented Nov 30, 2021

Copy link

Copy Markdown

Member Author

New CI: https://ci.nodejs.org/job/node-test-commit/50292/ ✅
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4411/ ✅
New CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2805/
Release build on 88cfa36: https://ci-release.nodejs.org/job/iojs+release/8110

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Nov 30, 2021

Copy link

Copy Markdown

Member Author

A couple of new CITGM failures have appeared in the latest runs, as such I'd like to defer until tomorrow AM to investigate. I'll push an update changing only the date.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          2021-12-01, Version 16.13.1 'Gallium' (LTS)

12029ce

Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974

BethGriggs force-pushed the v16.13.1-proposal branch from 88cfa36 to 12029ce Compare

December 1, 2021 11:12

BethGriggs commented Dec 1, 2021

Copy link

Copy Markdown

Member Author

Diagnosed the new CITGM failures as issues in the modules (which are now fixed in new versions).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs commented Dec 1, 2021

Copy link

Copy Markdown

Member Author

Release build on 12029ce: https://ci-release.nodejs.org/job/iojs+release/8113

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BethGriggs merged commit 12029ce into v16.x

Dec 1, 2021

BethGriggs added a commit that referenced this pull request

Dec 1, 2021


          Working on v16.13.2

0370a26

PR-URL: #40974

BethGriggs added a commit that referenced this pull request

Dec 1, 2021


          2021-12-01, Version 16.13.1 'Gallium' (LTS)

6f74010

Notable changes:

- **deps**: upgrade npm to 8.1.2 (npm team)
  [#40643](#40643)
- **deps**: update c-ares to 1.18.1 (Richard Lau)
  [#40660](#40660)
- **doc**: add VoltrexMaster to collaborators (voltrexmaster)
  [#40566](#40566)
- **lib**: fix regular expression to detect \`/\` and \`\\\`
  (Francesco Trotta) [#40325](#40325)

PR-URL: #40974

BethGriggs deleted the v16.13.1-proposal branch

December 1, 2021 16:14

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request

Dec 1, 2021


          Blog: v16.13.1 release post

7d50f5b

Refs: nodejs/node#40974

BethGriggs mentioned this pull request

Dec 1, 2021

Blog: v16.13.1 release post nodejs/nodejs.org#4274

Merged

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request

Dec 1, 2021


          Blog: v16.13.1 release post (#4274)

ff3306d

Refs: nodejs/node#40974

This was referenced Dec 3, 2021

CI Reliability 2021-12-03 nodejs/reliability#133

Open

CI Reliability 2021-12-04 nodejs/reliability#134

Open

orgads commented Dec 29, 2021

Copy link

Copy Markdown

Contributor

There are some PRs labeled lts-watch-v16.x which have not yet been released on current. Please let me know if any of the following should be expedited into this release:

deps: upgrade npm to 8.1.3 deps: upgrade npm to 8.1.3 #40726

async_hooks: unmerge resource_symbol from owner_symbol async_hooks: unmerge resource_symbol from owner_symbol #40741

feat: expose async wrap providers under async_hooks module feat: expose async wrap providers under async_hooks module #40760

stream: allow calling callback before promise stream: allow calling callback before promise #40772

deps: V8: cherry-pick 7ae0b77628f6 deps: V8: cherry-pick 7ae0b77628f6 #40882

I just noticed it now. Too bad #40741 was not included. Can you backport it for next v16 release?

kirrg001, basti1302, and willianpc reacted with thumbs up emoji

All reactions

👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

richardlau

richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release

Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

19 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

BethGriggs commented Nov 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2021-11-30, Version 16.13.1 'Gallium' (LTS), @BethGriggs

Notable Changes

Commits

Uh oh!

targos commented Nov 29, 2021

Uh oh!

BethGriggs commented Nov 29, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Nov 30, 2021 • edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Nov 30, 2021

Uh oh!

BethGriggs commented Nov 30, 2021

Uh oh!

BethGriggs commented Nov 30, 2021

Uh oh!

BethGriggs commented Dec 1, 2021

Uh oh!

BethGriggs commented Dec 1, 2021

Uh oh!

orgads commented Dec 29, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

BethGriggs commented Nov 26, 2021 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Nov 30, 2021 •

edited by BethGriggs

Loading

Uh oh!

There was an error while loading. Please reload this page.