GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — update link in onboarding doc by Trott · Pull Request #40539 · nodejs/node

Conversation

@Trott

@Trott Trott commented Oct 21, 2021

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 21, 2021
@github-actions

github-actions Bot commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
VoltrexKeyva, richardlau, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 21, 2021
@Trott
Trott force-pushed the Trott-patch-1 branch from 0a83adb to f61c022 Compare October 21, 2021 02:02
@mscdex

mscdex commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

s/onbaording/onboarding/ in commit message
Trott reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott changed the title update link in onbaording doc update link in onboarding doc Oct 21, 2021
@Trott
Trott force-pushed the Trott-patch-1 branch from f61c022 to 52e3062 Compare October 21, 2021 03:57
J-Human
J-Human approved these changes Oct 21, 2021
View reviewed changes
benjamingr
benjamingr approved these changes Oct 21, 2021
View reviewed changes
richardlau
richardlau approved these changes Oct 21, 2021
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2021
@github-actions github-actions Bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 21, 2021
@github-actions

github-actions Bot commented Oct 21, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40539
✔  Done loading data for nodejs/node/pull/40539
----------------------------------- PR info ------------------------------------
Title      update link in onboarding doc (#40539)
Author     Rich Trott  (@Trott)
Branch     Trott:Trott-patch-1 -> nodejs:master
Labels     doc, fast-track
Commits    1
 - doc: update link in onboarding doc
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 21 Oct 2021 02:01:29 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40539#pullrequestreview-785423419
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785495130
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1367452046
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Oct 21, 2021
View reviewed changes
tniessen
tniessen approved these changes Oct 21, 2021
View reviewed changes
@Mesteery Mesteery added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 21, 2021
lpinca
lpinca approved these changes Oct 21, 2021
View reviewed changes
@Trott Trott added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 21, 2021
@github-actions github-actions Bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 21, 2021
@github-actions

github-actions Bot commented Oct 21, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40539
✔  Done loading data for nodejs/node/pull/40539
----------------------------------- PR info ------------------------------------
Title      update link in onboarding doc (#40539)
Author     Rich Trott  (@Trott)
Branch     Trott:Trott-patch-1 -> nodejs:master
Labels     doc, fast-track, author ready
Commits    1
 - doc: update link in onboarding doc
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40539
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 21 Oct 2021 02:01:29 GMT
   ✔  Approvals: 5
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/40539#pullrequestreview-785423419
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785495130
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785826483
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40539#pullrequestreview-785858072
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40539#pullrequestreview-786091650
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1369553323
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
doc: update link in onboarding doc
0d59d0d 
PR-URL: #40539
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Trott force-pushed the Trott-patch-1 branch 2 times, most recently from 7853180 to 0d59d0d Compare October 22, 2021 05:11
@Trott

Trott commented Oct 22, 2021

Copy link
Copy Markdown
Member Author

Landed in 0d59d0d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott
Trott merged commit 0d59d0d into master Oct 22, 2021
@Trott
Trott deleted the Trott-patch-1 branch October 22, 2021 05:12
targos pushed a commit that referenced this pull request Oct 23, 2021
@Trott @targos
doc: update link in onboarding doc
ed04827 
PR-URL: #40539
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
v17.1.0 release proposal #40758
Merged
BethGriggs pushed a commit that referenced this pull request Nov 23, 2021
@Trott @BethGriggs
doc: update link in onboarding doc
b3a1276 
PR-URL: #40539
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
v16.13.1 proposal #40974
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@J-Human J-Human J-Human approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@Trott @mscdex @benjamingr @lpinca @cjihrig @tniessen @richardlau @J-Human @nodejs-github-bot @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.