GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: abort CQ session when landing several commits by aduh95 · Pull Request #40577 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 23, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Most PRs are meant to be squashed in one commit when landing. If the
collaborator hasn't been using fixup! commits, the CQ will land the PR
as several commits. This change makes the CQ abort by default
when attempting to land several commits, unless there's another
label added to the PR to force squashing or landing as several commits.

Fixes: #40436
Blocked on nodejs/node-core-utils#572

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
tools: abort CQ session when landing several commits
fdd0ac9
Most PRs are meant to be squashed in one commit when landing. If the
collaborator hasn't been using `fixup!` commits, the CQ lands the PR
as several commits. This change makes the CQ abort by default
when attempting to land several commits, unless there's another
label added to the PR to force squashing or landing as several commits.

Fixes: nodejs#40436
Refs: nodejs/node-core-utils#572
@aduh95 aduh95 added the blocked PRs that are blocked by other issues or PRs. label Oct 23, 2021
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 23, 2021
Mesteery
Mesteery reviewed Oct 23, 2021
View reviewed changes
Comment thread doc/guides/commit-queue.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread tools/actions/commit-queue.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
fixup! tools: abort CQ session when landing several commits
6ded3d4
@aduh95 aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Oct 29, 2021
@aduh95
aduh95 requested review from mmarchini and targos October 29, 2021 08:05
@aduh95 aduh95 mentioned this pull request Oct 29, 2021
github commit queue feature nodejs/TSC#1110
Closed
aduh95 added a commit to nodejs/node-auto-test that referenced this pull request Oct 30, 2021
@aduh95
tools: abort CQ session when landing several commits
ce4b0ec
Most PRs are meant to be squashed in one commit when landing. If the
collaborator hasn't been using `fixup!` commits, the CQ lands the PR
as several commits. This change makes the CQ abort by default
when attempting to land several commits, unless there's another
label added to the PR to force squashing or landing as several commits.

Fixes: nodejs/node#40436
Refs: nodejs/node-core-utils#572

PR-URL: nodejs/node#40577
aduh95 added a commit to nodejs/node-auto-test that referenced this pull request Oct 30, 2021
@aduh95
tools: abort CQ session when landing several commits
cad7fb9
Most PRs are meant to be squashed in one commit when landing. If the
collaborator hasn't been using `fixup!` commits, the CQ lands the PR
as several commits. This change makes the CQ abort by default
when attempting to land several commits, unless there's another
label added to the PR to force squashing or landing as several commits.

Fixes: nodejs/node#40436
Refs: nodejs/node-core-utils#572

PR-URL: nodejs/node#40577
@aduh95 aduh95 mentioned this pull request Oct 30, 2021
tools: use GitHub Squash and Merge feature when using CQ #40666
Closed
targos
targos approved these changes Oct 31, 2021
View reviewed changes
Comment thread doc/guides/commit-queue.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
fixup! tools: abort CQ session when landing several commits
3c4672b
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 31, 2021
Trott
Trott approved these changes Nov 1, 2021
View reviewed changes
@aduh95
aduh95 merged commit 9bd6d52 into nodejs:master Nov 1, 2021
@aduh95

aduh95 commented Nov 1, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 9bd6d52

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95
aduh95 deleted the more-control-on-commit-queue branch November 1, 2021 20:03
@aduh95 aduh95 mentioned this pull request Nov 6, 2021
tools: only validate first commit message of a PR #40740
Merged
targos pushed a commit that referenced this pull request Nov 6, 2021
@aduh95 @targos
tools: abort CQ session when landing several commits
0787c78
Most PRs are meant to be squashed in one commit when landing. If the
collaborator hasn't been using `fixup!` commits, the CQ lands the PR
as several commits. This change makes the CQ abort by default
when attempting to land several commits, unless there's another
label added to the PR to force squashing or landing as several commits.

Fixes: #40436
Refs: nodejs/node-core-utils#572

PR-URL: #40577
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
v17.1.0 release proposal #40758
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@aduh95 @BethGriggs
tools: abort CQ session when landing several commits
c12ce89
Most PRs are meant to be squashed in one commit when landing. If the
collaborator hasn't been using `fixup!` commits, the CQ lands the PR
as several commits. This change makes the CQ abort by default
when attempting to land several commits, unless there's another
label added to the PR to force squashing or landing as several commits.

Fixes: #40436
Refs: nodejs/node-core-utils#572

PR-URL: #40577
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
v16.13.1 proposal #40974
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@mmarchini mmarchini Awaiting requested review from mmarchini
+2 more reviewers
@Mesteery Mesteery Mesteery left review comments
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Commit queue and unsquashed commits

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @Trott @targos @Mesteery @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.