GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix #endif description in crypto_keygen.h by tniessen · Pull Request #40639 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Oct 27, 2021

Copy link
Copy Markdown
Member

This should be the same as the condition at the beginning of the file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
src: fix #endif description in crypto_keygen.h
67d9e79
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Oct 27, 2021
@tniessen tniessen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 27, 2021
@github-actions

github-actions Bot commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.
richardlau, cjihrig, VoltrexKeyva, and jasnell reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bury9555
bury9555 approved these changes Oct 27, 2021
View reviewed changes
richardlau
richardlau approved these changes Oct 27, 2021
View reviewed changes
cjihrig
cjihrig approved these changes Oct 28, 2021
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Oct 28, 2021
View reviewed changes
@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Oct 28, 2021
jasnell
jasnell approved these changes Oct 28, 2021
View reviewed changes
@jasnell jasnell added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 28, 2021
@github-actions github-actions Bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 28, 2021
@github-actions

github-actions Bot commented Oct 28, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/40639
✔  Done loading data for nodejs/node/pull/40639
----------------------------------- PR info ------------------------------------
Title      src: fix #endif description in crypto_keygen.h (#40639)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:src-fix-endif-description-crypto-keygen -> nodejs:master
Labels     crypto, c++, fast-track
Commits    1
 - src: fix #endif description in crypto_keygen.h
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/40639
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Voltrex 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40639
Reviewed-By: Richard Lau 
Reviewed-By: Colin Ihrig 
Reviewed-By: Voltrex 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 27 Oct 2021 22:35:52 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40639#pullrequestreview-791257072
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40639#pullrequestreview-791286828
   ✔  - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40639#pullrequestreview-791314930
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40639#pullrequestreview-791939002
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub Actions successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1395031492
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva pushed a commit that referenced this pull request Oct 28, 2021
@tniessen @VoltrexKeyva
src: fix #endif description in crypto_keygen.h
f3125cf 
PR-URL: #40639
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@VoltrexKeyva

VoltrexKeyva commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

Landed in f3125cf
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@VoltrexKeyva VoltrexKeyva closed this Oct 28, 2021
targos pushed a commit that referenced this pull request Nov 6, 2021
@tniessen @targos
src: fix #endif description in crypto_keygen.h
7a22f91 
PR-URL: #40639
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 8, 2021
v17.1.0 release proposal #40758
Merged
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@tniessen @BethGriggs
src: fix #endif description in crypto_keygen.h
59c26a2 
PR-URL: #40639
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Voltrex <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
v16.13.1 proposal #40974
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@richardlau richardlau richardlau approved these changes
+2 more reviewers
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
@bury9555 bury9555 bury9555 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. crypto Issues and PRs related to the crypto subsystem. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tniessen @VoltrexKeyva @jasnell @cjihrig @richardlau @bury9555 @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.