GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: do not reference SSL when discussing SNI by tniessen · Pull Request #41549 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Jan 16, 2022

Copy link
Copy Markdown
Member

While some SSL implementation support SNI, it is really a TLS feature. Thus, do not reference the outdated SSL protocol in the context of SNI. (Modern TLS does heavily rely on SNI.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. tls Issues and PRs related to the tls subsystem. labels Jan 16, 2022
Trott
Trott reviewed Jan 16, 2022
View reviewed changes
Comment thread doc/api/tls.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Trott
Trott approved these changes Jan 16, 2022
View reviewed changes
@tniessen @Trott
doc: do not reference SSL when discussing SNI
d077eb0 
Co-authored-by: Rich Trott <[email protected]>
@tniessen
tniessen force-pushed the doc-sni-is-tls-not-ssl branch from 3bca329 to d077eb0 Compare January 16, 2022 13:53
@Trott Trott added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 16, 2022
@tniessen tniessen self-assigned this Jan 17, 2022
jasnell
jasnell approved these changes Jan 17, 2022
View reviewed changes
tniessen added a commit that referenced this pull request Jan 18, 2022
@tniessen @Trott
doc: do not reference SSL when discussing SNI
c4f5a49 
Co-authored-by: Rich Trott <[email protected]>
PR-URL: #41549
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@tniessen

tniessen commented Jan 18, 2022

Copy link
Copy Markdown
Member Author

Landed in c4f5a49, thanks for reviewing.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen closed this Jan 18, 2022
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@tniessen @Trott @BethGriggs
doc: do not reference SSL when discussing SNI
60e7437 
Co-authored-by: Rich Trott <[email protected]>
PR-URL: #41549
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@tniessen @Trott @danielleadams
doc: do not reference SSL when discussing SNI
8772d33 
Co-authored-by: Rich Trott <[email protected]>
PR-URL: #41549
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@Trott Trott Trott approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tniessen tniessen

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tniessen @jasnell @Trott @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.