GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v16.14.1 release proposal by danielleadams · Pull Request #42200 · nodejs/node

Conversation

danielleadams commented Mar 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

2022-03-15, Version 16.14.1 'Gallium' (LTS), @danielleadams

Notable changes

doc:
- add release key for Bryan English (Bryan English) #42102

Commits

[2a24e763d5] - async_hooks: fix imports in context example (Yash Ladha) #39229
[c4a296f59b] - benchmark: enable no-empty ESLint rule (Rich Trott) #41831
[abe2eb9fc0] - benchmark: avoid input param manipulation (Jithil P Ponnan) #41741
[2c566a9830] - benchmark: use Object.hasOwn() instead of hasOwnProperty() (Rich Trott) #41769
[b77e72ab12] - benchmark: replace hasOwnProperty() with Object.hasOwn() (Rich Trott) #41724
[ec72cb4019] - benchmark: remove unreachable code from crypto/hash-stream-creation (Rich Trott) #41535
[14bb6f97f0] - buffer: fix atob/btoa no-arg case (Benjamin Gruenbaum) #41478
[79e2ab2a67] - build: remove windows-2022 from v16.x actions (Danielle Adams) #42299
[2893b4c85a] - build: check if python is a executable program (himself65) #36696
[5e4fc04821] - build: enable zoslib installation on z/OS (alexcfyung) #41493
[1e3c9ebaae] - build: fix libuv builds for android aarch64 (Darshan Sen) #41555
[46f714f92a] - crypto: check return code from EVP_DigestUpdate (Michael Dawson) #41800
[33abbf9f21] - crypto: fix webcrypto.subtle signature (Antoine du Hamel) #41761
[faceae486b] - crypto: revise variables for const use instead of let (Rich Trott) #41614
[fe0f9dc611] - crypto: remove wildcard options for checkEmail (Tobias Nießen) #41599
[188c3ab918] - crypto: adjust types for getRandomValues (LiviaMedeiros) #41481
[1ef28f1a3d] - crypto: remove checkIP options argument (Tobias Nießen) #41571
[74c0464572] - deps: upgrade npm to 8.5.0 (npm-robot) #41925
[b5783288d1] - deps: upgrade npm to 8.4.1 (npm-robot) #41836
[2b7c4b4afe] - deps: upgrade npm to 8.3.2 (npm team) #41621
[906247933c] - dgram: remove unreachable connectState assign (Rongjian Zhang) #38590
[330c1bc518] - doc: add comments to empty blocks in worker_threads text (Rich Trott) #41831
[125ed0c6b0] - doc: remove empty block from console.timeEnd() example (Rich Trott) #41831
[34d6f8e793] - doc: use the same case as the section heading (Mestery) #41876
[fd28d252fa] - doc: use Oxford comma in crypto docs (Tobias Nießen) #41875
[bf99ef8b57] - doc: use sentence case in readme introduction (Mestery) #41874
[b15d9c2cc6] - doc: add missing space before hyphen (Mestery) #41873
[77685d5ab0] - doc: add stream pipelining note on Http usage (Rafael Silva) #41796
[c7bae97755] - doc: improve SSL_OP_PRIORITIZE_CHACHA description (Tobias Nießen) #41866
[5cd38a4ff5] - doc: add missing commas in cluster docs (Tobias Nießen) #41865
[cf6b5e0e33] - doc: add history information for Corepack (Antoine du Hamel) #41813
[c742a1cc4d] - doc: feature management proposal (Michael Dawson) #41420
[3f000a2627] - doc: add overhead hints for heap snapshot generation (Gerhard Stöbich) #41822
[42c0a8353e] - doc: fix X509 CA acronym capitalization (Tobias Nießen) #41841
[f5b0a3be12] - doc: use sentence case for X509 error codes header (Tobias Nießen) #41829
[20d8fd1a83] - doc: add initial version of maintaining-http.md (Michael Dawson) #41798
[077fcee008] - doc: add registry numbers for Electron 19 and 20 (Keeley Hammond) #41814
[44b6927179] - doc: add note about resource type in async_hooks (Tony Gorez) #41797
[1be701c9ca] - doc: use example.com for examples (Ateş Göral) #41827
[4660c1fa7b] - doc: align tls port types with net port types (Tobias Nießen) #41799
[5cd8bdc4d7] - doc: use UDPv4/UDPv6 consistently with TCPv4/TCPv6 (Tobias Nießen) #41824
[3ef05a0216] - doc: improve wording surrounding TLS 1.3 ciphers (Tobias Nießen) #41778
[51d955368e] - doc: add format-md step to release guide (Danielle Adams) #41809
[8f00e5dcf7] - doc: add v16 changelog link to iojs changelog (Danielle Adams) #41808
[4f194f3094] - doc: add security-steward rotation information (Michael Dawson) #41707
[14ea8fcba8] - doc: use Object.hasOwn() in util doc (Rich Trott) #41780
[9f77692491] - doc: remove section on "recent" ECDH changes (Tobias Nießen) #41773
[211a3c4c4c] - doc: clarify that import also uses main (Ben McCann) #41720
[20d9c4a2c5] - doc: update modules.md wording (Tobias Hernstig) #41728
[e209f53ba2] - doc: update Mesteery email (Mestery) #41683
[db1ce43173] - doc: avoid incomplete sentence in cluster docs (Tobias Nießen) #41701
[ee79e53821] - doc: fix typo in contributing guides (Yoshiki Kurihara) #41723
[9616fd5913] - doc: improve docs to give descriptive info for the platform property (Harshil jain) #41650
[4d8ee8e3cd] - doc: fix link to npm documentation (Antoine du Hamel) #41712
[018ec32535] - doc: clarify treatment of non-string base in URL() (Rich Trott) #41685
[92e6cf03fe] - doc: fix typo in technical-priorities.md (Akhil Marsonya) #41694
[071fef50e5] - doc: remove unadvisable cluster example (Tobias Nießen) #41668
[b63fb0ffb8] - doc: document flow for supporting type generation (Michael Dawson) #41464
[364811aa8a] - doc: clarify parameter for napi_get_cb_info (Michael Dawson) #41635
[1bd286e978] - doc: revise url.resolve() text (Rich Trott) #41661
[59f95fe4dc] - doc: clarify treatment of non-string argument to new URL() (Rich Trott) #41658
[3e93cc392e] - doc: fix documentation for MODULE_NOT_FOUND and ERR_MODULE_NOT_FOUND (Antoine du Hamel) #41645
[b9d1cb7f8a] - doc: improve TLS/SSL introduction (Tobias Nießen) #41649
[5d9c83e2e9] - doc: modernize and simplify cluster example (Tobias Nießen) #41626
[d5efecd64d] - doc: simplify readline/stdin text (Rich Trott) #41583
[931be52589] - doc: suggest worker threads in cluster docs (Tobias Nießen) #41616
[b2a4614a0d] - doc: add 16 and 17 to previous versions (Antoine du Hamel) #41646
[5f0a017a02] - doc: improve 'hex' Buffer decoding description and examples (Giora Guttsait) #41598
[0805068add] - doc: add note for handling signal events in trace events (Gabriel Trujillo) #41438
[0388b9afc3] - doc: demonstrate dangers of buffer.slice() (Shalvah) #41628
[3cdd1d634b] - doc: add missing word in cluster.workers details (Tobias Nießen) #41624
[5d94bc676e] - doc: fix async_hooks example in api docs (Akhil Marsonya) #41609
[39f52e1130] - doc: fix deprecated alias description in cluster (Tobias Nießen) #41618
[55714cc777] - doc: update timingSafeEqual error case (Alex Agranov) #41507
[9f8e442dc7] - doc: simplify util.TextDecoder example (Rich Trott) #41574
[57dc5956b1] - doc: move Mesteery to collaborators (Tobias Nießen) #41597
[10320c2965] - doc: fix cjs example code for process.arch (Job) #41593
[f33e831fe3] - doc: remove redunant await calls from stream docs (Giora Guttsait) #41592
[1cf74beb57] - doc: make contributing info more discoverable (Michael Dawson) #41408
[214cf17db9] - doc: recommend package exports instead of requiring folders (Antoine du Hamel) #41381
[5c387a0d75] - doc: edit async_context context loss text (Rich Trott) #41550
[01283f6b25] - doc: use sentence case for Web Crypto headers (Tobias Nießen) #41577
[6b6d0c4914] - doc: make Web Crypto example spec compliant (Tobias Nießen) #41556
[8772d332d7] - doc: do not reference SSL when discussing SNI (Tobias Nießen) #41549
[82042d0094] - doc: fix typos in esm.md (Yu) #41499
[ff0069dc3e] - doc: adjust assignment in condition in stream doc (Rich Trott) #41510
[1128b1c216] - doc: improve Web Crypto headings related to ECC (Tobias Nießen) #41542
[a6758d12e3] - doc: clarify module system selection (Antoine du Hamel) #41383
[db17a529a8] - doc: add release key for Bryan English (Bryan English) #42102
[f2ca172a08] - doc: remove statement about (EC)DHE performance (Tobias Nießen) #41528
[227dea8dc1] - domain: pass opts to EventEmitter.init (Chen Gang) #41414
[bd717064b0] - esm: improve validation of resolved URLs (Jacob Smith) #41446
[e747ef5e45] - http2: fix pseudo-headers order (ofir) #41735
[2efe9cbd01] - http2: fix no response event on continue request (ofirbarak) #41739
[7bf2be51b3] - http2: fix memory leak on nghttp2 hd threshold (Rafael Silva) #41502
[acd8768802] - lib: add comments to empty catch statements (Rich Trott) #41831
[c90bb7cd93] - lib: refactor to use validateObject() validator (Mohammed Keyvanzadeh) #41845
[c93a9af82b] - lib: refactor source map stack trace prepare (Mohammed Keyvanzadeh) #41698
[0f3287dc44] - lib: fix consistency of methods that emit warnings (Yoshiki Kurihara) #41249
[7ee3cdf60a] - lib: remove erroneous JSDoc entry (Rich Trott) #41604
[70f6554403] - meta: update AUTHORS (Node.js GitHub Bot) #41868
[a44a8ff767] - meta: update AUTHORS (Node.js GitHub Bot) #41763
[ba0ba7c4b2] - meta: update mailmap/AUTHORS info for existing collaborator (Rich Trott) #41750
[30e3327b46] - meta: adjust mailmap/AUTHORS to reflect README change (Rich Trott) #41751
[6d268fd32e] - meta: update AUTHORS (Node.js GitHub Bot) #41659
[18e6316bf1] - meta: update AUTHORS (Node.js GitHub Bot) #41548
[e1e059a698] - perf_hooks: remove useless calls in Histogram (Michael Dawson) #41579
[08b3bd2fc5] - policy: revise manifest.js to avoid empty blocks (Rich Trott) #41831
[33f3391a8f] - policy: check for null instead of falsy in loop (Rich Trott) #41614
[b8b8e0bce6] - policy: replace entries with keys (Mohammed Keyvanzadeh) #41482
[ee61bc74b7] - process: unhandledRejection support more errors (Benjamin Gruenbaum) #41682
[f066246729] - process: check for null instead of falsy in while loop (Rich Trott) #41614
[77cb604c0d] - process: use validateString validator (Mohammed Keyvanzadeh) #41595
[76281f9a81] - process: ignore asyncId 0 in exception handler (Anatoli Papirovski) #41424
[dacffd3e9c] - repl: check for precise values rather than falsy in loops (Rich Trott) #41614
[5e595683ce] - src: slightly simplify URLHost::ToString (Anna Henningsen) #41747
[206c370d03] - src: slightly simplify V8CoverageConnection::GetFilename (Anna Henningsen) #41748
[1cfc63ebe3] - src: fix typo in js_native_api_v8.cc (Caio Agiani) #41764
[aebd82ea7c] - stream: remove empty block (Rich Trott) #41831
[46ed078607] - stream: resume stream on drain (Robert Nagy) #41848
[363c760c85] - stream: check for null instead of falsy in loops (Rich Trott) #41614
[4f4fec4b22] - stream: rename unknown primordial (Mohammed Keyvanzadeh) #40622
[1425e75093] - stream: avoid function call where possible (Rich Trott) #41534
[ecb52636a4] - test: renew certificates for specific test (Luigi Pinca) #42342
[c8e59cbf9e] - test: enable no-empty ESLint rule (Rich Trott) #41831
[20ec77688f] - test: remove eslint-disable comments from fixtures (Rich Trott) #41859
[a8e41837cc] - test: remove test-worker-memory flaky designation (Rich Trott) #41867
[673c1fd5ae] - test: avoid using Object.prototype methods directly on objects (Rich Trott) #41801
[3690d3402d] - test: exclude ibm i tests until we resolve (Michael Dawson) #41812
[1f65620543] - test: make worker-take-heapsnapshot non-flaky (Michael Dawson) #41684
[badab79527] - test: mark test-fs-rmdir-recursive flaky on win (Michael Dawson) #41533
[951d299aee] - test: make fs watch test more stable (Benjamin Gruenbaum) #41715
[acea61ba8e] - test: fix typo in MessageChannel test (Tobias Nießen) #41746
[081989b6b7] - test: replace commented out expectations with tests (Darshan Sen) #41667
[639130e635] - test: use Object.hasOwn() where applicable (Rich Trott) #41664
[cb362a3748] - test: remove unneeded test statement (Rich Trott) #41663
[2b87f9784f] - test: remove error allowance in debugger test (Jithil P Ponnan) #41640
[55fce66af6] - test: simplify test-gc-http-client (Luigi Pinca) #41620
[b06c33b14b] - test: prepare tests for no-cond-assign ESLint rule (Rich Trott) #41614
[950648db48] - test: move test-gc-http-client-onerror to sequential (Luigi Pinca) #41619
[1d3ef115ca] - test: improve test coverage of internal/worker/io (Yoshiki Kurihara) #41511
[122eb51c98] - test: add DataView test entry for whatwg (Mohammed Keyvanzadeh) #40622
[2c813d825f] - test: improve util-format code coverage (Rich Trott) #41572
[fab831a3fe] - test: fix typo in test_js_native_api_v8 (Tobias Nießen) #41584
[9e7cfbbcd9] - test: add missing await in fs-rm/fs-rmdir tests (Benjamin Coe) #41545
[a8558ecfcf] - test: add coverage for util.inspect() (Rich Trott) #41527
[23fc205586] - test: avoid deep comparisons with literals (Tobias Nießen) #40634
[63a67f8dad] - timers: check for nullish instead of falsy in loops (Rich Trott) #41614
[788e77cb37] - tools: enable no-empty ESLint rule (Rich Trott) #41831
[10e6c70d14] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #41737
[20cdf78fd8] - tools: update doc to [email protected] (Node.js GitHub Bot) #41854
[2eabfdd066] - tools: update eslint to 8.8.0 (Node.js GitHub Bot) #41738
[9d23a27268] - tools: use Set instead of { [key]: true } object (Tobias Nießen) #41695
[7e4d455fe4] - tools: add compile_commands to ignore file (Yash Ladha) #41580
[1cbdc984fb] - tools: use Set instead of { [key]: true } object (Tobias Nießen) #41675
[dc854c4f38] - tools: fix typo in tools/code_cache/README.md (Tobias Nießen) #41657
[b17aa25f12] - tools: enable no-cond-assign-ESLint rule (Rich Trott) #41614
[9601b8ddd6] - tools: update lint-md-dependencies to [email protected] (Node.js GitHub Bot) #41638
[cdbe291e5b] - tools: increase maximum line length to 120 characters (Rich Trott) #41586
[7cbc472ed5] - tools: add missing .PHONY and .NOTPARALLEL targets in Makefile (Antoine du Hamel) #41515
[6fccd66b34] - tools: update lint-md-dependencies (Node.js GitHub Bot) #41440
[3163bd1ea0] - tools: bump eslint from 8.6.0 to 8.7.0 (Rich Trott) #41570
[e439f32a4b] - tools: update doc to [email protected] [email protected] (Node.js GitHub Bot) #41441
[66120564b2] - tools,test: enable no-prototype-builtins (Rich Trott) #41801
[4aee98b03c] - util: use hasOwnProperty() primordial (Rich Trott) #41692
[8218bab51d] - util: remove unused fast path in internal debuglog (Rich Trott) #41605
[a4ad26d4dc] - util: check for null instead of flasy in loop (Rich Trott) #41614

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

npm-robot and others added 22 commits

February 11, 2022 23:26


          deps: upgrade npm to 8.3.2

2b7c4b4

PR-URL: #41621
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>


          deps: upgrade npm to 8.4.1

b578328

PR-URL: #41836
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>


          deps: upgrade npm to 8.5.0

74c0464

PR-URL: #41925
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>


          test: avoid deep comparisons with literals

23fc205

Comparing any value to any non-RegExp literal or undefined using
strictEqual (or notStrictEqual) passes if and only if deepStrictEqual
(or notDeepStrictEqual, respectively) passes.

Unnecessarily using deep comparisons adds confusion.

This patch adds an ESLint rule that forbids the use of deepStrictEqual
and notDeepStrictEqual when the expected value (i.e., the second
argument) is a non-RegExp literal or undefined.

For reference, an ESTree literal is defined as follows.

    extend interface Literal <: Expression {
        type: "Literal";
        value: string | boolean | null | number | RegExp | bigint;
    }

The value `undefined` is an `Identifier` with `name: 'undefined'`.

PR-URL: #40634
Backport-PR-URL: #42021
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Voltrex <[email protected]>


          meta: update AUTHORS

18e6316

PR-URL: #41548
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>


          doc: remove statement about (EC)DHE performance

f2ca172

This statement is misleading in that it says "key generation is
expensive". ECDHE key generation (over the elliptic curves that are
commonly used for TLS) is insanely fast compared to most other types
of key generation.

This statement is irrelevant for TLS 1.3, which requires (EC)DHE.

Even if this statement is somewhat true for TLS 1.2, it does not
justify discouraging the use of (EC)DHE.

PR-URL: #41528
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>


          benchmark: remove unreachable code from crypto/hash-stream-creation

ec72cb4

`hash.digest('buffer')` has returned a Buffer and not a string since at
least Node.js 0.10.6. The benchmark, as it is written, will not work on
any version of Node.js prior to 16.x (due to `Object.hasOwn()`) and
certainly won't run on versions earlier than 0.10.6 due to const/let and
probably other things. Remove impossible-to-reach code intended to
accommodate Node.js earlier than 0.10.6.

PR-URL: #41535
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          stream: avoid function call where possible

1425e75

Instead of assigning a boolean, move the function call that assigns a
value to the boolean to the only place that boolean is checked. This
avoids the function call in cases where it is not needed.

Refs: #41488 (review)

PR-URL: #41534
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>


          test: add coverage for util.inspect()

a8558ec

Coverage stats indicate that there is no coverage for util.inspect()
with a negative number and a numeric separator. Add a test case.

Refs: https://coverage.nodejs.org/coverage-df507758e6c35534/lib/internal/util/inspect.js.html#L1463

PR-URL: #41527
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>


          doc: add release key for Bryan English

db17a52

Adds Bryan English and his public key to the README for releases.

PR-URL: #42102
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>


          doc: clarify module system selection

a6758d1

Refs: #41345 (comment)

PR-URL: #41383
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>


          tools: update doc to [email protected] [email protected]

e439f32

PR-URL: #41441
Reviewed-By: Rich Trott <[email protected]>


          doc: improve Web Crypto headings related to ECC

1128b1c

PR-URL: #41542
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>


          doc: adjust assignment in condition in stream doc

ff0069d

This is part of an effort to get our code to comply with ESLint
no-cond-assign so that we don't have to disable that rule in our config.

PR-URL: #41510
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>


          doc: fix typos in esm.md

82042d0

PR-URL: #41499
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Adrian Estrada <[email protected]>


          test: add missing await in fs-rm/fs-rmdir tests

9e7cfbb

Noticed that a few assertions were not being awaited, this could
potentially be leading to flakiness in tmp cleanup.

Refs: #41201

PR-URL: #41545
Refs: #41201
Reviewed-By: Ian Sutherland <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>


          policy: replace entries with keys

b8b8e0b

Replaced the entries with keys since the values of the entries are not
used, and changed loop style to avoid mangled `Symbol.iterator`s and
to keep consistency.

PR-URL: #41482
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          tools: bump eslint from 8.6.0 to 8.7.0

3163bd1

PR-URL: #41570
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>


          doc: do not reference SSL when discussing SNI

8772d33

Co-authored-by: Rich Trott <[email protected]>
PR-URL: #41549
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          doc: make Web Crypto example spec compliant

6b6d0c4

subtle.sign is not supposed to support strings, and in most Web Crypto
implementations, it does not. Passing a string as the 'data' argument
only works in Node.js, and users should not rely on that oddity. The
Web Crypto spec requires the data argument to be a BufferSource, i.e.,
an ArrayBuffer or an ArrayBufferView.

PR-URL: #41556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>


          tools: update lint-md-dependencies

6fccd66

Update to @rollup/[email protected], [email protected], and
[email protected].

PR-URL: #41440
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          doc: use sentence case for Web Crypto headers

01283f6

Refs: #33889

PR-URL: #41577
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Mestery <[email protected]>

nodejs-github-bot commented Mar 3, 2022

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/actions
@nodejs/gyp
@nodejs/tsc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

nodejs-github-bot commented Mar 15, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43048/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Mar 15, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43051/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This comment was marked as resolved.

richardlau commented Mar 15, 2022

Copy link

Copy Markdown

Member

Some certificate has expired, and it makes the tests fail:

#42342

aduh95 and danielleadams reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 commented Mar 15, 2022

Copy link

Copy Markdown

Contributor

I think we need to pull d4d0b09 in this release.

danielleadams reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca and others added 2 commits

March 15, 2022 17:12


          test: renew certificates for specific test

ecb5263

Renew the certificates used by
`test/parallel/test-https-selfsigned-no-keycertsign-no-crash.js` by
running the `https_renew_cert.sh` script under the same directory.

PR-URL: #42342
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>


          2022-03-15, Version 16.14.1 'Gallium' (LTS)

82c537f

Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102

PR-URL: #42200

danielleadams force-pushed the v16.14.1-proposal branch from e0b8cbd to 82c537f Compare

March 15, 2022 21:48

nodejs-github-bot commented Mar 15, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43059/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 approved these changes

Mar 15, 2022

View reviewed changes

nodejs-github-bot commented Mar 15, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43060/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Mar 16, 2022

CI Reliability 2022-03-16 nodejs/reliability#222

Open

29 tasks

nodejs-github-bot commented Mar 16, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43061/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

danielleadams merged commit 82c537f into v16.x

Mar 16, 2022

danielleadams added a commit that referenced this pull request

Mar 16, 2022


          Working on v16.14.2

e10e4fd

PR-URL: #42200

danielleadams added a commit that referenced this pull request

Mar 16, 2022


          2022-03-15, Version 16.14.1 'Gallium' (LTS)

4586ac4

Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) #42102

PR-URL: #42200

danielleadams added a commit to nodejs/nodejs.org that referenced this pull request

Mar 16, 2022


          Blog: v16.14.1 release post

26dc0d6

Refs: nodejs/node#42200

danielleadams mentioned this pull request

Mar 16, 2022

Blog: v16.14.1 release post nodejs/nodejs.org#4494

Merged

Trott pushed a commit to nodejs/nodejs.org that referenced this pull request

Mar 16, 2022


          Blog: v16.14.1 release post (#4494)

34b6a7a

Refs: nodejs/node#42200

danielleadams deleted the v16.14.1-proposal branch

March 16, 2022 03:21

Trott pushed a commit to nodejs/nodejs.org that referenced this pull request

Mar 16, 2022


          Blog: v16.14.1 release post (#4494)

7a48331

Refs: nodejs/node#42200

This was referenced Mar 17, 2022

CI Reliability 2022-03-17 nodejs/reliability#223

Open

CI Reliability 2022-03-18 nodejs/reliability#224

Open

CI Reliability 2022-03-19 nodejs/reliability#225

Open

CI Reliability 2022-03-20 nodejs/reliability#226

Open

CI Reliability 2022-03-21 nodejs/reliability#227

Open

gengjiawen mentioned this pull request

Apr 1, 2022

tracking issue: MSVC regression for 16.x and 14.x vs2022 #42560

Closed

xtx1130 pushed a commit to xtx1130/node that referenced this pull request

Apr 25, 2022


          2022-03-15, Version 16.14.1 'Gallium' (LTS)

80b7451

Notable changes:

* doc:
  * add release key for Bryan English (Bryan English) nodejs#42102

PR-URL: nodejs#42200

Reviewers

mcollina

mcollina approved these changes

tniessen

tniessen approved these changes

gengjiawen

gengjiawen approved these changes

aduh95

aduh95 approved these changes

RaisinTen

RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release

Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

danielleadams commented Mar 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2022-03-15, Version 16.14.1 'Gallium' (LTS), @danielleadams

Notable changes

Commits

Uh oh!

nodejs-github-bot commented Mar 3, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

This comment was marked as resolved.

richardlau commented Mar 15, 2022

Uh oh!

aduh95 commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 15, 2022

Uh oh!

nodejs-github-bot commented Mar 16, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

danielleadams commented Mar 3, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.