GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: bump eslint from 8.6.0 to 8.7.0 by Trott · Pull Request #41570 · nodejs/node

Conversation

@Trott

@Trott Trott commented Jan 17, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Trott
tools: bump eslint from 8.6.0 to 8.7.0
a3461c1
@Trott Trott added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 17, 2022
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 17, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 17, 2022
@github-actions

github-actions Bot commented Jan 17, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.
targos, Mesteery, and lpinca reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Jan 17, 2022
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 17, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
tniessen
tniessen approved these changes Jan 17, 2022
View reviewed changes
Mesteery
Mesteery approved these changes Jan 17, 2022
View reviewed changes
lpinca
lpinca approved these changes Jan 17, 2022
View reviewed changes
cjihrig
cjihrig approved these changes Jan 17, 2022
View reviewed changes

@cjihrig cjihrig left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but doesn't a bot usually handle this now?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott

Trott commented Jan 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

LGTM, but doesn't a bot usually handle this now?

Yes, usually, but the ESLint release came out later than they usually do and so the weekly bot run missed it. I supposed I could have dispatched the workflow manually, though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Jan 17, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41965/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Jan 17, 2022

Copy link
Copy Markdown
Member

Rubber-stamp LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Jan 18, 2022
CI Reliability 2022-01-18 nodejs/reliability#175
Open
16 tasks
VoltrexKeyva
VoltrexKeyva approved these changes Jan 18, 2022
View reviewed changes
@Trott Trott added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 18, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 18, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 6beee31 into nodejs:master Jan 18, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 18, 2022

Copy link
Copy Markdown
Collaborator

Landed in 6beee31
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jan 19, 2022
CI Reliability 2022-01-19 nodejs/reliability#176
Open
CI Reliability 2022-01-20 nodejs/reliability#177
Open
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@Trott @BethGriggs
tools: bump eslint from 8.6.0 to 8.7.0
127d2fa 
PR-URL: #41570
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@Trott @danielleadams
tools: bump eslint from 8.6.0 to 8.7.0
3163bd1 
PR-URL: #41570
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
@Trott
Trott deleted the eslint-8.7.0 branch September 25, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
+3 more reviewers
@targos targos targos approved these changes
@Mesteery Mesteery Mesteery approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@Trott @nodejs-github-bot @jasnell @lpinca @targos @cjihrig @tniessen @Mesteery @VoltrexKeyva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.