GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — doc: simplify readline/stdin text by Trott · Pull Request #41583 · nodejs/node Conversation
Mesteery
approved these changes
tniessen
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is removing the reference to the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes although it wasn't an easy decision. The choices were:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
addaleax
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM, although I'd also be good with removing this paragraph entirely, since it's not really related to readline per se and instead a general property of TTYs
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
BethGriggs
pushed a commit
that referenced
this pull request
PR-URL: #41583 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
PR-URL: #41583 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
PR-URL: #41583 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
PR-URL: #41583 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
PR-URL: #41583 Reviewed-By: Mestery <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers+1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |