GeezerVison

Copy link

Copy Markdown

Member

bricss and ExE-Boss reacted with thumbs up emoji

targos approved these changes Jan 19, 2022

View reviewed changes

Mesteery approved these changes Jan 19, 2022

View reviewed changes

mcollina approved these changes Jan 19, 2022

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell approved these changes Jan 19, 2022

View reviewed changes

BethGriggs approved these changes Jan 19, 2022

View reviewed changes

bnb approved these changes Jan 19, 2022

View reviewed changes

Trott deleted the max-len-120 branch January 21, 2022 15:29

PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>

PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>

PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>

PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>

PR-URL: #41586
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>

The previous deploy (1cf105f) failed its own postbuild verification on
Vercel — correctly. On Linux, nf3 nests version-conflicted deps as symlinks
*inside* store packages (google-auth-library/node_modules/gaxios and 21
friends), and fs.cpSync({ dereference: true }) only dereferences the
top-level path: nested links are recreated as links (nodejs/node#41586), so
the "materialized" tree still dangled. Windows never showed it because nf3's
junction layout keeps every link top-level, which is exactly why the local
verification passed while Vercel's failed.

The copy is now hand-rolled: copyReal() stats through symlinks at every
depth, so the output contains none regardless of layout. Verified in a clean
node:24 container from a tarball of this tree: npm ci + VERCEL=1 build exit
0, 19 links materialized, `find -type l` = 0, and the function artifact
serves / at 200 and /api/available-models at 200 in the same container.

Also makes the Sentry sourcemap upload non-fatal via errorHandler. The
plugin's default is to throw and kill the build on any upload failure — a
wrong org slug, an expired token, a Sentry outage. Observability must never
take down a deploy. Exercised in the same container with deliberately
invalid SENTRY_* values: three 401s from Sentry, three warnings in the log,
build exit 0, and zero .map files left in the output.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>