GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: remove redunant `await` calls from stream docs by gioragutt · Pull Request #41592 · nodejs/node

Conversation

@gioragutt

@gioragutt gioragutt commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. stream Issues and PRs related to Node.js streams. labels Jan 19, 2022
@gioragutt
doc: remove redunant await calls from stream docs
18d2714
@gioragutt
gioragutt force-pushed the giorag/fix-stream-docs branch from b0fabd6 to 18d2714 Compare January 19, 2022 11:58
benjamingr
benjamingr approved these changes Jan 19, 2022
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏 good catch

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gioragutt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@benjamingr benjamingr changed the title docs: remove redunant await calls from stream docs doc: remove redunant await calls from stream docs Jan 19, 2022
@benjamingr benjamingr added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 19, 2022
@github-actions

github-actions Bot commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.
benjamingr, gioragutt, Linkgoron, and Mesteery reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Linkgoron
Linkgoron approved these changes Jan 19, 2022
View reviewed changes
Mesteery
Mesteery approved these changes Jan 19, 2022
View reviewed changes
cjihrig
cjihrig approved these changes Jan 19, 2022
View reviewed changes
@benjamingr benjamingr added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 19, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 119519e into nodejs:master Jan 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 19, 2022

Copy link
Copy Markdown
Collaborator

Landed in 119519e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@gioragutt @BethGriggs
doc: remove redunant await calls from stream docs
2478b47 
PR-URL: #41592
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@gioragutt @danielleadams
doc: remove redunant await calls from stream docs
f7e1962 
PR-URL: #41592
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@gioragutt @danielleadams
doc: remove redunant await calls from stream docs
1db96c8 
PR-URL: #41592
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@gioragutt @danielleadams
doc: remove redunant await calls from stream docs
f33e831 
PR-URL: #41592
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Nitzan Uziely <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@cjihrig cjihrig cjihrig approved these changes
+2 more reviewers
@Linkgoron Linkgoron Linkgoron approved these changes
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@gioragutt @nodejs-github-bot @Linkgoron @benjamingr @cjihrig @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.