GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix cjs example code for process.arch by Manduro · Pull Request #41593 · nodejs/node

Conversation

@Manduro

@Manduro Manduro commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Manduro
doc: fix cjs example code for process.arch
31c64e7
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. process Issues and PRs related to the process subsystem. labels Jan 19, 2022
Mesteery
Mesteery approved these changes Jan 19, 2022
View reviewed changes
@Mesteery Mesteery added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 19, 2022
@github-actions

github-actions Bot commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Mesteery. Please 👍 to approve.

Ayase-252 and richardlau reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cjihrig
cjihrig approved these changes Jan 19, 2022
View reviewed changes
Ayase-252
Ayase-252 approved these changes Jan 19, 2022
View reviewed changes
@Ayase-252 Ayase-252 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Jan 19, 2022
VoltrexKeyva
VoltrexKeyva approved these changes Jan 19, 2022
View reviewed changes
richardlau
richardlau approved these changes Jan 19, 2022
View reviewed changes
tniessen
tniessen approved these changes Jan 19, 2022
View reviewed changes
@tniessen

tniessen commented Jan 19, 2022

Copy link
Copy Markdown
Member

Thank you @Manduro!

Manduro reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tniessen

tniessen commented Jan 19, 2022

Copy link
Copy Markdown
Member

Landed in d8f6b38, thank you!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tniessen tniessen closed this Jan 19, 2022
tniessen pushed a commit that referenced this pull request Jan 19, 2022
@Manduro @tniessen
doc: fix cjs example code for process.arch
d8f6b38
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@Manduro @BethGriggs
doc: fix cjs example code for process.arch
952623d
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@Manduro @danielleadams
doc: fix cjs example code for process.arch
17183d3
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Manduro @danielleadams
doc: fix cjs example code for process.arch
c3321ba
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Manduro @danielleadams
doc: fix cjs example code for process.arch
10320c2
PR-URL: #41593
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
@Ayase-252 Ayase-252 Ayase-252 approved these changes
+2 more reviewers
@Mesteery Mesteery Mesteery approved these changes
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@Manduro @tniessen @cjihrig @richardlau @Ayase-252 @Mesteery @VoltrexKeyva @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.