GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — process: use validateString validator by VoltrexKeyva · Pull Request #41595 · nodejs/node

Conversation

@VoltrexKeyva

@VoltrexKeyva VoltrexKeyva commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Use the validateString() validator where applicable.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jan 19, 2022
cjihrig
cjihrig approved these changes Jan 19, 2022
View reviewed changes
targos
targos approved these changes Jan 19, 2022
View reviewed changes
benjamingr
benjamingr approved these changes Jan 19, 2022
View reviewed changes
@VoltrexKeyva VoltrexKeyva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed needs-ci PRs that need a full CI run. labels Jan 19, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 19, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added needs-ci PRs that need a full CI run. and removed author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Jan 19, 2022
aduh95
aduh95 requested changes Jan 19, 2022
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to validate that err is an object (or if it's undefined, we need to override it with new ERR_SYNTHETIC).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
VoltrexKeyva reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@VoltrexKeyva

This comment has been minimized.

Sign in to view
@VoltrexKeyva
process: use validateString validator
15dc69c 
Use the `validateString()` validator where applicable.
@VoltrexKeyva
VoltrexKeyva force-pushed the use-validate-string branch from a132c6d to 15dc69c Compare January 19, 2022 17:21
aduh95
aduh95 approved these changes Jan 19, 2022
View reviewed changes
@VoltrexKeyva

VoltrexKeyva commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

@aduh95 Added the changes to do that in the new commit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 19, 2022
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 19, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 19, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42030/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mesteery
Mesteery approved these changes Jan 19, 2022
View reviewed changes
lpinca
lpinca approved these changes Jan 19, 2022
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Jan 20, 2022
CI Reliability 2022-01-20 nodejs/reliability#177
Open
17 tasks
@VoltrexKeyva VoltrexKeyva removed the needs-ci PRs that need a full CI run. label Jan 20, 2022
@github-actions github-actions Bot mentioned this pull request Jan 21, 2022
CI Reliability 2022-01-21 nodejs/reliability#178
Open
19 tasks
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 21, 2022
@nodejs-github-bot
nodejs-github-bot merged commit 8275683 into nodejs:master Jan 21, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 21, 2022

Copy link
Copy Markdown
Collaborator

Landed in 8275683
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@VoltrexKeyva @BethGriggs
process: use validateString validator
3b45c05 
Use the `validateString()` validator where applicable.

PR-URL: #41595
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@VoltrexKeyva @danielleadams
process: use validateString validator
87dcd93 
Use the `validateString()` validator where applicable.

PR-URL: #41595
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@VoltrexKeyva @danielleadams
process: use validateString validator
64558ff 
Use the `validateString()` validator where applicable.

PR-URL: #41595
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@VoltrexKeyva @danielleadams
process: use validateString validator
687fbf1 
Use the `validateString()` validator where applicable.

PR-URL: #41595
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@VoltrexKeyva @danielleadams
process: use validateString validator
77cb604 
Use the `validateString()` validator where applicable.

PR-URL: #41595
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@VoltrexKeyva
VoltrexKeyva deleted the use-validate-string branch April 24, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
+2 more reviewers
@targos targos targos approved these changes
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@VoltrexKeyva @nodejs-github-bot @benjamingr @lpinca @targos @cjihrig @aduh95 @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.