GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix typo in MessageChannel test by tniessen · Pull Request #41746 · nodejs/node

Conversation

@tniessen

@tniessen tniessen commented Jan 29, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tniessen
test: fix typo in MessageChannel test
1a541f0
@tniessen tniessen added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Jan 29, 2022
@github-actions

github-actions Bot commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.
targos, Mesteery, aduh95, and benjamingr reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jan 29, 2022
targos
targos approved these changes Jan 29, 2022
View reviewed changes
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Jan 29, 2022
Mesteery
Mesteery approved these changes Jan 29, 2022
View reviewed changes
aduh95
aduh95 approved these changes Jan 29, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Jan 29, 2022
@aduh95

aduh95 commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Changes that only affect a comment do not affect the node binary and therefore do not need a full CI to land.

node/doc/contributing/collaborator-guide.md

Lines 208 to 210 in a199387

A passing (green) GitHub Actions CI result is required. A passing (green or
yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull
request contains changes that will affect the `node` binary. This is because

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Jan 29, 2022
View reviewed changes
@benjamingr benjamingr added the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Jan 29, 2022
@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/41746
✔  Done loading data for nodejs/node/pull/41746
----------------------------------- PR info ------------------------------------
Title      test: fix typo in MessageChannel test (#41746)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:test-typo-msgchannel -> nodejs:master
Labels     test, fast-track, author ready
Commits    1
 - test: fix typo in MessageChannel test
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/41746
Reviewed-By: Michaël Zasso 
Reviewed-By: Mestery 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Benjamin Gruenbaum 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41746
Reviewed-By: Michaël Zasso 
Reviewed-By: Mestery 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Benjamin Gruenbaum 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 29 Jan 2022 12:22:00 GMT
   ✔  Approvals: 4
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955342
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955586
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955713
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41746#pullrequestreview-866963791
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1765967304
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Jan 29, 2022
@benjamingr

benjamingr commented Jan 29, 2022

Copy link
Copy Markdown
Member

Ah apparently commit queue doesn’t work for changes that don’t require Jenkins CI?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Jan 29, 2022
View reviewed changes
@tniessen tniessen removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Jan 29, 2022
@tniessen

tniessen commented Jan 29, 2022

Copy link
Copy Markdown
Member Author

Ah apparently commit queue doesn’t work for changes that don’t require Jenkins CI?

I believe it should, but this PR was marked as needs-ci by the bot so the commit queue might have the same understanding.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 74de555 into nodejs:master Jan 29, 2022
@aduh95

aduh95 commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Landed in 74de555.

Ah apparently commit queue doesn’t work for changes that don’t require Jenkins CI?

I believe it should, but this PR was marked as needs-ci by the bot so the commit queue might have the same understanding.

Yes, it's unfortunate but the CQ was built to be extra cautious and is not actually able to differentiate a change in a comment than a change in the code. Landing manually is required there.
benjamingr reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen @ruyadorno
test: fix typo in MessageChannel test
abbc06b 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
v17.5.0 release proposal #41897
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
test: fix typo in MessageChannel test
f002d37 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
v16.14.1 release proposal #42200
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
test: fix typo in MessageChannel test
9692e3d 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
test: fix typo in MessageChannel test
acea61b 
PR-URL: #41746
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+2 more reviewers
@targos targos targos approved these changes
@Mesteery Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@tniessen @aduh95 @nodejs-github-bot @benjamingr @targos @RaisinTen @Mesteery
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.