GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: fix typo in js_native_api_v8.cc by caioagiani · Pull Request #41764 · nodejs/node

Conversation

caioagiani commented Jan 30, 2022

Copy link

Copy Markdown

Contributor

src/js_native_api_v8.cc NAPI_AUTO_LENGHTH → NAPI_AUTO_LENGTH

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and caioagiani reacted with thumbs up emoji

All reactions

👍 2 reactions


          src: fix typo in js_native_api_v8.cc

a25d0fa

nodejs-github-bot commented Jan 30, 2022

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/node-api

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci PRs that need a full CI run. labels

Jan 30, 2022

Mesteery approved these changes

Jan 30, 2022

View reviewed changes

addaleax approved these changes

Jan 30, 2022

View reviewed changes

addaleax added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed needs-ci PRs that need a full CI run. labels

Jan 30, 2022

RaisinTen approved these changes

Jan 30, 2022

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jan 30, 2022

This comment has been minimized.

richardlau approved these changes

Jan 30, 2022

View reviewed changes

tniessen approved these changes

Jan 30, 2022

View reviewed changes

nodejs-github-bot commented Jan 30, 2022

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42247/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cjihrig approved these changes

Jan 30, 2022

View reviewed changes

VoltrexKeyva approved these changes

Jan 30, 2022

View reviewed changes

github-actions Bot mentioned this pull request

Jan 31, 2022

CI Reliability 2022-01-31 nodejs/reliability#188

Open

28 tasks

lpinca approved these changes

Jan 31, 2022

View reviewed changes

Mesteery added the commit-queue PRs queued for automated landing through the Commit Queue. label

Jan 31, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Jan 31, 2022

nodejs-github-bot commented Jan 31, 2022

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/41764
✔  Done loading data for nodejs/node/pull/41764
----------------------------------- PR info ------------------------------------
Title      src: fix typo in js_native_api_v8.cc (#41764)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     caioagiani:patch-1 -> nodejs:master
Labels     c++
Commits    1
 - src: fix typo in js_native_api_v8.cc
Committers 1
 - caioagiani 
PR-URL: https://github.com/nodejs/node/pull/41764
Reviewed-By: Mestery 
Reviewed-By: Anna Henningsen 
Reviewed-By: Darshan Sen 
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41764
Reviewed-By: Mestery 
Reviewed-By: Anna Henningsen 
Reviewed-By: Darshan Sen 
Reviewed-By: Richard Lau 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 30 Jan 2022 03:46:18 GMT
   ✔  Approvals: 8
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41764#pullrequestreview-867072126
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41764#pullrequestreview-867091112
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867094356
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867110760
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867193237
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41764#pullrequestreview-867199780
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41764#pullrequestreview-867235295
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41764#pullrequestreview-868370661
   ✖  This PR needs to wait 6 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-01-30T19:05:07Z: https://ci.nodejs.org/job/node-test-pull-request/42247/
- Querying data for job/node-test-pull-request/42247/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1774881296

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Jan 31, 2022

This was referenced Feb 1, 2022

CI Reliability 2022-02-01 nodejs/reliability#189

Open

CI Reliability 2022-02-02 nodejs/reliability#190

Open

gengjiawen approved these changes

Feb 2, 2022

View reviewed changes

gengjiawen added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Feb 2, 2022

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Feb 2, 2022

nodejs-github-bot merged commit 4318b23 into nodejs:master

Feb 2, 2022

nodejs-github-bot commented Feb 2, 2022

Copy link

Copy Markdown

Collaborator

Landed in 4318b23

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Feb 3, 2022

CI Reliability 2022-02-03 nodejs/reliability#191

Open

41 tasks

github-actions Bot mentioned this pull request

Feb 4, 2022

CI Reliability 2022-02-04 nodejs/reliability#192

Open

38 tasks

ruyadorno pushed a commit that referenced this pull request

Feb 8, 2022


          src: fix typo in js_native_api_v8.cc

bbfa586

PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>

ruyadorno mentioned this pull request

Feb 8, 2022

v17.5.0 release proposal #41897

Merged

danielleadams pushed a commit that referenced this pull request

Mar 2, 2022


          src: fix typo in js_native_api_v8.cc

339b0e2

PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>

danielleadams mentioned this pull request

Mar 3, 2022

v16.14.1 release proposal #42200

Merged

danielleadams pushed a commit that referenced this pull request

Mar 3, 2022


          src: fix typo in js_native_api_v8.cc

50fd475

PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>

danielleadams pushed a commit that referenced this pull request

Mar 14, 2022


          src: fix typo in js_native_api_v8.cc

1cfc63e

PR-URL: #41764
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>

Reviewers

addaleax

addaleax approved these changes

lpinca

lpinca approved these changes

cjihrig

cjihrig approved these changes

tniessen

tniessen approved these changes

gengjiawen

gengjiawen approved these changes

richardlau

richardlau approved these changes

RaisinTen

RaisinTen approved these changes

+2 more reviewers

Mesteery

Mesteery approved these changes

VoltrexKeyva

VoltrexKeyva approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

c++

Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.